Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON-LD context does not expand as intended #2410

Closed
cmungall opened this issue Jul 28, 2023 · 3 comments · Fixed by #2483
Closed

JSON-LD context does not expand as intended #2410

cmungall opened this issue Jul 28, 2023 · 3 comments · Fixed by #2483
Assignees
@erik-whiting
Labels
attn: Technical WG Issues pertinent to technical activities, such as maintenance of website, PURLs, and tools ontology metadata Issues related to ontology metadata

Comments

@cmungall
Copy link
Contributor

cmungall commented Jul 28, 2023 •
edited

https://purl.obolibrary.org/meta/obo_context.jsonld

We can't have trailing underscores on expansions (and have it behave as expected). Sorry, I don't make the rules

More context here:

These would all have to be modified to be nested

      "RO": {
         "@id": "http://purl.obolibrary.org/obo/RO_",
         "@prefix": true
      }
@matentzn
Copy link
Contributor

@erik-whiting do you feel comfortable taking this on?

@cmungall
Copy link
Contributor Author

cmungall commented Jul 31, 2023 via email

@nlharris nlharris added ontology metadata Issues related to ontology metadata attn: Technical WG Issues pertinent to technical activities, such as maintenance of website, PURLs, and tools labels Aug 3, 2023
cthoyt added a commit to cthoyt/OBOFoundry.github.io that referenced this issue Nov 29, 2023
@cthoyt
Improve JSON-LD context export
11be102 
Closes OBOFoundry#2410 by using the `@id`/`@prefix` combination, which is required since JSON-LD technically doesn't support URI prefixes that end with an underscore `_`
@cthoyt cthoyt mentioned this issue Nov 29, 2023
Merged
@cthoyt
Copy link
Collaborator

cthoyt commented Nov 29, 2023

@erik-whiting see #2483

matentzn pushed a commit that referenced this issue Dec 12, 2023
@cthoyt
Improve JSON-LD context export (#2483)
e520f55 
* Improve JSON-LD context export

Closes #2410 by using the `@id`/`@prefix` combination, which is required since JSON-LD technically doesn't support URI prefixes that end with an underscore `_`

* Update processor.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erik-whiting erik-whiting

Labels
attn: Technical WG Issues pertinent to technical activities, such as maintenance of website, PURLs, and tools ontology metadata Issues related to ontology metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve JSON-LD context export cthoyt/OBOFoundry.github.io
5 participants
@cmungall @nlharris @cthoyt @matentzn @erik-whiting