-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve JSON-LD context export #2483
Conversation
Closes OBOFoundry#2410 by using the `@id`/`@prefix` combination, which is required since JSON-LD technically doesn't support URI prefixes that end with an underscore `_`
@jamesaoverton do you know any specific reason not to do this? It was requested by @cmungall and it is the "correct" thing to do. My gut feeling is wave it through, roll back if something breaks, but if you already kNOw something will break we might as well fix it first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This change is necessary, I guess, but quite annoying. We have a bunch of tools that predate the changes to JSON-LD that assume prefixes have to end with selected characters. We pushed back on that design decision but they ignored us. ROBOT packages Since we have to make this change, and we'll have to fix our workflows anyway, I think that this PR should also add the |
Sorry, I was wrong. Another 5 minutes of looking into this and I see that ROBOT does not just use the |
Ok the upshot is that ROBOT will need a minor update to handle this change before the next release. Not a problem. This reassures me that our workflows should not break as long as they are using JSON-LD libraries to work with the context file, and not doing it with custom code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested with ROBOT and this looks good. Thanks!
Since we're already changing the context, this would be a good time to add the obo
prefix, as requested in #2462.
@jamesaoverton I am happy to add that in either this PR or a follow-up one. Maybe there are other reservations, though, based on the discussion in #2462 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets see what breaks!
Closes #2410 by using the
@id
/@prefix
combination, which is required since JSON-LD technically doesn't support URI prefixes that end with an underscore_
cc @cmungall