Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.0]update travis config to properly test odoo modules #469

Merged
merged 3 commits into from Apr 6, 2016

Conversation

petrus-v
Copy link

@petrus-v petrus-v commented Apr 5, 2016

Try to fix #467 for the moment just copy/paste .travis.yml file from 8.0 branch

@petrus-v
Copy link
Author

petrus-v commented Apr 5, 2016

Hum... do we test PR with travis on this repo?... I'm going to commit a fake commit to trigger travis build on from my repo as I don't know how to launch for the first time travis build without pushing something...

@petrus-v
Copy link
Author

petrus-v commented Apr 5, 2016

What a strange story... this time travis is running the PR!

It failed, not as expected but that's already better than it was! we are now testing odoo modules!

Lets have a look what's wrong with DAV!...

@hbrunn
Copy link
Member

hbrunn commented Apr 5, 2016

looking good so far! For 8.0, this was a quite frustrating exercise because there were a lot of cycles of fixing some small thing, rerunning travis, fix the next etc. You might want to first exclude all modules that cause problems, and only after that reenable them one by one. We're better off with partial tests than with no tests at all.

@petrus-v
Copy link
Author

petrus-v commented Apr 5, 2016

Last commit I've add the installation of pywebdav in travis script but I wonder if it's the good place according OCA practices?!

This time travis is failing as expected! we have to fix it but to me it should be done in an other PR!

@hbrunn
Copy link
Member

hbrunn commented Apr 5, 2016

I think what you do with pywebdav is perfectly fine. It would be preferred to install it in the apt section, but according to https://github.com/travis-ci/apt-package-whitelist/blob/master/ubuntu-precise, it's not available. And requesting it won't do much good I guess because we need a specific version.

👍

@hbrunn hbrunn added this to the 7.0 milestone Apr 5, 2016
@petrus-v
Copy link
Author

petrus-v commented Apr 5, 2016

@hbrunn

thanks for your answers!

@pedrobaeza
Copy link
Member

Thanks for bringing this to the old good 7.0!

👍

@StefanRijnhart
Copy link
Member

Thanks! 👍

@hbrunn hbrunn merged commit a7dc3e1 into OCA:7.0 Apr 6, 2016
@hbrunn
Copy link
Member

hbrunn commented Apr 6, 2016

I used the new squash-and-merge-feature (https://github.com/blog/2141-squash-your-commits, don't mind the date), yay!

@StefanRijnhart
Copy link
Member

Oh dear, that new feature is going to wreak havoc on those of us who let their old PRs linger in the merge section of their buildouts after they have been squashed-and-merged...

@pedrobaeza
Copy link
Member

Which date is used then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants