[11.0][Backport] Fix widget handle #855
Conversation
|
This PR has the |
Tardo
force-pushed
the
11.0-bp-fix-widget_handle
branch
from
30ee1a7
to
c65c8fe
Compare
|
Changes done: files removed. |
Tardo
force-pushed
the
11.0-bp-fix-widget_handle
branch
from
c65c8fe
to
9a7eac0
Compare
|
Changes done |
The sequence had a static default value, but when there is an handle, it's important that new items are added at the top or the bottom of the list. This is a rare case where the defaul_get from the server will be ignored by the view for a certain field. This will work: - both in editable mode (inline) and in dialog mode, - both for X2Many and standalone list.
… set This fixes the following bug: Creating an Invoice, clicking on Validate (with no invoice line), and then trying to add a product. Before this fix, this would throw an error message. Now it works.
Before this commit, the compute sequence was relying on the fact the ID was used as a secondary order key to get the right result. This is necessary when adding items between pages because we don't resequence the following elements. However this was not necessary when adding new elements on the last page since there are no following elements to resesquence in that case. PR: odoo#27639
Tardo
force-pushed
the
11.0-bp-fix-widget_handle
branch
from
9a7eac0
to
b944100
Compare
|
Changes done |
|
/ocabot merge |
|
What a great day to merge this nice PR. Let's do it! |
|
This PR has the |
|
Congratulations, your PR was merged at e9d2d40. Thanks a lot for contributing to OCA. ❤️ PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into |
Description of the issue/feature this PR addresses:
Widget handle doesn't update the sequence properly
Current behavior before PR:
Sequence is not correctly updated
Desired behavior after PR is merged:
Sequence is correctly updated
Cc @Tecnativa
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr