[FIX] base: impossible to change contact name format #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create a sales order for a company with a contact name. - Click the Preview button. - The company and contact names appear on the same line, only separated by a comma. Before this commit: it's not possible to easily override this behavior. After this commit: it's possible to override `Partner._get_contact_name` to change the format of contact name. Beware that this method is used in `_get_name` which is called from various places. A check on the context may be necessary.
grindtildeath
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idem as odoo#38100 for 10.0
comma.
Before this commit:
it's not possible to easily override this behavior.
After this commit:
it's possible to override
Partner._get_contact_nameto change the format ofcontact name.
Beware that this method is used in
_get_namewhich is called from variousplaces. A check on the context may be necessary.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr