Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] Changes to lp:openupgrade-server/8.0 so far (revno. 5147) #1

Merged
merged 5 commits into from
May 28, 2014

Conversation

StefanRijnhart
Copy link
Member

This is injecting the OpenUpgrade-specific changes to a fork of odoo/trunk. I got these as follows:

The last 'proper' commit on lp:openobject-server/trunk is 5218, which corresponds to revision 4f5cc00 of odoo/master. I merged this bzr revision into lp:openupgrade-server/8.0, then took a diff between these corresponding versions of lp:openupgrade-server/8.0 and lp:openobject-server/trunk (using diff openobject-server openupgrade-server -rN --exclude=.bzr -U8 > diff). Then I applied this patch to the git branch and pushed to this location.

Should be a decent starting point.

Stefan Rijnhart added 3 commits May 19, 2014 15:48
[RFR] Flake8
[FIX] Adapt import location of get_module_path
[FIX] Replaced occurrence of 'pool' by 'registry'
[FIX] Bogus import openerp.orm
@legalsylvain
Copy link
Contributor

Do you want some review on this big MP ?

Regards.

Stefan Rijnhart added 2 commits May 26, 2014 21:50
installed multiple times in the database so no records can be
generated for them in the OpenUpgrade analysis phase.
@StefanRijnhart
Copy link
Member Author

This has turned into my working branch over the last couple of days,
because I don't know how to emulate the 'prerequisite branch' feature
from Launchpad (maybe it is not needed using git). But yes, it would be
cool if some could browse through the additional commits (the ones after
the initial Launchpad port, which should be clear) and merge if it
looked OK.

@StefanRijnhart
Copy link
Member Author

BTW I get the feeling I should have forked first as StefanRijnhart/OpenUpgrade.git and then started hacking and requesting a pull as I seem to pollute the branch namespace of this team/project combination. Can someone confirm?

@legalsylvain
Copy link
Contributor

I just discover GitHub so maybe I'll say foolishness but it seem that the
url https://github.com/OpenUpgrade/OpenUpgrade/branches/8.0-analysis is not
correct and must by something like https//
github.com/StefanRijnhart/openupgrade-8.0-some-comment
.

When you fork you have the possibility to choose in which "domain" you
fork.

But again, i'm totally newb on Github.

Regards.

Sylvain LE GAL

2014-05-26 22:09 GMT+02:00 Stefan Rijnhart notifications@github.com:

BTW I get the feeling I should have forked first as
StefanRijnhart/OpenUpgrade.git and then started hacking and requesting a
pull as I seem to pollute the branch namespace of this team/project
combination. Can someone confirm?


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-44215221
.

@blaggacao
Copy link

About

decent staring point

it could probably also be a decent occasion to welcome new ideas. Therefore I wanted to throw in: "migration process with graphical tool" in the realm of pentaho kettle.

I contacted you, @StefanRijnhart on Mail for an opinion on that idea. So maybe here this opinion could be openly shared? Maybe this is the wrong place to do so, in that case, just shut me down ;)

@StefanRijnhart
Copy link
Member Author

@biaggacao Like I wrote in my answer email to you, please discuss this on the Community mailing list on Launchpad. It does sound useful but out of scope for OpenUpgrade.

StefanRijnhart pushed a commit that referenced this pull request May 28, 2014
[ADD] Changes to lp:openupgrade-server/8.0 so far (revno. 5147)
@StefanRijnhart StefanRijnhart merged commit c98302f into master May 28, 2014
@StefanRijnhart StefanRijnhart deleted the port_lp_5147 branch May 28, 2014 15:38
@pankk pankk mentioned this pull request Sep 26, 2014
legalsylvain added a commit that referenced this pull request Aug 17, 2015
hbrunn referenced this pull request in hbrunn/OpenUpgrade Jun 14, 2016
hbrunn pushed a commit that referenced this pull request Dec 26, 2016
StefanRijnhart pushed a commit that referenced this pull request Apr 13, 2017
mvaled added a commit to merchise-autrement/OpenUpgrade that referenced this pull request Nov 1, 2017
Otherwise, when loading the logged user would not have access to the
`ir.module.module` and this rather technical operation fail.

Fixes OCA#1
Closes !1.
pedrobaeza pushed a commit that referenced this pull request Oct 1, 2019
Have an inherited view replacing a node in its parent
namely:

```
<view name="1">
<world/>
<world/>
<world/>
</view>
```

Inherited by
```
<view name="2" inherit_id="1">
<xpath expr="//world[1]" position="replace">
<world/>
</xpath>
</view>
```

Before this commit, the resulting xpath branding of the nodes
(useful for web_editor, to know where it is supposed to anchor new elements)
was incorrect. Note that there is the branding attr data-oe-view_id which specifies in which view they are

The 2nd and 3rd world in view #1 were numbered respectively world[1] and world[2]
which is incorrect since we *know* those should be world[2] and world[3]
(in their own view, i.e. in view #1)
This was because when replacing the node, the code lost track of what it replaced
and that it attributed the inheriting branding to the replacing nodes

After this commit, the 2nd and 3rd world nodes are numbered
world[2] and world[3] respectively

OPW 2007312

closes odoo/odoo#35134

Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
zamberjo added a commit to aurestic/OpenUpgrade that referenced this pull request Nov 15, 2019
pedrobaeza pushed a commit that referenced this pull request Apr 24, 2020
sbidoul pushed a commit to acsone/OpenUpgrade that referenced this pull request Jun 28, 2020
Steps to reproduce:
1. Open sales on mobile
2. Click on the search icon (with breadcrumb)

    Issue OCA#1:
    The displayed cross on the right suggests to users that it's
    used to close the facets but it's not.
    We replace it by a back arrow to close the search like in other
    apps.

3. Click on create 'Create'
4. Select a customer (Without breadcrumb)

   Issue OCA#2:
   We don't have any breadcrumb inside the control_panel,
   so we should always display the search. There is no
   need to open/close it.

Task ID: 2200099

closes odoo/odoo#46086

Related: odoo/enterprise#9486
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
gdgellatly added a commit that referenced this pull request Sep 8, 2021
[IMP] remove useless test during update
tranngocson1996 pushed a commit to tranngocson1996/OpenUpgrade that referenced this pull request Jan 6, 2022
tranngocson1996 pushed a commit to tranngocson1996/OpenUpgrade that referenced this pull request Jan 6, 2022
@remi-filament remi-filament mentioned this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants