[ADD] calendar migration #112

hbrunn · 2014-10-22T16:05:35Z

No description provided.

[IMP] use renamed modules from openupgrade_records

[IMP] adapt spelling/fomratting in rst file

pedrobaeza · 2014-11-10T15:52:39Z

openerp/openupgrade/doc/source/modules70-80.rst

@@ -50,7 +50,7 @@ Status :
 +-----------------------------------+-----------------------------------+
 |account_test                       | Nothing to do                     |
 +-----------------------------------+-----------------------------------+
-|account_voucher                    | done                              |
+|account_voucher                    | Done                              |


This can be due to a bad rebased. Please check it.

pedrobaeza · 2014-11-10T15:53:53Z

I don't see where crm_meeting_id column is renamed.

hbrunn · 2014-11-10T15:56:41Z

addons/calendar/migrations/8.0.1.0/post-migration.py

+    cr.execute(
+        'alter table calendar_event add column %s int' % (
+            openupgrade.get_legacy_name('crm_meeting_id'),
+        )


@pedrobaeza here i create the column

Thanks, I see now the trick.

But don't you think this should be on crm migration script instead here? You can for example install hr_holidays, that depends on calendar, but not crm, making this script fails.

not really. crm.meeting was defined in base_calendar in 7.0, so you'll have that for every module depending on base_calendar. This is also why migrating it belongs into this migration script.

Thanks for the explanation.

pedrobaeza · 2014-11-10T16:14:25Z

Very good work.

👍

StefanRijnhart · 2014-11-13T16:45:46Z

Well done! Please include the changes to ir_cron_scheduler_alarm as printed by scripts/compare_noupdate_xml_records.py from the 7.0 server edition.

StefanRijnhart · 2014-11-13T16:53:07Z

addons/calendar/migrations/8.0.1.0/post-migration.py

+        %s, calendar_alarm.id
+        from calendar_alarm join res_alarm
+        on %s=res_alarm.id
+        where %s=%s


While you make work to migrate the links to the old calendar alarms, don't you need to migrating the existing res.alarm records to calendar.alarm?

hbrunn · 2014-11-17T11:42:24Z

@StefanRijnhart thanks for your pointers. The alarm migration was completely misguided, now I got it right I think. res.alarms by themselves never did anything, so I don't think there's something to migrate. But we need to migrate the relation between events and alarms and between meetings and alarms, that happens now.

recomputed fields

vaab · 2014-12-04T09:39:12Z

in function import_crm_meeting, line 81, you write:

cr.execute(
     '''update meeting_category_rel
        set event_id=calendar_event.id
        from calendar_event where event_id=%s''' % (
        openupgrade.get_legacy_name('crm_meeting_id'),
     )
)

But how can this work without breaking foreign key constraints ? Your event_id value is changed from integers pointing to crm_meeting table to integers pointing to calendar_event table...

I do get insert or update on table "meeting_category_rel" violates foreign key constraint "meeting_category_rel_event_id_fkey". while testing your code.

Sorry if I missed something important. Would be happy if you cleared out my mind on this topic.

hbrunn · 2014-12-04T13:51:35Z

thanks, you missed nothing. This worked in my test database out of simple coincidence

hbrunn · 2014-12-04T14:02:40Z

the commit above should fix it

vaab · 2014-12-05T02:08:45Z

thx, the full calendar migration works now on my database. (~7000 crm_meetings)

[ADD] calendar migration

gwizo · 2014-12-13T11:34:34Z

Having some issues with calendar migration as well not sure if its the same as the thread above. Trying to migrate from 7.0 to 8.0 .
2014-12-13 11:06:20,952 5045 INFO erp_migrated openerp.modules.migration: module hr_holidays: Running migration [>8.0.1.5] pre-migration
2014-12-13 11:06:20,952 5045 INFO erp_migrated openerp.modules.migration: module hr_holidays: Running migration [>8.0.1.5] pre-migration
2014-12-13 11:06:20,955 5045 ERROR erp_migrated openerp.sql_db: Programming error: column "openupgrade_legacy_8_0_crm_meeting_id" does not exist
LINE 3: from calendar_event where meeting_id=openupgrade_leg...
^
, in query update hr_holidays
set meeting_id=calendar_event.id
from calendar_event where meeting_id=openupgrade_legacy_8_0_crm_meeting_id
2014-12-13 11:06:20,956 5045 CRITICAL erp_migrated openerp.service.server: Failed to initialize database erp_migrated.
Traceback (most recent call last):
File "/var/tmp/openupgrade/8.0/server/openerp/service/server.py", line 901, in preload_registries
registry = RegistryManager.new(dbname, update_module=update_module)
File "/var/tmp/openupgrade/8.0/server/openerp/modules/registry.py", line 324, in new
openerp.modules.load_modules(registry._db, force_demo, status, update_module)
File "/var/tmp/openupgrade/8.0/server/openerp/modules/loading.py", line 387, in load_modules
force, status, report, loaded_modules, update_module, upg_registry)
File "/var/tmp/openupgrade/8.0/server/openerp/modules/loading.py", line 295, in load_marked_modules
loaded, processed = load_module_graph(cr, graph, progressdict, report=report, skip_modules=loaded_modules, perform_checks=perform_checks, upg_registry=upg_registry)
File "/var/tmp/openupgrade/8.0/server/openerp/modules/loading.py", line 162, in load_module_graph
migrations.migrate_module(package, 'pre')
File "/var/tmp/openupgrade/8.0/server/openerp/modules/migration.py", line 179, in migrate_module
mod.migrate(self.cr, pkg.installed_version)
File "/var/tmp/openupgrade/8.0/addons/hr_holidays/migrations/8.0.1.5/pre-migration.py", line 30, in migrate
openupgrade.get_legacy_name('crm_meeting_id'),
File "/var/tmp/openupgrade/8.0/server/openerp/sql_db.py", line 158, in wrapper
return f(self, _args, *_kwargs)
File "/var/tmp/openupgrade/8.0/server/openerp/sql_db.py", line 234, in execute
res = self._obj.execute(query, params)
ProgrammingError: column "openupgrade_legacy_8_0_crm_meeting_id" does not exist
LINE 3: from calendar_event where meeting_id=openupgrade_leg...
^

[ADD] calendar migration (wip)

4002938

[IMP] use renamed modules from openupgrade_records

hbrunn added the work in progress label Oct 22, 2014

[IMP] use renamed modules from openupgrade_records

a58e376

hbrunn added this to the 8.0 milestone Oct 22, 2014

hbrunn self-assigned this Oct 22, 2014

hbrunn added 7 commits October 30, 2014 09:20

[FIX] coding style

19be777

[ADD] meeting migration to events works

868f1a5

[ADD] migrate calendar attendees

6d86d44

[ADD] migration alarms work

6159c13

[ADD] move deprecated columns to legacy fields

85e5705

[ADD] map changed selection values

b59b4dc

[FIX] map crm.meeting's messages to calendar.events

01f80b6

hbrunn added needs review and removed work in progress labels Nov 3, 2014

hbrunn changed the title ~~[ADD] calendar migration (wip)~~ [ADD] calendar migration Nov 3, 2014

hbrunn added 2 commits November 3, 2014 17:32

Merge remote-tracking branch 'origin/8.0' into 8.0-calendar

f815cf5

[ADD] declare the calendar module being ported

4a9847e

[IMP] adapt spelling/fomratting in rst file

hbrunn mentioned this pull request Nov 10, 2014

[ADD] hr_holidays migration #130

Merged

pedrobaeza reviewed Nov 10, 2014
View reviewed changes

hbrunn reviewed Nov 10, 2014
View reviewed changes

hbrunn added 2 commits November 10, 2014 17:01

[FIX] revert fixing other module's coverage entries

7051db5

[FIX] fluke in modules70-80.rst

ed5940f

StefanRijnhart reviewed Nov 13, 2014
View reviewed changes

hbrunn added 2 commits November 17, 2014 10:49

[ADD] load noupdate data

8327d44

[FIX] correctly migration relation between alarms and events

f417abe

[FIX] call set_message_last_post at the end to avoid errors from not yet

35db269

recomputed fields

[FIX] cope with duration==null

ff0de02

pedrobaeza mentioned this pull request Dec 4, 2014

7.0 to 8.0: Key (meeting_id)=(15) is not present in table "calendar_event" #150

Closed

[FIX] drop and recreate constraint meeting_category_rel_event_id_fkey

52efdfd

pedrobaeza added a commit that referenced this pull request Dec 8, 2014

Merge pull request #112 from hbrunn/8.0-calendar

d300b03

[ADD] calendar migration

pedrobaeza merged commit d300b03 into OCA:8.0 Dec 8, 2014

hbrunn removed their assignment Jun 27, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD] calendar migration #112

[ADD] calendar migration #112

hbrunn commented Oct 22, 2014

pedrobaeza Nov 10, 2014

pedrobaeza commented Nov 10, 2014

hbrunn Nov 10, 2014

pedrobaeza Nov 10, 2014

pedrobaeza Nov 10, 2014

hbrunn Nov 10, 2014

pedrobaeza Nov 10, 2014

pedrobaeza commented Nov 10, 2014

StefanRijnhart commented Nov 13, 2014

StefanRijnhart Nov 13, 2014

hbrunn commented Nov 17, 2014

vaab commented Dec 4, 2014

hbrunn commented Dec 4, 2014

hbrunn commented Dec 4, 2014

vaab commented Dec 5, 2014

gwizo commented Dec 13, 2014

[ADD] calendar migration #112

[ADD] calendar migration #112

Conversation

hbrunn commented Oct 22, 2014

pedrobaeza Nov 10, 2014

Choose a reason for hiding this comment

pedrobaeza commented Nov 10, 2014

hbrunn Nov 10, 2014

Choose a reason for hiding this comment

pedrobaeza Nov 10, 2014

Choose a reason for hiding this comment

pedrobaeza Nov 10, 2014

Choose a reason for hiding this comment

hbrunn Nov 10, 2014

Choose a reason for hiding this comment

pedrobaeza Nov 10, 2014

Choose a reason for hiding this comment

pedrobaeza commented Nov 10, 2014

StefanRijnhart commented Nov 13, 2014

StefanRijnhart Nov 13, 2014

Choose a reason for hiding this comment

hbrunn commented Nov 17, 2014

vaab commented Dec 4, 2014

hbrunn commented Dec 4, 2014

hbrunn commented Dec 4, 2014

vaab commented Dec 5, 2014

gwizo commented Dec 13, 2014