Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] Files lost in the 6.1 migration to git #190

Merged
merged 3 commits into from
Jan 6, 2015

Conversation

StefanRijnhart
Copy link
Member

Add some files lost in the 6.1 migration to git. Some directories were missing from the doc directory. Instead of re-adding them, remove doc altogether as it is maintained on the latest version of OpenUpgrade.

@StefanRijnhart StefanRijnhart changed the title [ADD] Files lost in the migration to git [ADD] Files lost in the 6.1 migration to git Jan 1, 2015
@pedrobaeza
Copy link
Member

I have checked and some files are indeed missing. But why are you removing entire doc folder? Is for only maintaining it on last version? I see that OK, but I wonder if we can keep here modules60-61.rst with a possibility to link in 8.0 this file, for each possible PR against this branch that modifies also the corresponding documentation. Maybe a hard include link via Github blob URLs?

@StefanRijnhart
Copy link
Member Author

Looks like we would need to look to git submodules to do this properly, but it seems a bit overengineered and complicated for that. I don't really care that much about keeping an obsolete version of the docs there. The person to merge the PR can simply edit the coverage file online on GitHub in the current version of the docs.

@pedrobaeza
Copy link
Member

👍 for the PR

What about making an RST link?

@StefanRijnhart
Copy link
Member Author

You mean, include an RST document that includes a file from https://doc.therp.nl/openupgrade? Note that I actually replace the documentation by a small readme that links to the online documentation: https://github.com/StefanRijnhart/OpenUpgrade/blob/6.1-git_missing_from_lib/openerp/openupgrade/doc/README.txt. Is that not enough?

@pedrobaeza
Copy link
Member

No, I mean a link in the 8.0 documentation, that it's compiled and show in https://doc.therp.nl/openupgrade/, to this file modules60-61.rst here in 6.1 branch, vía an rst link to https://github.com/OpenUpgrade/OpenUpgrade/blob/6.1/openerp/openupgrade/doc/source/modules60-61.rst. And the same for the rest of the branches. This way, we can maintain module coverage in the corresponding branch. Do you understand me?

@StefanRijnhart
Copy link
Member Author

Sounds fine. Any idea on how to include a file from an online location in the RST index?

@pedrobaeza
Copy link
Member

Let me investigate about that, but I have no control nor knowledge about the compiling to readthedocs, so my tests are going to be partial.

@StefanRijnhart
Copy link
Member Author

Good luck. I just spend some time on it and I can't seem to figure it out...

@pedrobaeza
Copy link
Member

You're right: submodules implies a heavy weight, because you have to treat with full repos, and .. include:: doesn't allow external links.

We have to resigned for now...

@legalsylvain legalsylvain added this to the 6.1 milestone Jan 4, 2015
@hbrunn
Copy link
Member

hbrunn commented Jan 6, 2015

👍

hbrunn added a commit that referenced this pull request Jan 6, 2015
[ADD] Files lost in the 6.1 migration to git
@hbrunn hbrunn merged commit 9d55f03 into OCA:6.1 Jan 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants