10.0 fix point of sale bad invoice journal #2331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addons/point_of_sale/migrations/10.0.1.0.1/openupgrade_analysis_work.txt
Show resolved
Hide resolved
|
Hi @MiquelRForgeFlow. could you update your review ? thansk ! |
MiquelRForgeFlow
approved these changes
May 28, 2020
|
/ocabot merge |
|
Hi @legalsylvain. Your command failed:
Ocabot commands
More information
|
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 3ee95cb. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
The V10 introduce on
pos.configa new journal fieldinvoice_journal_idCurrent behavior before PR:
The default function
_default_invoice_journalis used to populate this new column. (see)the journal ID will be wrong in a multi company context.
Fix
Added a pre-migration script to add the field, if not exist. (the field can exist if the module V8 pos_invoice_journal is installed)
CC : original authors : @JordiBForgeFlow, @MiquelRForgeFlow
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr