[12.0][FIX] stock: company_id of stock rule should be the same as the warehouse

[MiquelRForgeFlow]

This is not literally an "issue" in v12, but it's good to have data correctness.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

[pedrobaeza]

In which cases this is not happening? Is due to bad manual configuration or migrated DB or migrated DB with current script-set?

[pedrobaeza]

Anyway, please change it only when it's different (and take care about the comparison with NULL).

[MiquelRForgeFlow]

In which cases this is not happening? Is due to bad manual configuration or migrated DB or migrated DB with current script-set?

I just found migrating a DB, and found check in v13. I think the problem is due to company_id having the default=lambda self: self.env.user.company_id. Thus, if rules are created with sudo or during migration, then they will have the company of the admin.

[MiquelRForgeFlow]

and take care about the comparison with NULL

Is not enough adding "AND sw.company_id != sr.company_id"?

[pedrobaeza]

It seems not all comparisons with possible values are working well with NULL.

[MiquelRForgeFlow]

Closing in favor of #2456 due to wrong remote.