[9.0][OU-FIX] #2339, purge obsolete models and fields #2535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanRijnhart
changed the title
StefanRijnhart
force-pushed
the
fix/9.0/noupdate_set_false_where_null
branch
9 times, most recently
from
ca7f3a7
to
50fa2e0
Compare
StefanRijnhart
force-pushed
the
fix/9.0/noupdate_set_false_where_null
branch
11 times, most recently
from
5424513
to
0ab7097
Compare
StefanRijnhart
changed the title
Fixes OCA#2339 * add loaded models and fields to the set of loaded XMLIDs * purge models and fields with noupdate NULL instead of FALSE Also * consult model's _fields instead of _columns when updating field XMLIDs as it is more complete * remove coverage as it is giving out red marks to PRs for no reason * check reference count before deleting a record after module upgrade * improve logging when deletion fails (should be rare now) * pass context to `unlink` to effectuate the module uninstall flag * reduce logging of deletions in CI * remove model relations, constraints and fields from ir.model's unlink to prevent IntegrityErrors * only apply integrity check to manual fields This PR is part of a set of PRs for OpenUpgrade 9.0 up to 13.0. Background: While Odoo deletes obsolete field and model entries from the data model metadata explicitely in their migration scripts, in OpenUpgrade I have always meant to rely on the mechanism of purging 'untouched' XMLIDs that takes care of the deletion of obsolete data records (e.g. views). However, this mechanism was not applied to field and model entries because their XMLIDs were created with noupdate NULL instead of FALSE and as such excluded in the query to gather all obsolete data records. Also missing was marking the XMLIDs of fields and models as loaded in the first place. All of this is working properly in Odoo 13 (introduced gradually across new releases) so all of this is backported from newer versions one way or another.
StefanRijnhart
force-pushed
the
fix/9.0/noupdate_set_false_where_null
branch
from
0ab7097
to
5afbbb6
Compare
StefanRijnhart
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2339
Also
as it is more complete
unlinkto effectuate the module uninstall flagto prevent IntegrityErrors
This PR is part of a set of PRs for OpenUpgrade 9.0 up to 13.0. Background:
While Odoo deletes obsolete field and model entries from the data model
metadata explicitely in their migration scripts, in OpenUpgrade I have
always meant to rely on the mechanism of purging 'untouched' XMLIDs that
takes care of the deletion of obsolete data records (e.g. views).
However, this mechanism was not applied to field and model entries because
their XMLIDs were created with noupdate NULL instead of FALSE and as such
excluded in the query to gather all obsolete data records.
Also missing was marking the XMLIDs of fields and models as loaded in the
first place.
All of this is working properly in Odoo 13 (introduced gradually across new
releases) so all of this is backported from newer versions one way or
another.