[15.0][OU-ADD] pos_order_return: Merged in point_of_sale #4191
Conversation
stefan-tecnativa
force-pushed
the
15.0-mig-pos_order_return
branch
from
fe01ec9
to
95110b5
Compare
There was a problem hiding this comment.
On the commit message (I paste it here as I can't comment inline of it :))
This module
The OCA module pos_order_return
allows
Write in past tense as we're leaving it behind
the user to return a sale_order fully or partially in the frontend.
This isn't true. What it did was:
- to link refunds with their original orders
- to allow partial refunds (Odoo only allowed full ones)
Now this feature is accomplished in core...
From Odoo v16 we can do this in core from the frontend and those links are paired to the ones we were providing.
One think
thing
that adds this module that isn't in core is a boolean indicating if you want to allow negative quantities on the POS for products. This feature can be discussed if it is worth it to be conserved in a custom module or not.
Talk about the logic:
This module also added the restriction for negative quantities in the point of sale. It can be considered for an extra module as it was a little bit out of context anyway.
| cr, | ||
| """ | ||
| ALTER TABLE pos_order_line | ||
| ADD COLUMN IF NOT EXISTS refunded_orderline_id INTEGER |
There was a problem hiding this comment.
I'd say it would be enough renaming the fields: returned_line_id and refund_line_ids to their new pairs in point_of_sale
There was a problem hiding this comment.
Understood
stefan-tecnativa
force-pushed
the
15.0-mig-pos_order_return
branch
2 times, most recently
from
ff41db8
to
45ecf5e
Compare
stefan-tecnativa
force-pushed
the
15.0-mig-pos_order_return
branch
from
45ecf5e
to
010de0f
Compare
Changed! |
openupgrade_scripts/scripts/point_of_sale/15.0.1.0.1/pre-migration.py
Outdated
Show resolved
Hide resolved
stefan-tecnativa
force-pushed
the
15.0-mig-pos_order_return
branch
from
010de0f
to
a621290
Compare
openupgrade_scripts/scripts/point_of_sale/15.0.1.0.1/pre-migration.py
Outdated
Show resolved
Hide resolved
stefan-tecnativa
force-pushed
the
15.0-mig-pos_order_return
branch
from
a621290
to
9870b5c
Compare
openupgrade_scripts/scripts/point_of_sale/15.0.1.0.1/pre-migration.py
Outdated
Show resolved
Hide resolved
stefan-tecnativa
force-pushed
the
15.0-mig-pos_order_return
branch
from
9870b5c
to
2237732
Compare
TT45179 The OCA module pos_order_return allows the user to partially return a sale_order in the frontend, and also links this refunds with their original orders. From Odoo v15 we can do this in core from the frontend and those links are paired to the ones we were providing. One thing that adds this module that isn't in core is a boolean indicating if you want to allow negative quantities on the POS for products. This feature can be discussed if it is worth it to be conserved in a custom module or not as it was a little out of context anyway.
stefan-tecnativa
force-pushed
the
15.0-mig-pos_order_return
branch
from
2237732
to
b0ecf0e
Compare
|
@pedrobaeza can you take a look again please? |
TT45179 @Tecnativa
The OCA module pos_order_return allows the user to partially return a sale_order in the frontend, and also links this refunds with their original orders. From Odoo v15 we can do this in core from the frontend and those links are paired to the ones we were providing. One thing that adds this module that isn't in core is a boolean indicating if you want to allow negative quantities on the POS for products. This feature can be discussed if it is worth it to be conserved in a custom module or not as it was a little out of context anyway.
@chienandalu please review!