Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][OU-ADD] mail: migration to 17.0 #4431

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from
Open

[17.0][OU-ADD] mail: migration to 17.0 #4431

wants to merge 1 commit into from
+717 −1

Conversation

duong77476-viindoo
Copy link
Contributor

No description provided.

@duong77476-viindoo duong77476-viindoo mentioned this pull request May 22, 2024
Merged
2 tasks
@pedrobaeza
Copy link
Member

/ocabot migration mail

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone May 25, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request May 25, 2024
Open
23 tasks
@pedrobaeza pedrobaeza changed the title [OU-ADD] mail: migration to 17.0 [17.0][OU-ADD] mail: migration to 17.0 May 25, 2024
@flachica
Copy link

I need to send suggestion to this PR. I need remove some views. What is the best way to send it?. I need to test previously in my own branch. This is the reason because I send PR to this branch

@duong77476-viindoo
Copy link
Contributor Author

I need to send suggestion to this PR. I need remove some views. What is the best way to send it?. I need to test previously in my own branch. This is the reason because I send PR to this branch

Which view you want to remove and why?
You can go to files changed and leave some reviews there, first time on github ?

@pedrobaeza
Copy link
Member

No, views are never needed to be removed manually in OU.

@flachica
Copy link

No, views are never needed to be removed manually in OU.

The mail.mail_channel_view_kanban view have an element with attrs attribute that is forbbiden in 17.0. What is the correct way to solve this without remove it manually . . .if exists?

@pedrobaeza
Copy link
Member

pedrobaeza commented Jun 27, 2024 •
edited
Loading

Check my comment at #4431 (comment)

If that doesn't happen, then the patch is not correctly done (or should be expanded) at openupgrade_framework level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flachica flachica flachica left review comments

@pedrobaeza pedrobaeza pedrobaeza left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@duong77476-viindoo @pedrobaeza @flachica @OCA-git-bot