-
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] all in one 2016-06-14 #509
[ADD] all in one 2016-06-14 #509
Conversation
…e for kanban_state in new post-migration.py
Hey @hbrunn, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
@hbrunn, this is being PRed to the regular 9.0 branch. Is this what you intend? |
yes, I want first check if the tests work. Then I think we can just merge it. What I want to avoid are the long standing PRs for months, this frustrates contributors just as much as users. |
But I think that scripts are not ready for production yet. I prefer to rebase each PR and check independently. |
I think this is going to slow down development a lot |
As each module migration is independent from each other (most of the times), I don't think so, but let's see what others say. |
actually, nearly every module depends on account, mail, product or the like. Having those as lurking PRs complicates things needlessly in my opinion. What do @OCA/openupgrade-maintainers think? |
I'm already losing oversight, so let's start with the bottom dependencies. |
@StefanRijnhart what is your proposal? My plan is to make this PR green, have you guys merge it, and from then on, we can merge fast because the basics are covered and new PRs will be green if they don't mess up. |
OK, let's do it. |
yay! Just wait until travis finishes, then we should have 100% coverage |
This is an umbrella PR for the existing 9.0 PRs, pushed to @OpenUpgrade-dev so that the regular contributors and simply add their stuff there. The hope is that this passes the tests and we can just merge it.