Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] all in one 2016-06-14 #509

Merged
merged 80 commits into from
Jun 14, 2016

Conversation

hbrunn
Copy link
Member

@hbrunn hbrunn commented Jun 14, 2016

This is an umbrella PR for the existing 9.0 PRs, pushed to @OpenUpgrade-dev so that the regular contributors and simply add their stuff there. The hope is that this passes the tests and we can just merge it.

@hbrunn hbrunn added this to the 9.0 milestone Jun 14, 2016
@oca-clabot
Copy link

Hey @hbrunn, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

  • Vincent Coll (no github login found)

Appreciation of efforts,
OCA CLAbot

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 0839383 on OpenUpgrade-dev:9.0-all-in-one-2016-06-14 into 3a4570b on OCA:9.0.

@pedrobaeza
Copy link
Member

@hbrunn, this is being PRed to the regular 9.0 branch. Is this what you intend?

@hbrunn
Copy link
Member Author

hbrunn commented Jun 14, 2016

yes, I want first check if the tests work. Then I think we can just merge it. What I want to avoid are the long standing PRs for months, this frustrates contributors just as much as users.

@pedrobaeza
Copy link
Member

But I think that scripts are not ready for production yet. I prefer to rebase each PR and check independently.

@hbrunn
Copy link
Member Author

hbrunn commented Jun 14, 2016

I think this is going to slow down development a lot

@pedrobaeza
Copy link
Member

As each module migration is independent from each other (most of the times), I don't think so, but let's see what others say.

@hbrunn
Copy link
Member Author

hbrunn commented Jun 14, 2016

actually, nearly every module depends on account, mail, product or the like. Having those as lurking PRs complicates things needlessly in my opinion. What do @OCA/openupgrade-maintainers think?

@StefanRijnhart
Copy link
Member

I'm already losing oversight, so let's start with the bottom dependencies.

@hbrunn
Copy link
Member Author

hbrunn commented Jun 14, 2016

@StefanRijnhart what is your proposal? My plan is to make this PR green, have you guys merge it, and from then on, we can merge fast because the basics are covered and new PRs will be green if they don't mess up.

@StefanRijnhart
Copy link
Member

OK, let's do it.

@hbrunn
Copy link
Member Author

hbrunn commented Jun 14, 2016

yay! Just wait until travis finishes, then we should have 100% coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants