[ADD][8.0] stock_analytic #53

andhit-r · 2016-02-04T13:15:46Z

Move stock_analytic into OCA/account-analytic. The module retrieve from https://github.com/julius-network-solutions/julius-openobject-addons and https://github.com/ClearCorp-dev/stock-logistics-workflow.

Commit history preserved from both branch. Several merge conflict had been resolved.

pedrobaeza · 2016-02-04T13:17:23Z

stock_analytic/README.rst

+Contributors
+------------
+
+* Fabio Vílchez <fabio.vilchez@clearcorp.co.cr>


Add here Julius people and you

pedrobaeza · 2016-02-04T13:17:52Z

Same comments as in #52

andhit-r · 2016-02-04T13:19:10Z

@pedrobaeza i'm not confident regarding my retrieving technique. Is it safe to proceed?

pedrobaeza · 2016-02-04T13:29:34Z

Yeah, I think so. It seems totally correct.

andhit-r · 2016-02-04T14:39:28Z

@pedrobaeza I noticed that this module depend on purchase and sale module. Is it wise to depend on those modules since we only need stock_account to give analytic account capability to stock.move?

Maybe I could create stock_sale_analytic, stock_purchase_analytic, and maybe stock_mrp_analytic to achieve modularity.

pedrobaeza · 2016-02-04T15:09:47Z

For what is that modules needed? If there's no other choice, to keep modularity it would be good to split it.

andhit-r · 2016-02-04T15:24:45Z

I mean this original module will force users to install sale and purchase. I think the main functionality for this module only to give analytic account on stock.move. So when stock.move create account.move.line it will automatically fill analytic account field on account.move.line. So no need to depend on sale and purchase.

stock_sale_analytic
depend: stock_analytic, sale_stock
functionality: automatically give analytic account on stock.move according to project_id field on sale.order

stock_purchase_analytic
depend: purchase, stock_analytic
functionality: automatically give analytic account on stock.move according to account_analytic_id field on purchase.order

I don't like to force users install modules that they don't need. But if my suggestion is somehow overkill I will continue as it is.

pedrobaeza · 2016-02-04T15:28:57Z

No, of course is a good proposition, but I was asking for the reason to need sale or purchase modules. Now I understand that is to propagate the corresponding analytic accounts, but I agree that that should be done in the modules you propose. Maybe a better name should be sale_stock_analytic y purchase_analytic to follow Odoo's naming convention.

andhit-r · 2016-02-05T07:05:11Z

Ok @pedrobaeza. Thanks for your input. I will finish this module first.

andhit-r · 2016-02-05T14:04:09Z

Travis didn't run again

pedrobaeza · 2016-02-05T14:11:36Z

Seeing https://www.traviscistatus.com/, they experimented a problem and now they have some troubles to get up to date with all the checks, so wait a bit or try again to resubmit.

andhit-r · 2016-02-05T15:17:57Z

close to restart travis

andhit-r · 2016-02-16T07:22:35Z

@pedrobaeza would you kindly give need review label on this PR. Thanks before.

pedrobaeza · 2016-02-16T07:33:38Z

Done

andhit-r · 2016-02-16T07:35:53Z

Thanks @pedrobaeza.

andhit-r · 2016-04-15T06:38:44Z

Hi @OCA/accounting-maintainers would you kindly review this PR. Many thanks

pedrobaeza · 2016-04-19T11:34:15Z

👍

andhit-r · 2016-04-19T12:04:58Z

Thanks @pedrobaeza

andhit-r · 2016-05-11T12:51:11Z

Hi @OCA/accounting-maintainers would you kindly review this PR. Many thanks

JordiBForgeFlow · 2016-08-05T09:03:19Z

@aheficent and me will review.

andhit-r · 2016-08-05T09:11:00Z

Thank you @jbeficent

AaronHForgeFlow · 2016-08-08T09:36:20Z

stock_analytic/models/stock.py

+            res[1][2].update({
+                'analytic_account_id': move.account_analytic_id.id,
+            })
+        return res


IMHO I think It should create the analytic entries for income or expenses account only. This creates two analytic entries, one for the debit and one for the credit, even for assets accounts. Do you agree with me @andhit-r ?
cc @jbeficent

@aheficent agree. I push a commit to correct this. Analytic account will only be assigned if account != valuation account

Sorry for really-really late reply. Kindly review this again. Many thanks.

Thank you @andhit-r I like the proposed changes. There's a problem with runbot, so i will on local. The code looks correct to me.

AaronHForgeFlow · 2016-11-22T10:43:55Z

What else is needed to get this merged?

pedrobaeza · 2016-11-22T10:45:22Z

Get more reviewers. You haven't approved the PR yet and there's a question unanswered as I see.

andhit-r · 2016-12-03T09:51:14Z

Try to restart travis

[IMP] SMS erase print [IMP] Stock analytic XML part is now migrated

This module allows the user to generate analytic information from stock moves.

andhit-r · 2016-12-04T12:05:01Z

@jbeficent @aheficent all checks green. Would you kindly review it again. Many thanks.

@mikevhe18 @azmimr67 please help review

AaronHForgeFlow

I tested on local and reviewed the code and it works correctly. The only issue is related with the name of the field. What do you think about this?

AaronHForgeFlow · 2016-12-05T16:25:54Z

stock_analytic/models/stock.py

+class StockMove(models.Model):
+    _inherit = "stock.move"
+
+    account_analytic_id = fields.Many2one(


IMHO i think that the name of the field should be analytic_account_id. I think the name of the field should match the name of other modules as for example the account module https://github.com/OCA/OCB/blob/8.0/addons/account/account.py#L2398 or the project module https://github.com/OCA/OCB/blob/8.0/addons/project/project.py#L231

Add mikevhe18 as contributor

AaronHForgeFlow

Tested on runbot + code review 👍

Thank you @andhit-r and @mikevhe18 Great job!

mikevhe18 · 2016-12-15T01:21:32Z

👍 tested on runbot

FIX in kanban_project_open

pedrobaeza reviewed Feb 4, 2016
View reviewed changes

andhit-r changed the title ~~[ADD][WIP][8.0] stock_analytic~~ [ADD][8.0] stock_analytic Feb 5, 2016

andhit-r closed this Feb 5, 2016

andhit-r reopened this Feb 5, 2016

pedrobaeza added the needs review label Feb 16, 2016

AaronHForgeFlow reviewed Aug 8, 2016
View reviewed changes

andhit-r closed this Dec 3, 2016

Pierre-Monod and others added 14 commits December 4, 2016 01:33

update for migration V7

4e712eb

add images

e26d58c

update for wilog v7.0

d3ab112

[ADD] Add contract customer invoice and migrate

3e0e869

[IMP] SMS erase print [IMP] Stock analytic XML part is now migrated

[ADD] Add logo for generic modules

c599dce

[IMP] - change the logo of all modules

46dbdb9

[IMP] - migration point, put all the modules to not installable

548b513

[ADD] - Added new module stock_analytic

72866e6

This module allows the user to generate analytic information from stock moves.

[FIX] - Fixed flake8 and pylint errors.

52f4fb1

Adapt original module according OCA Standard

00be298

Remove sale and purchase dependency. Add test

7839df8

Only assign analytic account if account != valuation acc

5ee8126

Fix unittest

8f48db3

Fix unittest

aa05f05

andhit-r force-pushed the 8.0-stock_analytic_1 branch from 6a7eba2 to aa05f05 Compare December 3, 2016 18:39

andhit-r added 3 commits December 4, 2016 18:19

improve coverage and codecov

36d4a6d

improve coverage and codecov

9f0cc1d

Fix PEP8

7e6911c

AaronHForgeFlow reviewed Dec 5, 2016

View reviewed changes

mikevhe18 and others added 4 commits December 6, 2016 11:32

Changing field name account_analytic_id

a16d182

Update README.rst

46f5c4c

Add mikevhe18 as contributor

Adjust to OCA latest guidelines. Add some usahe info on README

05f32a7

Adjust author

5cd07e5

AaronHForgeFlow approved these changes Dec 6, 2016

View reviewed changes

JordiBForgeFlow merged commit 24cf4ba into OCA:8.0 Dec 15, 2016

This was referenced Mar 31, 2017

[MIG][9.0]stock analytic #81

Closed

[MIG][9.0]stock analytic #82

Merged

sbejaoui pushed a commit to acsone/account-analytic that referenced this pull request Nov 18, 2020

Merge pull request OCA#53 from ingadhoc/fix_kanban_open_project

a5c5426

FIX in kanban_project_open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD][8.0] stock_analytic #53

[ADD][8.0] stock_analytic #53

andhit-r commented Feb 4, 2016

pedrobaeza Feb 4, 2016

pedrobaeza commented Feb 4, 2016

andhit-r commented Feb 4, 2016

pedrobaeza commented Feb 4, 2016

andhit-r commented Feb 4, 2016

pedrobaeza commented Feb 4, 2016

andhit-r commented Feb 4, 2016

pedrobaeza commented Feb 4, 2016

andhit-r commented Feb 5, 2016

andhit-r commented Feb 5, 2016

pedrobaeza commented Feb 5, 2016

andhit-r commented Feb 5, 2016

andhit-r commented Feb 16, 2016

pedrobaeza commented Feb 16, 2016

andhit-r commented Feb 16, 2016

andhit-r commented Apr 15, 2016

pedrobaeza commented Apr 19, 2016

andhit-r commented Apr 19, 2016

andhit-r commented May 11, 2016

JordiBForgeFlow commented Aug 5, 2016

andhit-r commented Aug 5, 2016

AaronHForgeFlow Aug 8, 2016

andhit-r Dec 3, 2016

andhit-r Dec 3, 2016

AaronHForgeFlow Dec 4, 2016

AaronHForgeFlow commented Nov 22, 2016

pedrobaeza commented Nov 22, 2016

andhit-r commented Dec 3, 2016

andhit-r commented Dec 4, 2016

AaronHForgeFlow left a comment

AaronHForgeFlow Dec 5, 2016

AaronHForgeFlow left a comment

mikevhe18 commented Dec 15, 2016

[ADD][8.0] stock_analytic #53

[ADD][8.0] stock_analytic #53

Conversation

andhit-r commented Feb 4, 2016

pedrobaeza Feb 4, 2016

Choose a reason for hiding this comment

pedrobaeza commented Feb 4, 2016

andhit-r commented Feb 4, 2016

pedrobaeza commented Feb 4, 2016

andhit-r commented Feb 4, 2016

pedrobaeza commented Feb 4, 2016

andhit-r commented Feb 4, 2016

pedrobaeza commented Feb 4, 2016

andhit-r commented Feb 5, 2016

andhit-r commented Feb 5, 2016

pedrobaeza commented Feb 5, 2016

andhit-r commented Feb 5, 2016

andhit-r commented Feb 16, 2016

pedrobaeza commented Feb 16, 2016

andhit-r commented Feb 16, 2016

andhit-r commented Apr 15, 2016

pedrobaeza commented Apr 19, 2016

andhit-r commented Apr 19, 2016

andhit-r commented May 11, 2016

JordiBForgeFlow commented Aug 5, 2016

andhit-r commented Aug 5, 2016

AaronHForgeFlow Aug 8, 2016

Choose a reason for hiding this comment

andhit-r Dec 3, 2016

Choose a reason for hiding this comment

andhit-r Dec 3, 2016

Choose a reason for hiding this comment

AaronHForgeFlow Dec 4, 2016

Choose a reason for hiding this comment

AaronHForgeFlow commented Nov 22, 2016

pedrobaeza commented Nov 22, 2016

andhit-r commented Dec 3, 2016

andhit-r commented Dec 4, 2016

AaronHForgeFlow left a comment

Choose a reason for hiding this comment

AaronHForgeFlow Dec 5, 2016

Choose a reason for hiding this comment

AaronHForgeFlow left a comment

Choose a reason for hiding this comment

mikevhe18 commented Dec 15, 2016