-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][ADD] account_analytic_category (replace account.analytic.group) #630
base: 16.0
Are you sure you want to change the base?
[16.0][ADD] account_analytic_category (replace account.analytic.group) #630
Conversation
36d2609
to
56df5b1
Compare
This module introduces account.analytic.category | ||
as a replacement for account.analytic.group which was removed in Odoo 16.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to rename the model?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Odoo called the model for Analytic Categories and I thought maybe this is a better name. But I am flexible on this.
"category": "Account", | ||
"website": "https://github.com/OCA/account-analytic", | ||
"depends": [ | ||
"account_financial_report", # account.move.line.analytic_account_ids |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought this dependency was a bit heavy. Maybe the part that depends on account.move.line.analytic_account_ids
can be handled in a separate glue module in the account-financial-reporting repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a new module account_move_line_analytic_account_ids
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also this PR #565 but the proposed solution in this PR doesn't store analytic_account_ids
due to a technical reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice :) I have added analytic_mixin_analytic_account
as a dependeny.
889f799
to
6c9651a
Compare
1736718
to
04ca2fb
Compare
04ca2fb
to
bec164d
Compare
Waiting to merge |
Maybe a better implementation would be to create an EDIT
|
2 new modules with 2 new fields on
account.move.line
to use in pivot:account_move_line_analytic_account_ids
: new fieldanalytic_account_ids
.account_analytic_category
: new fieldanalytic_category_ids
.