11.0 mig account_cutoff_prepaid #60

ghost · 2018-01-03T14:03:59Z

Depends on:

account_cutoff_base - 11.0 mig account_cutoff_base #61
account_invoice_start_end_dates - 11.0 mig account_invoice_start_end_dates #63

simahawk

pls squash translations commits all in one and include base PRs into oca_dependencies.txt to fix the build

simahawk · 2018-01-11T13:19:49Z

account_cutoff_prepaid/__manifest__.py

@@ -0,0 +1,27 @@
+# © 2013-2016 Akretion (Alexis de Lattre <alexis.delattre@akretion.com>)


(c) -> Copyright

simahawk · 2018-01-11T13:19:53Z

account_cutoff_prepaid/README.rst

+
+.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas
+   :alt: Try me on Runbot
+   :target: https://runbot.odoo-community.org/runbot/89/10.0


simahawk · 2018-01-11T13:20:14Z

account_cutoff_prepaid/__manifest__.py

+    'license': 'AGPL-3',
+    'summary': 'Prepaid Expense, Prepaid Revenue',
+    'author': 'Akretion,Odoo Community Association (OCA)',
+    'website': 'http://www.akretion.com',


https://github.com/OCA/account-closing

simahawk · 2018-01-11T13:21:10Z

account_cutoff_prepaid/models/account_cutoff.py

+    @api.model
+    def _get_default_source_journals(self):
+        res = []
+        cutoff_type = self._context.get('type')


self.env.context

simahawk · 2018-01-11T13:21:39Z

account_cutoff_prepaid/models/account_cutoff.py

+    source_journal_ids = fields.Many2many(
+        'account.journal', column1='cutoff_id', column2='journal_id',
+        string='Source Journals', readonly=True,
+        default=_get_default_source_journals,


proxy this w/ a lambda

simahawk · 2018-01-11T13:22:43Z

account_cutoff_prepaid/models/account_cutoff.py

+                    'The start date is after the end date!'))
+
+    @api.onchange('forecast')
+    def forecast_onchange(self):


rename to onchange_forecast

simahawk · 2018-01-11T13:23:38Z

account_cutoff_prepaid/models/account_cutoff.py

+            'amount': aml.credit - aml.debit,
+            'currency_id': self.company_currency_id.id,
+            'cutoff_amount': cutoff_amount,
+            }


parenthesis one tab back (same for all those occurrences where the closing one does not match visually the opening one)

simahawk · 2018-01-11T13:25:58Z

account_cutoff_prepaid/models/account_cutoff.py

+        return True
+
+    @api.model
+    def _inherit_default_cutoff_account_id(self):


if you proxy the method in the field (as stated in the base PR) you have to remove _inherit_ here

simahawk · 2018-01-11T13:26:07Z

account_cutoff_prepaid/models/account_cutoff.py

+    @api.model
+    def _inherit_default_cutoff_account_id(self):
+        account_id = super()._inherit_default_cutoff_account_id()
+        cutoff_type = self._context.get('type')


self.env.context

simahawk · 2018-01-11T13:27:51Z

account_cutoff_prepaid/tests/test_account_cutoff_prepaid.py

+        })
+        return cutoff
+
+    def test_0(self):


give these methods meaningful name :)

mpanarin · 2018-01-11T16:29:15Z

account_cutoff_prepaid/models/account_cutoff.py

+    @api.model
+    def _get_default_source_journals(self):
+        res = []
+        cutoff_type = self._context.get('type')


should also be noted to not forget change type here if it will be renamed in base module

leemannd

LGTM!
Code review only.

simahawk · 2018-01-24T07:57:43Z

@OleksandrPaziuk can you update this?

Use assert Remove .keys() No space before colon PEP8/Flake8 : getting closer to compliancy

….get('type', '-')

…cut-off date.

…de domains) On account.account, type must be <> 'view' and <> 'closed'

…a single warning left ! Add translation template files.

…rted

@alexis-via

Migration by @alexis-via @sbidoul added: * extensibility hooks * a multi-company record rule * some tests @gurneyalex moved the module desciption to README.rst as part of the merge

…ct.product This should make runbot green.

Extract a new module account_invoice_start_end_dates from account_cutoff_prepaid

Use triple double quotes for docstring Replace <openerp> by <odoo> in XML Remove <data> tags in XML Remove POT files

fclementic2c · 2018-01-24T14:39:57Z

I have a error when I click on any cut-off menus : see printscreen

fclementic2c · 2018-01-24T15:48:30Z

if empty -> take all journals by default

fclementic2c · 2018-01-24T16:24:10Z

👍
ready to be merged for me

fclementic2c · 2018-01-24T17:25:26Z

@simahawk It is all goo for me.
I need another approval please

simahawk · 2018-01-25T06:58:49Z

account_cutoff_prepaid/models/account_cutoff.py

+    @api.model
+    def _default_cutoff_account_id(self):
+        account_id = super()._default_cutoff_account_id()
+        cutoff_type = self.env.context.get('type')


@mpanarin hasn't this been renamed to cutoff_type in the base module? Pls, adjust any occurrence accordingly (pay attention to not mess up w/ the account type w/ a find/replace 😉 )

simahawk

@mpanarin see my comment about the ctx var. Also, as your testing it, would you mind replacing the screenshots? This one is not a blocker: you can submit another PR later... but do not forget about them ;)

mpanarin

LGTM )

simahawk · 2018-01-25T10:35:38Z

@fclementic2c all good 😉

Configure partner names to firstname first

pedrobaeza mentioned this pull request Jan 3, 2018

Migration to version 11.0 #55

Closed

8 tasks

pedrobaeza added this to the 11.0 milestone Jan 3, 2018

pedrobaeza added the work in progress label Jan 3, 2018

fclementic2c mentioned this pull request Jan 11, 2018

11.0 mig account_invoice_start_end_dates #63

Merged

simahawk requested changes Jan 11, 2018

View reviewed changes

mpanarin suggested changes Jan 11, 2018

View reviewed changes

ghost changed the title ~~11.0 mig account cutoff prepaid~~ 11.0 mig account_cutoff_prepaid Jan 11, 2018

leemannd approved these changes Jan 16, 2018

View reviewed changes

Alexis de Lattre and others added 21 commits January 24, 2018 11:28

Initial check-in of my cut-off modules

1ee6df5

Coding style enhancements (osv.Model -> orm.Model, from . import xxx)

d45b45b

Add _prepare functions to allow to inherit before create

5114f77

Use assert Remove .keys() No space before colon PEP8/Flake8 : getting closer to compliancy

Remove the unnecessary "and True or False" after 'xxx' not in context…

ce1cc92

….get('type', '-')

prepaid cutoffs : don't take into account the move lines dated after …

88cf3c8

…cut-off date.

Reduce flake8 warnings (cut lines and comments, space after coma insi…

07860f8

…de domains) On account.account, type must be <> 'view' and <> 'closed'

My christmas present to the PEP8 fundamentalists : there is not even …

8f7be6f

…a single warning left ! Add translation template files.

all modules unported to odoo 8.0

543d07c

[MIG] move account_cutoff_base and account_cutoff_prepaid out of unpo…

04ad18e

…rted

[MIG] account_cutoff: set installable=True

dd56f40

[MIG] account_cutoff_prepaid 8.0

a27003e

[IMP] account_cutoff_prepaid basic test

2dbb687

[IMP] account_cutoff_prepaid: improve test

7678227

[IMP] account_cutoff_prepaid french translation

296eedd

[8.0] migrate account_cutoff_prepaid and account_accrual_base

489d293

Migration by @alexis-via @sbidoul added: * extensibility hooks * a multi-company record rule * some tests @gurneyalex moved the module desciption to README.rst as part of the merge

[FIX] remove purchase_ok from demo data as it is not a field of produ…

1dcbf33

…ct.product This should make runbot green.

Move module icon to description

76ee0f8

[FIX] remove duplicate licence key

bca87b5

[UPD] prefix versions with 8.0

4300cb1

[MIG] Make modules uninstallable

14a4eb4

[MIG] Rename manifest files

927e2aa

alexis-via and others added 6 commits January 24, 2018 11:28

Port account_cutoff_base and account_cutoff_prepaid to Odoo v9

68ab1ef

Extract a new module account_invoice_start_end_dates from account_cutoff_prepaid

Take into account the remarks of Pedro:

2059bbe

Use triple double quotes for docstring Replace <openerp> by <odoo> in XML Remove <data> tags in XML Remove POT files

Migration of account_cutoff modules to 10.0

e5a7d91

OCA Transbot updated translations from Transifex

80257b7

[FIX] Bad attributes on m2m fields.

ddd0bbe

OCA Transbot updated translations from Transifex

0a855fd

simahawk reviewed Jan 25, 2018

View reviewed changes

simahawk requested changes Jan 25, 2018

View reviewed changes

[MIG] account_cutoff_prepaid: Migration to 11.0

04dfb01

simahawk approved these changes Jan 25, 2018

View reviewed changes

mpanarin approved these changes Jan 25, 2018

View reviewed changes

fclementic2c merged commit 75e0fb9 into OCA:11.0 Jan 25, 2018

Mraimou pushed a commit to camptocamp/account-closing that referenced this pull request Apr 20, 2021

Merge pull request OCA#60 from guewen/bsibso-977-change-name-order

9a7a643

Configure partner names to firstname first

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

11.0 mig account_cutoff_prepaid #60

11.0 mig account_cutoff_prepaid #60

ghost commented Jan 3, 2018 •

edited by fclementic2c

Loading

simahawk left a comment

simahawk Jan 11, 2018

simahawk Jan 11, 2018

simahawk Jan 11, 2018

simahawk Jan 11, 2018

simahawk Jan 11, 2018

simahawk Jan 11, 2018

simahawk Jan 11, 2018

simahawk Jan 11, 2018

simahawk Jan 11, 2018

simahawk Jan 11, 2018

mpanarin Jan 11, 2018

leemannd left a comment

simahawk commented Jan 24, 2018

fclementic2c commented Jan 24, 2018

fclementic2c commented Jan 24, 2018 •

edited

Loading

fclementic2c commented Jan 24, 2018

fclementic2c commented Jan 24, 2018

simahawk Jan 25, 2018 •

edited

Loading

simahawk left a comment •

edited

Loading

mpanarin left a comment

simahawk commented Jan 25, 2018

		@@ -0,0 +1,27 @@
		# © 2013-2016 Akretion (Alexis de Lattre <alexis.delattre@akretion.com>)

11.0 mig account_cutoff_prepaid #60

11.0 mig account_cutoff_prepaid #60

Conversation

ghost commented Jan 3, 2018 • edited by fclementic2c Loading

simahawk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leemannd left a comment

Choose a reason for hiding this comment

simahawk commented Jan 24, 2018

fclementic2c commented Jan 24, 2018

fclementic2c commented Jan 24, 2018 • edited Loading

fclementic2c commented Jan 24, 2018

fclementic2c commented Jan 24, 2018

simahawk Jan 25, 2018 • edited Loading

Choose a reason for hiding this comment

simahawk left a comment • edited Loading

Choose a reason for hiding this comment

mpanarin left a comment

Choose a reason for hiding this comment

simahawk commented Jan 25, 2018

ghost commented Jan 3, 2018 •

edited by fclementic2c

Loading

fclementic2c commented Jan 24, 2018 •

edited

Loading

simahawk Jan 25, 2018 •

edited

Loading

simahawk left a comment •

edited

Loading