11.0 mig account_invoice_start_end_dates #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract a new module account_invoice_start_end_dates from account_cutoff_prepaid
Use triple double quotes for docstring Replace <openerp> by <odoo> in XML Remove <data> tags in XML Remove POT files
ghost
mentioned this pull request
simahawk
requested changes
Jan 8, 2018
|
|
||
| .. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas | ||
| :alt: Try me on Runbot | ||
| :target: https://runbot.odoo-community.org/runbot/89/10.0 |
| @@ -0,0 +1,23 @@ | |||
| # © 2016 Akretion (Alexis de Lattre <alexis.delattre@akretion.com>) | |||
There was a problem hiding this comment.
replace '(c)' w/ 'Copyright'
| 'license': 'AGPL-3', | ||
| 'summary': 'Adds start/end dates on invoice lines and move lines', | ||
| 'author': 'Akretion,Odoo Community Association (OCA)', | ||
| 'website': 'http://www.akretion.com', |
There was a problem hiding this comment.
| code, | ||
| invoice_line.get('start_date', 'False'), | ||
| invoice_line.get('end_date', 'False'), | ||
| ) |
|
Functional test Ok |
|
...however this module is useless without : #60 |
mpanarin
suggested changes
Jan 11, 2018
| """Add start and end dates to hashcode used when the option "Group | ||
| Invoice Lines" is active on the Account Journal""" | ||
| code = super().inv_line_characteristic_hashcode( | ||
| invoice_line) |
ghost
approved these changes
Jan 17, 2018
ghost
approved these changes
Jan 17, 2018
simahawk
approved these changes
Jan 22, 2018
|
reminder: migration commits squash needed before merge |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.