9.0 account chart update migration #420

jbaudoux · 2016-11-15T14:16:03Z

Replaces PR #381

pedrobaeza · 2016-11-15T15:18:30Z

Why this new PR?

pedrobaeza · 2016-11-15T17:57:46Z

Can you please answer why you open a new PR?

jbaudoux · 2016-11-15T17:58:40Z

@pedrobaeza The PR #381 requires to be fixed. How this could have been done other than creating a new branch with the fixes and a new PR?

pedrobaeza · 2016-11-15T18:02:58Z

Well, first asking the contributor to fix it, or making a PR over his branch. Anyway, I see that you have respected his commit history, so let's continue with this one.

jbaudoux · 2016-11-15T18:05:58Z

I'm still making some more tests because tax name was not shown in wizard and tax accounts where not loaded.

pedrobaeza · 2016-11-15T18:06:46Z

Perfect, let me know when I can review it

jbaudoux · 2016-11-15T18:50:43Z

Any good reason why find_tax_by_templates tries to match an existing tax based on its description? The description is what is displayed on the invoice.
For instance, I have multiple fixed amount taxes (and so with different names to be able to select it properly) that are all having the same description. The description is the same because it's all the same tax and there is no reason to display it differently on the invoice whatever the amount is.

pedrobaeza · 2016-11-15T18:54:37Z

There are some localizations that only fill that field. Maybe for v9 the situation has been normalized. What is the field name which you want to remove? description or name?

jbaudoux · 2016-11-15T20:11:28Z

@pedrobaeza No improvement on this in 9.0, so I leave it like that. I'll manage to have different description on those taxes.

I'm done fixing the issues I found. This PR is now ready for review

jbaudoux · 2016-11-22T10:39:31Z

@sbidoul Could you also review this module that allows to install the l10n_belgium PR you reviewed after having the chart of accounts/taxes loaded. Thanks

jbaudoux · 2017-03-14T10:27:08Z

Could this PR be merged?
We are starting porting this PR to version 10

yajo

Code review looks good, still lacking tests sadly.

Did not check runbot since it is unavailable ATM.

yajo · 2017-03-31T07:36:49Z

account_chart_update/__openerp__.py

              "Odoo Community Association (OCA)",
    'website': "http://odoo-community.org",
    'depends': ["account"],
-    'category': "Generic Modules/Accounting",
+    'category': "Accounting & Finance",
    'contributors': [


Does this key really do anything? 🤔

Well, it's loaded, but not shown in any part. We can keep it anyway.

yajo · 2017-03-31T07:46:07Z

account_chart_update/wizard/wizard_chart_update.py

+    @tools.ormcache("code")
+    def padded_code(self, code):
+        """Return a right-zero-padded code with the chosen digits."""
+        return "{:0<{}}".format(code, self.code_digits)


Only unicode strings are allowed to be used with .format (per OCA standard).

Uhm, format can be used with both kind of strings, so no real problem I think.

>>> "Vivo en {}".format(u"España") Traceback (most recent call last): File "<stdin>", line 1, in <module> UnicodeEncodeError: 'ascii' codec can't encode character u'\xf1' in position 4: ordinal not in range(128) >>> u"Vivo en {}".format(u"España") u'Vivo en Espa\xf1a'

But it's not the case here. Anyway, the same happens with "Vivo en %s" % "España" if you don't put the u.

You can see discussion on OCA/pylint-odoo#65, I'd still recommend it as a good rule of thumb.

OK, let's change it...

pedrobaeza · 2017-03-31T10:06:10Z

On a tentative update, there's this error:

A tax fiscal position could be defined only once time on same taxes.

so something fails.

pedrobaeza · 2017-04-02T21:25:20Z

@jbaudoux I have reordered a bit commits. The changes you have made to the fiscal position part are not working, with the message I put the other day. Can you please check?

cubells · 2017-04-03T07:51:42Z

account_chart_update/views/account_config_settings_view.xml

+<?xml version="1.0" encoding="utf-8"?>
+<!-- © 2016 Jairo Llopis <jairo.llopis@tecnativa.com>
+     License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). -->
+<openerp>


s/openerp/odoo/g

cubells

Code review only.

cubells · 2017-04-03T07:52:26Z

account_chart_update/wizard/wizard_chart_update_view.xml

@@ -1,156 +1,133 @@
 <?xml version="1.0" encoding="utf-8"?>
+<!-- © 2016 Jairo Llopis <jairo.llopis@tecnativa.com>
+     License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). -->
 <openerp>


s/openerp/odoo/g

jbaudoux · 2017-04-04T12:04:20Z

@pedrobaeza I cannot reproduce your error.

carlosdauden · 2017-07-31T14:49:56Z

account_chart_update/wizard/wizard_chart_update.py

+            mapping = self.env["account.fiscal.position.tax"].search([
+                ("position_id", "=", pos_id),
+                ("tax_src_id", "=", src_id),
+                ], limit=1)


Don't works fine if fiscal position map 1 tax with more than 1 tax.

As there's a constraint that forbids to write the code of the account if it has moves, we delete the corresponding entry on update only, because the method that prepares the values is the same for new and existing accounts.

* Process price_include field * Detect change in price_include field

- New-style license headers. - Remove .pot file. - Remove tax codes stuff, now removed from v9. - Refactor methods for search, create, update, delete. Now they are smaller, fitter, happier, more productive. - Only update fields that have any kind of change on any updated record. - Place the wizard in the configuration page, instead of its own menu item. - Display amount of disabled taxes at ending page.

pedrobaeza

I have fixed the fiscal position part, so this one is finally ready to merge.

jbaudoux force-pushed the 9.0-account_chart_update-migration branch from 491c3a9 to 2ebb295 Compare November 15, 2016 14:23

jbaudoux changed the title ~~9.0 account chart update migration~~ WIP 9.0 account chart update migration Nov 15, 2016

This was referenced Nov 15, 2016

[MIG][9.0][account_chart_update] Migrate. #381

Closed

Migration to version 9.0 #311

Closed

jbaudoux changed the title ~~WIP 9.0 account chart update migration~~ 9.0 account chart update migration Nov 15, 2016

jbaudoux force-pushed the 9.0-account_chart_update-migration branch from c1bc4f0 to f80bb74 Compare November 15, 2016 20:10

jbaudoux mentioned this pull request Mar 16, 2017

[10.0][MIG] account_chart_update #460

Merged

yajo approved these changes Mar 31, 2017

View reviewed changes

pedrobaeza force-pushed the 9.0-account_chart_update-migration branch from 06366a6 to 0ac8ce9 Compare April 2, 2017 21:23

cubells reviewed Apr 3, 2017

View reviewed changes

cubells suggested changes Apr 3, 2017

View reviewed changes

carlosdauden suggested changes Jul 31, 2017

View reviewed changes

pedrobaeza and others added 4 commits August 14, 2017 13:29

[FIX] account_chart_update: Don't write code on account update

6f0c65b

As there's a constraint that forbids to write the code of the account if it has moves, we delete the corresponding entry on update only, because the method that prepares the values is the same for new and existing accounts.

[FIX] Include acc templates from parent CoA templates

fef9f9a

[FIX] account_chart_update:

5e1c08c

* Process price_include field * Detect change in price_include field

OCA Transbot updated translations from Transifex

21db655

pedrobaeza force-pushed the 9.0-account_chart_update-migration branch from eb58f67 to a735d30 Compare August 14, 2017 18:08

pedrobaeza added 2 commits August 14, 2017 20:21

[FIX] account_chart_update: Fix fiscal position mapping

d034f8f

[IMP] account_chart_update: Improve translations + Spanish

5d2ef73

pedrobaeza force-pushed the 9.0-account_chart_update-migration branch from a735d30 to 5d2ef73 Compare August 14, 2017 18:21

pedrobaeza approved these changes Aug 15, 2017

View reviewed changes

pedrobaeza merged commit 521da9c into OCA:9.0 Aug 15, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

9.0 account chart update migration #420

9.0 account chart update migration #420

jbaudoux commented Nov 15, 2016

pedrobaeza commented Nov 15, 2016

pedrobaeza commented Nov 15, 2016

jbaudoux commented Nov 15, 2016

pedrobaeza commented Nov 15, 2016

jbaudoux commented Nov 15, 2016

pedrobaeza commented Nov 15, 2016

jbaudoux commented Nov 15, 2016

pedrobaeza commented Nov 15, 2016

jbaudoux commented Nov 15, 2016

jbaudoux commented Nov 22, 2016

jbaudoux commented Mar 14, 2017

yajo left a comment

yajo Mar 31, 2017

pedrobaeza Apr 2, 2017

yajo Mar 31, 2017

pedrobaeza Apr 2, 2017

yajo Apr 3, 2017

pedrobaeza Apr 3, 2017

yajo Apr 3, 2017

pedrobaeza Apr 3, 2017

pedrobaeza commented Mar 31, 2017

pedrobaeza commented Apr 2, 2017

cubells Apr 3, 2017

cubells left a comment

cubells Apr 3, 2017

jbaudoux commented Apr 4, 2017

carlosdauden Jul 31, 2017

pedrobaeza left a comment

9.0 account chart update migration #420

9.0 account chart update migration #420

Conversation

jbaudoux commented Nov 15, 2016

pedrobaeza commented Nov 15, 2016

pedrobaeza commented Nov 15, 2016

jbaudoux commented Nov 15, 2016

pedrobaeza commented Nov 15, 2016

jbaudoux commented Nov 15, 2016

pedrobaeza commented Nov 15, 2016

jbaudoux commented Nov 15, 2016

pedrobaeza commented Nov 15, 2016

jbaudoux commented Nov 15, 2016

jbaudoux commented Nov 22, 2016

jbaudoux commented Mar 14, 2017

yajo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza commented Mar 31, 2017

pedrobaeza commented Apr 2, 2017

Choose a reason for hiding this comment

cubells left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jbaudoux commented Apr 4, 2017

Choose a reason for hiding this comment

pedrobaeza left a comment

Choose a reason for hiding this comment