Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.0][account_move_batch_validate]. Add try..except during import of queue_job #846

Merged
merged 1 commit into from
Jul 3, 2019
Merged

[11.0][account_move_batch_validate]. Add try..except during import of queue_job #846

merged 1 commit into from
Jul 3, 2019

Conversation

JordiBForgeFlow
Copy link
Sponsor Member

Otherwise anyone using this repo will need to install the queue_job, if they add the repo in their addons-path.

cc @grindtildeath @benwillig

JordiBForgeFlow added a commit to ForgeFlow/ao-odoo-buildout that referenced this pull request Jun 21, 2019
@JordiBForgeFlow
add PR OCA/account-financial-tools#846
04a151b
@JordiBForgeFlow JordiBForgeFlow force-pushed the 11.0-account_move_batch_validate-queue-dependency branch 2 times, most recently from a66e30f to bb3694d Compare June 21, 2019 13:47
grindtildeath
grindtildeath reviewed Jun 26, 2019
View reviewed changes
Copy link
Contributor

@grindtildeath grindtildeath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit, but travis is raising an error:
account_move_batch_validate/wizard/account_move_validate.py:13:5: F401 'odoo.addons.queue_job.job.Job' imported but unused

account_move_batch_validate/wizard/account_move_validate.py Outdated


try:
from odoo.addons.queue_job.job import job, Job
Copy link
Contributor

@grindtildeath grindtildeath Jun 26, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove Job to make travis happy.

Suggested change
from odoo.addons.queue_job.job import job, Job
from odoo.addons.queue_job.job import job

@JordiBForgeFlow JordiBForgeFlow force-pushed the 11.0-account_move_batch_validate-queue-dependency branch from bb3694d to 45a3275 Compare July 3, 2019 09:25
LoisRForgeFlow
LoisRForgeFlow approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LoisRForgeFlow
Copy link
Contributor

LoisRForgeFlow commented Jul 3, 2019 •
edited
Loading

@grindtildeath good to go?

grindtildeath
grindtildeath approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@grindtildeath grindtildeath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lreficent definitely

@JordiBForgeFlow JordiBForgeFlow merged commit 77b7f7d into OCA:11.0 Jul 3, 2019
@LoisRForgeFlow LoisRForgeFlow deleted the 11.0-account_move_batch_validate-queue-dependency branch July 3, 2019 12:58
HviorForgeFlow pushed a commit to ForgeFlow/ao-odoo-buildout that referenced this pull request Aug 27, 2019
@JordiBForgeFlow @HviorForgeFlow
add PR OCA/account-financial-tools#846
dae11cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grindtildeath grindtildeath grindtildeath approved these changes

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JordiBForgeFlow @LoisRForgeFlow @grindtildeath @OCA-git-bot