Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10][MIGR] account invoice pricelist sale #343

Merged
merged 4 commits into from
May 2, 2018
Merged

[10][MIGR] account invoice pricelist sale #343

merged 4 commits into from
May 2, 2018

Conversation

rvalyi
Copy link
Member

@rvalyi rvalyi commented Dec 18, 2017 •
edited by pedrobaeza

Depends on

@rvalyi rvalyi requested a review from NL66278 December 18, 2017 15:28
@rvalyi rvalyi changed the title 10.0 migr account invoice pricelist sale [10][MIGR] account invoice pricelist sale Dec 18, 2017
@rvalyi
Copy link
Member Author

rvalyi commented Mar 30, 2018

#342 has been replaced by #368 so it depends on #368 now

@rvalyi
Copy link
Member Author

rvalyi commented Apr 18, 2018

ping @bealdav @pedrobaeza
the #368 dependency has been merged. How is it for merging this one now?

@pedrobaeza
Copy link
Member

Can you please rebase first?

bealdav
bealdav reviewed Apr 18, 2018
View reviewed changes
account_invoice_pricelist_sale/models/sale_order.py Outdated
# -*- coding: utf-8 -*-
# © 2017 Therp BV <http://therp.nl>
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
from openerp import models, api
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace buy odoo

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@rvalyi rvalyi force-pushed the 10.0-migr-account_invoice_pricelist_sale branch 2 times, most recently from 65c36a8 to 998e0bd Compare April 18, 2018 15:22
@rvalyi
Copy link
Member Author

rvalyi commented Apr 18, 2018

@pedrobaeza rebase done, Travis green.

@rvalyi
Copy link
Member Author

rvalyi commented Apr 25, 2018

ping @pedrobaeza, not sure you have seen the rebase.

pedrobaeza
pedrobaeza approved these changes Apr 26, 2018
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although you can still squash 2 "OCA Transbot" commits

@oca-transbot @rvalyi
OCA Transbot updated translations from Transifex
fc2d05b 
OCA Transbot updated translations from Transifex
@rvalyi rvalyi force-pushed the 10.0-migr-account_invoice_pricelist_sale branch from 998e0bd to cab2eac Compare April 27, 2018 14:53
@rvalyi
Copy link
Member Author

rvalyi commented Apr 27, 2018

@pedrobaeza squash done cc @bealdav

legalsylvain
legalsylvain approved these changes Apr 27, 2018
View reviewed changes
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rvalyi. The commit text is confusing. (V11 written). Otherwise, 👍
thanks !

@rvalyi rvalyi force-pushed the 10.0-migr-account_invoice_pricelist_sale branch from cab2eac to a45b9ab Compare May 2, 2018 15:27
@rvalyi
Copy link
Member Author

rvalyi commented May 2, 2018

@legalsylvain commit messages fixed. cc @pedrobaeza

@pedrobaeza pedrobaeza merged commit aa0a0fc into OCA:10.0 May 2, 2018
@pedrobaeza pedrobaeza added this to the 10.0 milestone May 2, 2018
@pedrobaeza pedrobaeza mentioned this pull request May 2, 2018
Closed
34 tasks
@bealdav bealdav deleted the 10.0-migr-account_invoice_pricelist_sale branch June 26, 2019 09:45
eLBati pushed a commit to eLBati/account-invoicing that referenced this pull request Oct 21, 2022
@eLBati
[FIX] Add partner on search view (OCA#343)
09df248
OCA-git-bot pushed a commit to eLBati/account-invoicing that referenced this pull request Feb 2, 2023
@OCA-git-bot
[FIX] Add partner on search view (OCA#343)
a8311c2
Ricardoalso pushed a commit to camptocamp/account-invoicing that referenced this pull request Sep 19, 2023
@Ricardoalso
[FIX] Add partner on search view (OCA#343)
ac8404e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bealdav bealdav bealdav approved these changes

@legalsylvain legalsylvain legalsylvain approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@NL66278 NL66278 Awaiting requested review from NL66278

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rvalyi @pedrobaeza @bealdav @legalsylvain @NL66278 @oca-transbot