[MIG] account_payment_term_extension: Migration to 11.0 #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
requested changes
Apr 16, 2018
| @@ -58,30 +55,30 @@ msgstr "Nombre mostrado" | |||
| #. module: account_payment_term_extension | |||
| #: model:ir.ui.view,arch_db:account_payment_term_extension.view_payment_term_line_form | |||
| msgid "Due Date Computation" | |||
| msgstr "" | |||
| msgstr "álculo de fecha de vencimiento" | |||
| @@ -1,29 +1,25 @@ | |||
| # Translation of Odoo Server. | |||
| # Copyright 2013-2016 Camptocamp SA (Yannick Vaucher) | ||
| # Copyright 2004-2016 Odoo S.A. (www.odoo.com) | ||
| # Copyright 2015-2016 Akretion | ||
| # (Alexis de Lattre <alexis.delattre@akretion.com>) | ||
| # Copyright 2018 Simone Rubino - Agile Business Group | ||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
|
|
||
|
|
||
| from functools import reduce |
There was a problem hiding this comment.
reduce function is used here:
https://github.com/OCA/account-invoicing/pull/375/files#diff-d0188f250f37daab85f1680d28b455ccR198
and in python3 does not exist. We have two solutions, import from functools or replace reduce function by a for loop.
I choose import option.
There was a problem hiding this comment.
OK, thanks for the explanations
cubells
force-pushed
the
11.0-mig-account_payment_term_extension
branch
2 times, most recently
from
3f06ab4
to
749b770
Compare
pedrobaeza
approved these changes
May 19, 2018
angelmoya
approved these changes
May 31, 2018
…_term_extension Add support for months and weeks in account.payment.term.line Add unittest PEP8 validation
Fix and add a feature for apply a chronological order on lines Merge of the 'account_payment_term_multi_day' module Add icon to module
pedrobaeza
force-pushed
the
11.0-mig-account_payment_term_extension
branch
from
749b770
to
96e8f18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa