-
-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.0][MIG] account_payment_term_extension #328
[11.0][MIG] account_payment_term_extension #328
Conversation
…_term_extension Add support for months and weeks in account.payment.term.line
Please squash together all "OCA Transbot..." commits. |
f3ec53b
to
afb4e1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove the utf-8 lines from the top in Python3. Just safe the file in utf8 format.
@@ -0,0 +1,3 @@ | |||
# -*- coding: utf-8 -*- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove the utf-8 lines from the top in Python3. Just safe the file in utf8 format.
@@ -0,0 +1,161 @@ | |||
# -*- coding: utf-8 -*- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove the utf-8 lines from the top in Python3. Just safe the file in utf8 format.
@@ -0,0 +1,230 @@ | |||
# -*- coding: utf-8 -*- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in these scenarios:
- a payment term with a single payment date. ok
- a payment term with 2 payment dates. ok
- changing from 1 payment term to another recalculates the Due Date. ok
- changin invoice partner changes and recalculates Due Date. ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some remarks but LGTM
|
||
.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas | ||
:alt: Try me on Runbot | ||
:target: https://runbot.odoo-community.org/runbot/95/10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
11.0
#: model:account.payment.term,name:account_payment_term_extension.sixty_days_end_of_month | ||
#: model:account.payment.term,note:account_payment_term_extension.sixty_days_end_of_month | ||
msgid "60 Days End of Month" | ||
msgstr "60 dias al final del mes" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Días
#. module: account_payment_term_extension | ||
#: model:ir.model.fields,field_description:account_payment_term_extension.field_account_payment_term_line_months | ||
msgid "Number of Months" | ||
msgstr "Numero de meses" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Número
#: model:account.payment.term,name:account_payment_term_extension.sixty_days_end_of_month | ||
#: model:account.payment.term,note:account_payment_term_extension.sixty_days_end_of_month | ||
msgid "60 Days End of Month" | ||
msgstr "60 dias al final del mes" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Días
#. module: account_payment_term_extension | ||
#: model:ir.model.fields,field_description:account_payment_term_extension.field_account_payment_term_line_months | ||
msgid "Number of Months" | ||
msgstr "Numero de meses" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Número
payment_days = line._decode_payment_days(line.payment_days) | ||
if payment_days: | ||
new_date = None | ||
payment_days.sort() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
decode_payment_days call days.sort() before return, so you can delete this line
@NachoSerra are you going to finish this? |
Superseeded by #375 |
No description provided.