11.0 mig account invoice fiscal position update #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
pedrobaeza
requested changes
May 5, 2018
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
|
|
||
|
|
||
| { | ||
| 'name': 'Invoice Fiscal Position Update', | ||
| 'version': '10.0.1.0.1', | ||
| 'version': '11.0.1.0.1', |
| @@ -38,10 +41,13 @@ Credits | |||
| Contributors | |||
| ------------ | |||
|
|
|||
| * Roel Adriaans <roel@road-support.nl> | |||
There was a problem hiding this comment.
Please put you in last position, as this history is supposed to be from beginning to recent contributions
|
@pedrobaeza Changes Done. |
pedrobaeza
approved these changes
May 14, 2018
etobella
requested changes
Jun 5, 2018
| product = line.product_id | ||
| if inv_type in ('out_invoice', 'out_refund'): | ||
| account = ( | ||
| product.property_account_income_id or |
There was a problem hiding this comment.
You should ensure the company of the property for multicompany environments
with_context(force_company=self.company_id.id)
| lambda tax: tax.company_id == self.company_id) | ||
| else: | ||
| account = ( | ||
| product.property_account_expense_id or |
|
@RoelAdriaans-old are you planning to consider the latest changes? Or should we better make a pull request that supersedes this one? |
|
@jbeficent Sorry forgot about it.. |
|
I noticed test_inv_fiscal_pos_update is failing in my CI. I think, it is because I run test after install l10n location. |
|
Tests should search for an existing account first instead of creating it, or use it a weird code that is not going to choke (example: |
HviorForgeFlow
suggested changes
Aug 24, 2018
|
|
||
| def test_fiscal_position_id_change(self): | ||
| partner = self.res_partner_model.create(dict(name="George")) | ||
| account_export_id = self.account_model.sudo().create({ |
There was a problem hiding this comment.
account_export_id = self.account_model.sudo().search(
[('code', '=', '710000')], limit=1
)
if not account_export_id:
account_export_id = self.account_model.sudo().create({
'code': "710000",
'name': "customer export account",
'user_type_id': self.account_user_type.id,
'reconcile': True,
})
There was a problem hiding this comment.
👍 I'll try to make the changes this weekend
CasVissers-360ERP
approved these changes
Sep 10, 2018
|
@RoelAdriaans can you please finish this? |
…on, tax mapping could be wrong set
|
I have fixed the test creating an unique account code, so I merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate to 11.0
CLA Bot will probably give a warning, because my github acocunt is not known, mailed cla@ about this.
@RoelAdriaans-B-informed is me with signed cla, but company account.