-
-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.0] [MIG] account invoice view payment #399
[11.0] [MIG] account invoice view payment #399
Conversation
No problem, updated. Please squash together adjacent "OCA Transbot.." commits using https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review. Changes required.
<field name="inherit_id" | ||
ref="account.view_account_payment_form"/> | ||
<field name="arch" type="xml"> | ||
<button name="post" position="after"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ths button name has changed. It is now 'action_validate_invoice_payment'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
<button name="post" position="after"> | ||
<button name="post_and_open_payment" class="oe_highlight" | ||
string="Validate & View Payment" type="object" | ||
groups="account.group_account_user"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change groups to "account.group_account_invoice" since in v11 this group can access to payments from invoice anyway. Please apply everywhere else in this module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
Configuration | ||
============= | ||
|
||
Only users assigned to the 'Accounting & Finance' groups 'Accountant' or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has changed in V11 CE. Please change to Users assigned to the group "Billing" can display the payments from the invoice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
Many Thanks @jbeficent for the review.
Please rebase and try to resolve the conficts. |
@pedrobaeza When you have resolved this problem, run "git rebase --continue". |
Are you altering the order of the commits? You should respect and put together only adjacent commits for avoiding this problem. |
it is correct? pick eed35a3 account_invoice_view_payment |
I miss the fixup (f shortened) for 1405739 also |
As there is clearly a problem with rebases and reorderings, superseeded by #403. This PR can be closed. |
@pedrobaeza please could you remove this pull request #398 because I have issue with git format-patch so I create new one from scratch and now it is fine. thanks