Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.0][MIG] account_invoice_view_payment #403

Merged
merged 7 commits into from
Jul 9, 2018
Merged

[11.0][MIG] account_invoice_view_payment #403

merged 7 commits into from
Jul 9, 2018

Conversation

MiquelRForgeFlow
Copy link
Contributor

Superseeds #399.

@MiquelRForgeFlow MiquelRForgeFlow mentioned this pull request Jul 9, 2018
Closed
@pedrobaeza pedrobaeza added this to the 11.0 milestone Jul 9, 2018
@pedrobaeza pedrobaeza mentioned this pull request Jul 9, 2018
Closed
36 tasks
@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 11.0-mig-account_invoice_view_payment branch 2 times, most recently from 272a8ef to 199c21c Compare July 9, 2018 12:19
@MiquelRForgeFlow
Copy link
Contributor Author

MiquelRForgeFlow commented Jul 9, 2018 •
edited
Loading

🍏

@AMhadhbi @jbeficent @pedrobaeza reviews are welcome

@AMhadhbi
Copy link
Member

AMhadhbi commented Jul 9, 2018

@mreficent Great Job 👍 Thanks.
but just I have one question about the tools travis-ci : did you fix the issue related to Travis-CI? because I found issue during test the module. Also now, does not exist in the list, just Runbot and codecov Patch/project. It should be 4 successful checks.

@MiquelRForgeFlow
Copy link
Contributor Author

Yeah, Travis-CI disappeared for some odd reason, maybe by pushing too consecutively. I will try to reactivate it.

@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 11.0-mig-account_invoice_view_payment branch from 199c21c to aff8f2b Compare July 9, 2018 13:51
@AMhadhbi
Copy link
Member

AMhadhbi commented Jul 9, 2018

Yeah. Perfect 👍
Everything now its fine.
It should be merged :)

@pedrobaeza pedrobaeza merged commit b9f360f into OCA:11.0 Jul 9, 2018
@MiquelRForgeFlow MiquelRForgeFlow deleted the 11.0-mig-account_invoice_view_payment branch July 9, 2018 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.
6 participants
@MiquelRForgeFlow @AMhadhbi @pedrobaeza @JordiBForgeFlow @oca-transbot @oca-travis