[8.0] Add account invoice split modules #97
Conversation
adrienpeiffer
force-pushed
the
8.0-add-account-invoice-split-ape
branch
2 times, most recently
from
d4c9aca
to
70d4ee9
Compare
| - TESTS="1" ODOO_REPO="odoo/odoo" INCLUDE="account_invoice_validation_workflow" | ||
| - TESTS="1" ODOO_REPO="OCA/OCB" INCLUDE="account_invoice_validation_workflow" | ||
| - TESTS="1" ODOO_REPO="odoo/odoo" INCLUDE="account_invoice_split_sale,account_invoice_split" |
There was a problem hiding this comment.
Why this can't be tested together with the rest?
adrienpeiffer
force-pushed
the
8.0-add-account-invoice-split-ape
branch
3 times, most recently
from
2505c2b
to
785cfda
Compare
|
I did a functional test for a purchase and sale workflow on runbot. It works well. In the split wizard, the notebook is not necessary: a label would be nicer. Otherwise can you look ater @pedrobaeza 's comments and check why travis is red? |
| if vals['invoice_line']: | ||
| new_invoice = self.env['account.invoice'].create(vals) | ||
| if not new_invoice: | ||
| raise exceptions.Warning(_('Nothing to split')) |
There was a problem hiding this comment.
Can you write: "There is nothing to split. Please fill the 'quantities to split' column." This would be more explicit for the user.
adrienpeiffer
force-pushed
the
8.0-add-account-invoice-split-ape
branch
from
781a360
to
c0403bc
Compare
| FIELD_MAPPING = [('id', 'origin_invoice_line_id'), | ||
| ('product_id', 'product_id'), | ||
| ('name', 'name'), | ||
| ('quantity', 'total_quantity')] |
There was a problem hiding this comment.
It's better to have globals immutables. Make FIELD_MAPPING a tuple instead of a list.
There was a problem hiding this comment.
If you make it inmutable, then you can't extend it, which is the purpose I think
There was a problem hiding this comment.
#98 (comment) wisely taught us that its not a good way to extend. So making it immutable will force us to resist the temptation.
|
Travis is red because of odoo/odoo#8593 |
adrienpeiffer
force-pushed
the
8.0-add-account-invoice-split-ape
branch
2 times, most recently
from
41c048a
to
e6f0cf4
Compare
…alues to create a new record
…ng the previous commit change with copy method
adrienpeiffer
force-pushed
the
8.0-add-account-invoice-split-ape
branch
from
df70d0d
to
4d9fa0b
Compare
|
Hi @adrienpeiffer what's the state of this? |
|
@adrienpeiffer Can you have a look? |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
This PR adds invoice split functionality.
First, account_invoice_split module which is the main module that allow to split invoice.
After that, there are several auto_install modules that provide a compatibility with other Odoo/OCA modules :
I propose all modules directly because they are all necessary for efficiency with an installation of all modules