New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] support analytic plans #98
[ADD] support analytic plans #98
Conversation
You can already inherit the list and add elements. account_invoice_merge module already do it in https://github.com/OCA/account-invoicing/blob/8.0/account_invoice_merge_payment/models/account_invoice.py#L30, and you break it with you change. |
@pedrobaeza doing it this way is a very bad idea. As soon as account_invoice_merge_payment has a static folder, this key is added when the addon is in the addons path without it being installed. At least, this should be protected by means of |
@pedrobaeza I you agree, I'll include fixing this module in the PR |
OK, then please change the extension mechanism to the function then. |
@pedrobaeza done |
👍 Thanks. |
👍 |
@adrienpeiffer can you have a look at this one? |
LGTM (Code review and functionnal test). I'll update #92 according changes in this one. 👍 |
👍 |
…_plans [ADD] support analytic plans in account_invoice_merge
The small refactoring should make it simpler to add more things like that or to change the matching logic completely in an inheriting module