Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.0][MIG] account_payment_show_invoice #150

Merged
merged 2 commits into from
Oct 10, 2017
Merged

[10.0][MIG] account_payment_show_invoice #150

merged 2 commits into from
Oct 10, 2017

Conversation

MiquelRForgeFlow
Copy link
Contributor

Standard migration.

LoisRForgeFlow
LoisRForgeFlow approved these changes Jun 19, 2017
View reviewed changes
Copy link

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

rami-wafaie
rami-wafaie approved these changes Oct 2, 2017
View reviewed changes
Copy link

@rami-wafaie rami-wafaie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review + functional testing
👍

@rami-wafaie
Copy link

@pedrobaeza Can you please have a look at this?

@adrienpeiffer adrienpeiffer added this to the 10.0 milestone Oct 2, 2017
adrienpeiffer
adrienpeiffer requested changes Oct 2, 2017
View reviewed changes
account_payment_show_invoice/models/account_payment.py Outdated
from odoo import api, fields, models


class ModelName(models.Model):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/ModelName/AccountPayment

@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 10.0-mig-account_payment_show_invoice branch from 1d75ed7 to 29d390a Compare October 2, 2017 14:23
@pedrobaeza
Copy link
Member

@adrienpeiffer can you update your review?

adrienpeiffer
adrienpeiffer approved these changes Oct 10, 2017
View reviewed changes
Copy link
Contributor

@adrienpeiffer adrienpeiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pedrobaeza pedrobaeza merged commit 41b5908 into OCA:10.0 Oct 10, 2017
@LoisRForgeFlow LoisRForgeFlow deleted the 10.0-mig-account_payment_show_invoice branch October 13, 2017 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrienpeiffer adrienpeiffer adrienpeiffer approved these changes

@rami-wafaie rami-wafaie rami-wafaie approved these changes

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.
5 participants
@MiquelRForgeFlow @rami-wafaie @pedrobaeza @adrienpeiffer @LoisRForgeFlow