Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0] [MIG] account_due_list_aging_comment #225

Closed
wants to merge 1 commit into from
Closed

[12.0] [MIG] account_due_list_aging_comment #225

wants to merge 1 commit into from

Conversation

cor9003
Copy link
Contributor

@cor9003 cor9003 commented Feb 20, 2019

Migration to 12 account_due_list_aging_comment

@oca-clabot
Copy link

Hey @cor9003, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@cor9003
Copy link
Contributor Author

cor9003 commented Feb 20, 2019

Hello, The CLA has been already signed and sent by email

'category': 'Generic Modules/Payment',
'author': 'Eficent,'
'Odoo Community Association (OCA)',
'website': 'http://www.eficent.com',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cor9003 URL https://github.com/OCA/account-payment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done !

Copy link
Member

@tbaden tbaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use the maintainer-tools to create readme.

@cor9003
Copy link
Contributor Author

cor9003 commented Apr 28, 2019

@tbaden readme created with maintainer-tools. Thanks to inform me

@tbaden
Copy link
Member

tbaden commented Apr 28, 2019

Thanks for the work 👍
Just the request from @Nikul-Chaudhary is still open

@cor9003
Copy link
Contributor Author

cor9003 commented Apr 28, 2019

@tbaden The request from @Nikul-Chaudhary is already done

Copy link
Member

@tbaden tbaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, please Squash your commits into 1

@cor9003
Copy link
Contributor Author

cor9003 commented May 1, 2019

squash commits into 1 done. @tbaden Is there any action I should do to move forward this PR?

@tbaden
Copy link
Member

tbaden commented May 1, 2019

@Nikul-Chaudhary anymore changes or good to go?

@cor9003
Copy link
Contributor Author

cor9003 commented May 25, 2019

@Nikul-Chaudhary @tbaden Hello, do I have to do anything to move forward this PR ?

@emagdalenaC2i emagdalenaC2i mentioned this pull request Jun 1, 2019
16 tasks
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, maintain commit history as explained here https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-12.0.

To save your work, you can copy the folder and paste outside the repo. Then reset the branch to v12.0, apply what in the link says in order to put add all commit history. And then copy the previous copied folder and paste in the repo overwriting it, and commit and push force.

@cor9003
Copy link
Contributor Author

cor9003 commented Jun 7, 2019

@mreficent I do not have the branch 12.0 in my forked repository and I don´t know how add this branch 12.0 in my forked repository. I would prefer delete this pull request and start from scratch and give you a clear new pull request. Is it ok for you ?

@MiquelRForgeFlow
Copy link
Contributor

MiquelRForgeFlow commented Jun 7, 2019

ok. do as you prefer. to create branches, you can always do:

git fetch origin 12.0
git checkout -b new_branch origin/12.0

to reset branches, yo only new to do "git reset --hard origin/12"

to add remotes, is with "git remote add remote_name https://github.com/remote_name/{repo}.git"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants