Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0][add][account_check_printing_report_sslm102] #246

Merged

Conversation

JordiBForgeFlow
Copy link
Sponsor Member

This module allows you to print SSLM102 lined checks.

See https://www.google.es/search?q=sslm102

image

@JordiBForgeFlow JordiBForgeFlow force-pushed the 10.0-account_check_printing_report_sslm102 branch from fe5be0f to 1f88903 Compare April 3, 2019 21:19
@JordiBForgeFlow JordiBForgeFlow added this to the 10.0 milestone Apr 3, 2019
@JordiBForgeFlow JordiBForgeFlow force-pushed the 10.0-account_check_printing_report_sslm102 branch from 1f88903 to 33c0897 Compare April 3, 2019 21:33
@AaronHForgeFlow
Copy link
Contributor

refactor based on #261

@AaronHForgeFlow AaronHForgeFlow force-pushed the 10.0-account_check_printing_report_sslm102 branch 2 times, most recently from a55940e to 440347b Compare June 5, 2019 13:22
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in production environment 😄

@AaronHForgeFlow AaronHForgeFlow force-pushed the 10.0-account_check_printing_report_sslm102 branch 3 times, most recently from 52e839a to c86afa8 Compare October 11, 2019 16:15
@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 10.0-account_check_printing_report_sslm102 branch from cab1391 to e819ddc Compare October 11, 2019 19:55
@AaronHForgeFlow
Copy link
Contributor

@mreficent still red, can you check?

@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 10.0-account_check_printing_report_sslm102 branch from e819ddc to bd066c7 Compare October 14, 2019 12:22
@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 10.0-account_check_printing_report_sslm102 branch from bd066c7 to 84aab0a Compare October 14, 2019 12:25
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Works good

Copy link
Member

@HviorForgeFlow HviorForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review
LGTM

@AaronHForgeFlow
Copy link
Contributor

Ready to merge

1 similar comment
@AaronHForgeFlow
Copy link
Contributor

Ready to merge

@JordiBForgeFlow
Copy link
Sponsor Member Author

/ocabot merge

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 10.0-ocabot-merge-pr-246-by-jbeficent-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 29, 2019
Signed-off-by jbeficent
@OCA-git-bot OCA-git-bot merged commit 84aab0a into OCA:10.0 Oct 29, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9d10539. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 10.0-account_check_printing_report_sslm102 branch October 29, 2019 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants