[10.0] account_check_printing_report_base - refactor #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max3903
approved these changes
May 31, 2019
AaronHForgeFlow
requested changes
Jun 3, 2019
|
It seems to me that this fix is the same as #259 🤔 |
JordiBForgeFlow
changed the title
|
cc @max3903 can you please consider the new changes? This is a significant refactor. |
JordiBForgeFlow
force-pushed
the
10.0-account_check_printing-fixes
branch
from
3cc6b01
to
305bf8f
Compare
max3903
approved these changes
Jun 3, 2019
with account.invoice
AaronHForgeFlow
force-pushed
the
10.0-account_check_printing-fixes
branch
from
43fca2a
to
89c6f86
Compare
AaronHForgeFlow
approved these changes
Jun 5, 2019
|
travis ci was red :S |
|
@aheficent can you incorporate these changes into 11.0 and 12.0 (#241) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the method to compute the lines that appear in the check report, so that the dependency with account.invoice is removed.
The old code would not display, for example, the lines corresponding to payments to employee expenses.
The new code relies only on account.move.line and account.partial.reconcile.