Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] agreement: Migration to 16.0 #12

Merged
merged 45 commits into from
Mar 16, 2023

Conversation

FrancoMaxime
Copy link
Member

No description provided.

ygol and others added 30 commits February 23, 2023 13:32
we move the is_template field definition and the agreement.type model from
the agreement_legal module to the agreement module.

The fields are not displayed by default, unless the feature is enabled through a
technical feature group, this is configurable in the agreement_sale module (because agreement
in itself has no UI, and agreement_legal enables the feature by default)
- The `agreement` model now features mail and activities from its base module.
- The `agreement_legal` module doesn't need to add mail support now.
- Add activities to form views.

@Tecnativa TT22477
Update agreement and agreement_sale to restore the behavior of v10
Currently translated at 88.4% (61 of 69 strings)

Translation: contract-14.0/contract-14.0-agreement
Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-agreement/fr_FR/
Currently translated at 15.9% (11 of 69 strings)

Translation: contract-14.0/contract-14.0-agreement
Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-agreement/nl/
Currently translated at 100.0% (69 of 69 strings)

Translation: contract-14.0/contract-14.0-agreement
Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-agreement/es_AR/
Currently translated at 100.0% (70 of 70 strings)

Translation: contract-14.0/contract-14.0-agreement
Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-agreement/es_AR/
Currently translated at 100.0% (76 of 76 strings)

Translation: contract-14.0/contract-14.0-agreement
Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-agreement/es_AR/
Currently translated at 34.2% (26 of 76 strings)

Translation: contract-14.0/contract-14.0-agreement
Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-agreement/ca/
Currently translated at 1.3% (1 of 76 strings)

Translation: contract-14.0/contract-14.0-agreement
Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-agreement/it/
Currently translated at 100.0% (76 of 76 strings)

Translation: contract-14.0/contract-14.0-agreement
Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-agreement/es_AR/
Currently translated at 100.0% (76 of 76 strings)

Translation: contract-14.0/contract-14.0-agreement
Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-agreement/ca/
Currently translated at 59.2% (45 of 76 strings)

Translation: contract-14.0/contract-14.0-agreement
Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-agreement/it/
oca-ci and others added 5 commits February 23, 2023 13:32
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: agreement-15.0/agreement-15.0-agreement
Translate-URL: https://translation.odoo-community.org/projects/agreement-15-0/agreement-15-0-agreement/
Currently translated at 57.6% (45 of 78 strings)

Translation: agreement-15.0/agreement-15.0-agreement
Translate-URL: https://translation.odoo-community.org/projects/agreement-15-0/agreement-15-0-agreement/it/
@rousseldenis rousseldenis mentioned this pull request Feb 23, 2023
@rousseldenis
Copy link
Sponsor Contributor

/ocabot migration agreement

Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. Two minor changes

agreement/models/agreement.py Outdated Show resolved Hide resolved
agreement/tests/test_agreement.py Outdated Show resolved Hide resolved
Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@baimont baimont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review, lgtm

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-12-by-gurneyalex-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d07da33 into OCA:16.0 Mar 16, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1f67ba1. Thanks a lot for contributing to OCA. ❤️

@FrancoMaxime FrancoMaxime deleted the 16.0-mig-agreement branch March 16, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet