16.0 mig agreement #7

vibhascs · 2023-01-11T11:04:39Z

No description provided.

we move the is_template field definition and the agreement.type model from the agreement_legal module to the agreement module. The fields are not displayed by default, unless the feature is enabled through a technical feature group, this is configurable in the agreement_sale module (because agreement in itself has no UI, and agreement_legal enables the feature by default)

- The `agreement` model now features mail and activities from its base module. - The `agreement_legal` module doesn't need to add mail support now. - Add activities to form views. @Tecnativa TT22477

Update agreement and agreement_sale to restore the behavior of v10

Currently translated at 88.4% (61 of 69 strings) Translation: contract-14.0/contract-14.0-agreement Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-agreement/fr_FR/

Currently translated at 15.9% (11 of 69 strings) Translation: contract-14.0/contract-14.0-agreement Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-agreement/nl/

Currently translated at 100.0% (69 of 69 strings) Translation: contract-14.0/contract-14.0-agreement Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-agreement/es_AR/

Currently translated at 100.0% (70 of 70 strings) Translation: contract-14.0/contract-14.0-agreement Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-agreement/es_AR/

Currently translated at 100.0% (76 of 76 strings) Translation: contract-14.0/contract-14.0-agreement Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-agreement/es_AR/

Currently translated at 34.2% (26 of 76 strings) Translation: contract-14.0/contract-14.0-agreement Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-agreement/ca/

Currently translated at 1.3% (1 of 76 strings) Translation: contract-14.0/contract-14.0-agreement Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-agreement/it/

Currently translated at 100.0% (76 of 76 strings) Translation: contract-14.0/contract-14.0-agreement Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-agreement/es_AR/

Currently translated at 100.0% (76 of 76 strings) Translation: contract-14.0/contract-14.0-agreement Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-agreement/ca/

Currently translated at 59.2% (45 of 76 strings) Translation: contract-14.0/contract-14.0-agreement Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-agreement/it/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: agreement-15.0/agreement-15.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-15-0/agreement-15-0-agreement/

Currently translated at 59.2% (45 of 76 strings) Translation: agreement-15.0/agreement-15.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-15-0/agreement-15-0-agreement/it/

sanchonuria

I have some doubts, May I ask for your answer 😄 ?

sanchonuria · 2023-01-26T15:43:16Z

agreement/views/agreement.xml

                            <field
                                name="partner_id"
                                attrs="{'required': [('is_template', '=', False)]}"
+                                groups="agreement.group_use_agreement_template"


Why do you need this group now?

He added this group because the attr need the value of is_template but it is protected by a group. I prefer to remove the group on partner_id and add before the field is_template with invisible="1". In this way, the result of the attr can be evaluated by odoo.

Suggested change

groups="agreement.group_use_agreement_template"

<field name="is_template" invisible="1 />

<field

name="partner_id"

attrs="{'required': [('is_template', '=', False)]}"

/>

sanchonuria · 2023-01-26T15:43:20Z

agreement/views/agreement.xml

-                            attrs="{'invisible': True}"
-                        />
-                    </notebook>
+<!--                    <notebook>-->


Why are you commenting this?

Good question

FrancoMaxime · 2023-02-18T17:34:11Z

agreement/views/agreement.xml

                            <field
                                name="partner_id"
                                attrs="{'required': [('is_template', '=', False)]}"
+                                groups="agreement.group_use_agreement_template"


He added this group because the attr need the value of is_template but it is protected by a group. I prefer to remove the group on partner_id and add before the field is_template with invisible="1". In this way, the result of the attr can be evaluated by odoo.

Suggested change

groups="agreement.group_use_agreement_template"

<field name="is_template" invisible="1 />

<field

name="partner_id"

attrs="{'required': [('is_template', '=', False)]}"

/>

FrancoMaxime · 2023-02-18T17:34:52Z

agreement/views/agreement.xml

-                            attrs="{'invisible': True}"
-                        />
-                    </notebook>
+<!--                    <notebook>-->


Good question

FrancoMaxime · 2023-02-18T17:35:50Z

setup/agreement/odoo/addons/agreement

@@ -0,0 +1 @@
+../../../../agreement


This should comes in a separated commit named [MIG] agreement: pre-commit execution

FrancoMaxime · 2023-02-18T17:36:19Z

setup/agreement/setup.py

@@ -0,0 +1,6 @@
+import setuptools


This should comes in a separated commit named [MIG] agreement: pre-commit execution

FrancoMaxime · 2023-02-18T17:36:19Z

setup/agreement/odoo/addons/agreement

@@ -0,0 +1 @@
+../../../../agreement


This should comes in a separated commit named [MIG] agreement: pre-commit execution

FrancoMaxime · 2023-02-18T17:36:24Z

setup/agreement/setup.py

@@ -0,0 +1,6 @@
+import setuptools


This should comes in a separated commit named [MIG] agreement: pre-commit execution

rousseldenis · 2023-02-23T13:20:13Z

@vibhascs Do you mind if we move to #12 ?

github-actions · 2023-06-25T12:25:18Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

gdgellatly · 2023-07-02T08:23:08Z

Closing as merged in #12

ygol and others added 30 commits January 11, 2023 16:19

[MIG] agreement: Migration to 12.0

d294911

FIX security issue + details

d8b44d7

[FIX] Missing newline

98d84f5

Update translation

54e3bfa

agreement 12.0.1.0.1

2e7d8dd

[IMP] agreement,agreement_legal: support activities

71c9891

- The `agreement` model now features mail and activities from its base module. - The `agreement_legal` module doesn't need to add mail support now. - Add activities to form views. @Tecnativa TT22477

agreement 12.0.1.1.0

f513319

[IMP] agreement: Minor improvements

b7995d6

Re-introduce module agreement_account

cbb57ad

Update agreement and agreement_sale to restore the behavior of v10

[IMP] agreement: black, isort, prettier

33de2da

[MIG] agreement: Migration to 13.0

2124cf5

[IMP] agreement: black, isort, prettier

f0fd1c4

[MIG] agreement: Migration to 14.0

77f1ee5

Added translation using Weblate (French (France))

472622c

Translated using Weblate (French (France))

84151db

Currently translated at 88.4% (61 of 69 strings) Translation: contract-14.0/contract-14.0-agreement Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-agreement/fr_FR/

Added translation using Weblate (Dutch)

7cc5c69

Translated using Weblate (Dutch)

0c98659

Currently translated at 15.9% (11 of 69 strings) Translation: contract-14.0/contract-14.0-agreement Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-agreement/nl/

Added translation using Weblate (Spanish (Argentina))

e593cd0

Translated using Weblate (Spanish (Argentina))

0524780

Currently translated at 100.0% (69 of 69 strings) Translation: contract-14.0/contract-14.0-agreement Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-agreement/es_AR/

Translated using Weblate (Spanish (Argentina))

504b81c

Currently translated at 100.0% (70 of 70 strings) Translation: contract-14.0/contract-14.0-agreement Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-agreement/es_AR/

Added translation using Weblate (Italian)

66e448a

Translated using Weblate (Spanish (Argentina))

129ef19

Currently translated at 100.0% (76 of 76 strings) Translation: contract-14.0/contract-14.0-agreement Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-agreement/es_AR/

Translated using Weblate (Catalan)

fcea20d

Currently translated at 34.2% (26 of 76 strings) Translation: contract-14.0/contract-14.0-agreement Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-agreement/ca/

Translated using Weblate (Italian)

9ba17f6

Currently translated at 1.3% (1 of 76 strings) Translation: contract-14.0/contract-14.0-agreement Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-agreement/it/

Translated using Weblate (Spanish (Argentina))

d1a61e0

Currently translated at 100.0% (76 of 76 strings) Translation: contract-14.0/contract-14.0-agreement Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-agreement/es_AR/

Translated using Weblate (Catalan)

32b84d5

Currently translated at 100.0% (76 of 76 strings) Translation: contract-14.0/contract-14.0-agreement Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-agreement/ca/

Translated using Weblate (Italian)

1db7032

Currently translated at 59.2% (45 of 76 strings) Translation: contract-14.0/contract-14.0-agreement Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-agreement/it/

[IMP] agreement: black, isort, prettier

9fa7ae1

[MIG] agreement: Migration to 15.0

154b128

oca-ci and others added 8 commits January 11, 2023 16:19

[UPD] Update agreement.pot

19dc58c

[UPD] README.rst

48c80e6

[UPD] Update agreement.pot

7fc0513

Update translation files

d5016b6

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: agreement-15.0/agreement-15.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-15-0/agreement-15-0-agreement/

[UPD] Update agreement.pot

7537f1b

Update translation files

4a1a701

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: agreement-15.0/agreement-15.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-15-0/agreement-15-0-agreement/

Translated using Weblate (Italian)

5381486

Currently translated at 59.2% (45 of 76 strings) Translation: agreement-15.0/agreement-15.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-15-0/agreement-15-0-agreement/it/

[16.0][MIG]agreement

97d9e7e

sanchonuria reviewed Jan 26, 2023

View reviewed changes

FrancoMaxime suggested changes Feb 18, 2023

View reviewed changes

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 25, 2023

gdgellatly closed this Jul 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

16.0 mig agreement #7

16.0 mig agreement #7

vibhascs commented Jan 11, 2023

sanchonuria left a comment

sanchonuria Jan 26, 2023

FrancoMaxime Feb 18, 2023

sanchonuria Jan 26, 2023

FrancoMaxime Feb 18, 2023

FrancoMaxime Feb 18, 2023

FrancoMaxime Feb 18, 2023

FrancoMaxime Feb 18, 2023

FrancoMaxime Feb 18, 2023

FrancoMaxime Feb 18, 2023

FrancoMaxime Feb 18, 2023

rousseldenis commented Feb 23, 2023

github-actions bot commented Jun 25, 2023

gdgellatly commented Jul 2, 2023

		@@ -0,0 +1 @@
		../../../../agreement

		@@ -0,0 +1 @@
		../../../../agreement

16.0 mig agreement #7

16.0 mig agreement #7

Conversation

vibhascs commented Jan 11, 2023

sanchonuria left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rousseldenis commented Feb 23, 2023

github-actions bot commented Jun 25, 2023

gdgellatly commented Jul 2, 2023