Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

16.0 mig agreement #7

Closed
wants to merge 38 commits into from
Closed

16.0 mig agreement #7

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
d294911
[MIG] agreement: Migration to 12.0
ygol Mar 19, 2019
d8b44d7
FIX security issue + details
bealdav Apr 5, 2019
98d84f5
[FIX] Missing newline
max3903 May 7, 2019
54e3bfa
Update translation
rdc02271 May 4, 2019
ed9361b
[IMP] move some notions from agreement_legal to agreement
liweijie0812 Sep 3, 2019
2e7d8dd
agreement 12.0.1.0.1
pedrocasi Feb 17, 2020
71c9891
[IMP] agreement,agreement_legal: support activities
Mar 6, 2020
f513319
agreement 12.0.1.1.0
extrememicro Mar 6, 2020
b7995d6
[IMP] agreement: Minor improvements
sergio-teruel Apr 27, 2020
cbb57ad
Re-introduce module agreement_account
alexis-via May 21, 2020
33de2da
[IMP] agreement: black, isort, prettier
sergio-teruel Feb 14, 2021
2124cf5
[MIG] agreement: Migration to 13.0
sergio-teruel Feb 14, 2021
f0fd1c4
[IMP] agreement: black, isort, prettier
newtratip Feb 16, 2021
77f1ee5
[MIG] agreement: Migration to 14.0
newtratip Feb 16, 2021
472622c
Added translation using Weblate (French (France))
Yvesldff Apr 11, 2021
84151db
Translated using Weblate (French (France))
Yvesldff Apr 11, 2021
7cc5c69
Added translation using Weblate (Dutch)
bosd Apr 23, 2021
0c98659
Translated using Weblate (Dutch)
bosd Apr 23, 2021
e593cd0
Added translation using Weblate (Spanish (Argentina))
ibuioli Apr 24, 2021
0524780
Translated using Weblate (Spanish (Argentina))
ibuioli May 30, 2021
504b81c
Translated using Weblate (Spanish (Argentina))
ibuioli Jun 14, 2021
66e448a
Added translation using Weblate (Italian)
primes2h Jul 6, 2021
129ef19
Translated using Weblate (Spanish (Argentina))
ibuioli Jul 9, 2021
fcea20d
Translated using Weblate (Catalan)
pere-aquarian Sep 13, 2021
9ba17f6
Translated using Weblate (Italian)
francesco-ooops Oct 6, 2021
d1a61e0
Translated using Weblate (Spanish (Argentina))
ibuioli Feb 6, 2022
32b84d5
Translated using Weblate (Catalan)
Noel000 Mar 22, 2022
1db7032
Translated using Weblate (Italian)
scigghia Mar 26, 2022
9fa7ae1
[IMP] agreement: black, isort, prettier
etobella Jul 13, 2022
154b128
[MIG] agreement: Migration to 15.0
olgamarcocb May 11, 2022
19dc58c
[UPD] Update agreement.pot
Aug 9, 2022
48c80e6
[UPD] README.rst
OCA-git-bot Aug 9, 2022
7fc0513
[UPD] Update agreement.pot
Oct 1, 2022
d5016b6
Update translation files
oca-transbot Oct 1, 2022
7537f1b
[UPD] Update agreement.pot
Dec 16, 2022
4a1a701
Update translation files
weblate Dec 16, 2022
5381486
Translated using Weblate (Italian)
mymage Dec 28, 2022
97d9e7e
[16.0][MIG]agreement
vibhascs Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions agreement/README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,16 @@ Agreement
:target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
:alt: License: AGPL-3
.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fagreement-lightgray.png?logo=github
:target: https://github.com/OCA/agreement/tree/15.0/agreement
:target: https://github.com/OCA/agreement/tree/16.0/agreement
:alt: OCA/agreement
.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
:target: https://translation.odoo-community.org/projects/agreement-15-0/agreement-15-0-agreement
:target: https://translation.odoo-community.org/projects/agreement-16-0/agreement-16-0-agreement
:alt: Translate me on Weblate
.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
:target: https://runboat.odoo-community.org/webui/builds.html?repo=OCA/agreement&target_branch=16.0
:alt: Try me on Runboat

|badge1| |badge2| |badge3| |badge4|
|badge1| |badge2| |badge3| |badge4| |badge5|

This module adds an *Agreement* object with the following properties:

Expand Down Expand Up @@ -48,7 +51,7 @@ Bug Tracker
Bugs are tracked on `GitHub Issues <https://github.com/OCA/agreement/issues>`_.
In case of trouble, please check there if your issue has already been reported.
If you spotted it first, help us smashing it by providing a detailed and welcomed
`feedback <https://github.com/OCA/agreement/issues/new?body=module:%20agreement%0Aversion:%2015.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
`feedback <https://github.com/OCA/agreement/issues/new?body=module:%20agreement%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.

Do not contact contributors directly about support or help with technical issues.

Expand Down Expand Up @@ -97,6 +100,6 @@ Current `maintainers <https://odoo-community.org/page/maintainer-role>`__:

|maintainer-ygol| |maintainer-alexis-via|

This module is part of the `OCA/agreement <https://github.com/OCA/agreement/tree/15.0/agreement>`_ project on GitHub.
This module is part of the `OCA/agreement <https://github.com/OCA/agreement/tree/16.0/agreement>`_ project on GitHub.

You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.
2 changes: 1 addition & 1 deletion agreement/__manifest__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
{
"name": "Agreement",
"summary": "Adds an agreement object",
"version": "15.0.1.0.0",
"version": "16.0.1.0.0",
"category": "Contract",
"author": "Akretion, "
"Yves Goldberg (Ygol Internetwork), "
Expand Down
23 changes: 12 additions & 11 deletions agreement/views/agreement.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,19 +31,20 @@
<group name="main">
<group name="left">
<field name="code" />
<field
name="is_template"
groups="agreement.group_use_agreement_template"
/>
<field
name="partner_id"
attrs="{'required': [('is_template', '=', False)]}"
groups="agreement.group_use_agreement_template"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need this group now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He added this group because the attr need the value of is_template but it is protected by a group. I prefer to remove the group on partner_id and add before the field is_template with invisible="1". In this way, the result of the attr can be evaluated by odoo.

Suggested change
groups="agreement.group_use_agreement_template"
<field name="is_template" invisible="1 />
<field
name="partner_id"
attrs="{'required': [('is_template', '=', False)]}"
/>

/>
<field
name="agreement_type_id"
groups="agreement.group_use_agreement_type"
/>
<field name="domain" widget="radio" />
<field
name="is_template"
groups="agreement.group_use_agreement_template"
/>
</group>
<group name="right">
<field name="signature_date" />
Expand All @@ -55,13 +56,13 @@
/>
</group>
</group>
<notebook>
<page
name="config"
string="Configuration"
attrs="{'invisible': True}"
/>
</notebook>
<!-- <notebook>-->
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you commenting this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question

<!-- <page-->
<!-- name="config"-->
<!-- string="Configuration"-->
<!-- invisible="1"-->
<!-- />-->
<!-- </notebook>-->
</sheet>
<div class="oe_chatter">
<field name="message_follower_ids" widget="mail_followers" />
Expand Down
1 change: 1 addition & 0 deletions setup/agreement/odoo/addons/agreement
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
../../../../agreement
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should comes in a separated commit named [MIG] agreement: pre-commit execution

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should comes in a separated commit named [MIG] agreement: pre-commit execution

6 changes: 6 additions & 0 deletions setup/agreement/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import setuptools
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should comes in a separated commit named [MIG] agreement: pre-commit execution

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should comes in a separated commit named [MIG] agreement: pre-commit execution


setuptools.setup(
setup_requires=['setuptools-odoo'],
odoo_addon=True,
)