-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0][MIG] apps_download: Migration to 13.0 #75
Conversation
f1cbc8e
to
2997159
Compare
83eb8d1
to
ca701c4
Compare
* Download file name Fix (OCA#18) * update products attributes and create attribute values (OCA#40) * [FIX]update the product for the new version * [FIX]max version problem and also rewrite logic so the from fronend if the version is not selected manually then the default(with less sequence) will be downloaded * [IMP]added technical name search functionality * [IMP]Merged create and update product cron job * [FIX]fix variable names * 11.0 issue OCA#50 add the module technical name in front page (OCA#52) * [FIX][49] solve pager with search parameter * [IMP]website_apps_store : add technical name in front page * [IMP]website_apps_store : add website tour to search technical name * [FIX]website_apps_store : add demo/product_template_demo.xml in menifest.py
Currently translated at 100.0% (15 of 15 strings) Translation: apps-store-12.0/apps-store-12.0-apps_download Translate-URL: https://translation.odoo-community.org/projects/apps-store-12-0/apps-store-12-0-apps_download/pt_BR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: apps-store-12.0/apps-store-12.0-apps_download Translate-URL: https://translation.odoo-community.org/projects/apps-store-12-0/apps-store-12-0-apps_download/
Currently translated at 72.7% (8 of 11 strings) Translation: apps-store-12.0/apps-store-12.0-apps_download Translate-URL: https://translation.odoo-community.org/projects/apps-store-12-0/apps-store-12-0-apps_download/es/
Currently translated at 72.7% (8 of 11 strings) Translation: apps-store-12.0/apps-store-12.0-apps_download Translate-URL: https://translation.odoo-community.org/projects/apps-store-12-0/apps-store-12-0-apps_download/it/
ca701c4
to
7996de3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review
I have split the black, isort, prettier diff into a separated commit. @Tardo please remember to do the proper steps for migrating to v13.
@CarlosRoca13 sorry, i can't reproduce the issue... ¿can you share the error? Use "debug=assets", CTRL+SHIFT+I to copy the error message from the browser console. EDIT: I saw the error in runbot. |
Ok @CarlosRoca13 it's a problem with the demo data of "apps_download". Runbot can't install the module because needs a custom configuration parameter but the demo data is loaded and dependencies are in a "unstable state" (like 'apps_product_creator') all views of this dependency are loaded but the module is not really installed, so new fields are not loaded (like "product_qty"). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so LGTM 👍
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at e7e27e0. Thanks a lot for contributing to OCA. ❤️ |
cc @Tecnativa TT23177