Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][MIG] apps_download: Migration to 13.0 #75

Merged
merged 10 commits into from
Aug 12, 2020

Conversation

Tardo
Copy link
Member

@Tardo Tardo commented Aug 5, 2020

cc @Tecnativa TT23177

@Tardo Tardo force-pushed the 13.0-mig-apps_download branch 2 times, most recently from 83eb8d1 to ca701c4 Compare August 5, 2020 11:51
@pedrobaeza pedrobaeza added this to the 13.0 milestone Aug 5, 2020
@OCA-git-bot OCA-git-bot mentioned this pull request Aug 5, 2020
3 tasks
Divya Modi and others added 10 commits August 5, 2020 18:50
* Download file name Fix (OCA#18)

* update products attributes and create attribute values (OCA#40)

* [FIX]update the product for the new version

* [FIX]max version problem and also rewrite logic so the from fronend if the version is not selected manually then the default(with less sequence) will be downloaded

* [IMP]added technical name search functionality

* [IMP]Merged create and update product cron job

* [FIX]fix variable names

* 11.0 issue OCA#50 add the module technical name in front page (OCA#52)

* [FIX][49] solve pager with search parameter

* [IMP]website_apps_store : add technical name in front page

* [IMP]website_apps_store : add website tour to search technical name

* [FIX]website_apps_store : add demo/product_template_demo.xml in menifest.py
Currently translated at 100.0% (15 of 15 strings)

Translation: apps-store-12.0/apps-store-12.0-apps_download
Translate-URL: https://translation.odoo-community.org/projects/apps-store-12-0/apps-store-12-0-apps_download/pt_BR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: apps-store-12.0/apps-store-12.0-apps_download
Translate-URL: https://translation.odoo-community.org/projects/apps-store-12-0/apps-store-12-0-apps_download/
Currently translated at 72.7% (8 of 11 strings)

Translation: apps-store-12.0/apps-store-12.0-apps_download
Translate-URL: https://translation.odoo-community.org/projects/apps-store-12-0/apps-store-12-0-apps_download/es/
Currently translated at 72.7% (8 of 11 strings)

Translation: apps-store-12.0/apps-store-12.0-apps_download
Translate-URL: https://translation.odoo-community.org/projects/apps-store-12-0/apps-store-12-0-apps_download/it/
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

I have split the black, isort, prettier diff into a separated commit. @Tardo please remember to do the proper steps for migrating to v13.

@CarlosRoca13
Copy link

I catch two errors when I was trying to access to github section. You can see it on the attached gif
Peek 06-08-2020 09-17

@Tardo
Copy link
Member Author

Tardo commented Aug 6, 2020

@CarlosRoca13 sorry, i can't reproduce the issue... ¿can you share the error? Use "debug=assets", CTRL+SHIFT+I to copy the error message from the browser console.
Thanks!

EDIT: I saw the error in runbot.

@Tardo
Copy link
Member Author

Tardo commented Aug 6, 2020

Ok @CarlosRoca13 it's a problem with the demo data of "apps_download". Runbot can't install the module because needs a custom configuration parameter but the demo data is loaded and dependencies are in a "unstable state" (like 'apps_product_creator') all views of this dependency are loaded but the module is not really installed, so new fields are not loaded (like "product_qty").

Copy link

@CarlosRoca13 CarlosRoca13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so LGTM 👍

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-75-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6e40561 into OCA:13.0 Aug 12, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e7e27e0. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants