update products attributes and create attribute values #40

bizzappdev · 2018-11-03T13:14:55Z

following changes are done in this PR.

Added a new cron job for updating the product attribute values when new version added. #38
Fix the max version problem
Solve the problem from Product page when no version is manually selected it was downloading latest version while the default selected version was olded. Now the selected version has been download
search facility for explicitly on technical_name Cannot find module account_invoice_kanban #39

…f the version is not selected manually then the default(with less sequence) will be downloaded

bizzappdev · 2018-11-03T13:19:00Z

@oscarolar @RoelAdriaans @StephanRozendaal Can you please review.
cc @elicoidal @sbidoul

elicoidal

Please update the version number,
LGTM

elicoidal · 2018-11-04T09:57:25Z

apps_product_creator/models/odoo_module.py

@@ -72,6 +76,44 @@ def _create_product(self):
                    products |= new_product
        return products

+    @api.multi
+    def _update_product(self):
+        attribute = self.env.ref(


please add docstring

sbidoul · 2018-11-04T09:59:08Z

@bizzappdev would it make sense to merge the two crons (creation and update)? It would be easier to manage IMO.

StephanRozendaal

In general LGTM, just one question.

StephanRozendaal · 2018-11-06T11:10:17Z

website_apps_store/controllers/main.py

@@ -23,7 +23,9 @@ def _get_search_domain(self, search, category, attrib_values):
        if search:
            for srch in search.split(" "):
                domain += [
-                    '|', '|', '|', '|', '|', '|', '|', ('name', 'ilike', srch),
+                    '|', '|', '|', '|', '|', '|', '|', '|',


Related to a security reason: Isn't it better to use expression.AND in this case since it santizes the 'srch' input (which comes from the internet)?

@StephanRozendaal we have just overridden the core method and enhance it https://github.com/odoo/odoo/blob/11.0/addons/website_sale/controllers/main.py#L176

bizzappdev · 2018-11-09T09:14:44Z

@bizzappdev would it make sense to merge the two crons (creation and update)? It would be easier to manage IMO.

Changes are done and added call for update product method from create cron, remove the extra update cron and rename the original cron with "Create / Update"

elicoidal

Please review the version number.

elicoidal · 2018-11-09T10:52:24Z

apps_download/__manifest__.py

@@ -3,7 +3,7 @@
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 {
    "name": "Product Download for Appstore",
-    "version": "11.0.1.0.1",
+    "version": "11.0.2.0.1",


elicoidal · 2018-11-09T11:05:49Z

apps_product_creator/models/odoo_module.py

+    def _update_series_product_attribute_values(self):
+        attribute = self.env.ref(
+            'apps_product_creator.attribute_odoo_version')
+        pro_att_val = self.env['product.attribute.value']


prod_attr_val? (nitpicking)

variable name changed.

elicoidal · 2018-11-09T11:06:36Z

@sbidoul could you have a quick look?

sbidoul · 2018-11-10T10:24:08Z

Hi all, I deployed this PR and launched the cron. It seems to work fine.

* [FIX]update the product for the new version * [FIX]max version problem and also rewrite logic so the from fronend if the version is not selected manually then the default(with less sequence) will be downloaded * [IMP]added technical name search functionality * change version number * [IMP]Merged create and update product cron job * [FIX]fix variable names

* Download file name Fix (OCA#18) * update products attributes and create attribute values (OCA#40) * [FIX]update the product for the new version * [FIX]max version problem and also rewrite logic so the from fronend if the version is not selected manually then the default(with less sequence) will be downloaded * [IMP]added technical name search functionality * [IMP]Merged create and update product cron job * [FIX]fix variable names * 11.0 issue OCA#50 add the module technical name in front page (OCA#52) * [FIX][49] solve pager with search parameter * [IMP]website_apps_store : add technical name in front page * [IMP]website_apps_store : add website tour to search technical name * [FIX]website_apps_store : add demo/product_template_demo.xml in menifest.py

update products attributes and create attribute values (OCA#40) * [FIX]update the product for the new version * [FIX]max version problem and also rewrite logic so the from fronend if the version is not selected manually then the default(with less sequence) will be downloaded * [IMP]added technical name search functionality * change version number * [IMP]Merged create and update product cron job * [FIX]fix variable names Fix Bad rendering of links inside README (OCA#42) * [FIX][OCA#37]fix rendering from README * [ADD]added CONTRIBUTORS * [FIX] Sorting problem. sorted(for getting default version) as similar as it is sorted from website view [FIX]visibility for the selected options and filters improvements (OCA#43) * [FIX]visibility for the selection options and do not loss the selection option when we change filter from maturity to version etc. * [VER]Added Version number [FIX]CSS module description [FIX]website_apps_store: fix the shop pager [FIX][49] solve pager with search parameter (OCA#51) Sort by Download and rating (OCA#46) * [WIP] added initial support for Google recaptcha * [WIP]added dependencies * [IMP]Added google captcha with download functionality with reset and validation * [IMP]added download count fields and increament it when donwloaded * [ADD]added missing files * [IMP]website_apps_store: add sort by download count on website * remove console and not extra space * [VER]changed version number * [FIX]website_apps_store: fix test case error * [FIX]reset only if google recaptcha is initiated 11.0 issue OCA#50 add the module technical name in front page (OCA#52) * [FIX][49] solve pager with search parameter * [IMP]website_apps_store : add technical name in front page * [IMP]website_apps_store : add website tour to search technical name * [FIX]website_apps_store : add demo/product_template_demo.xml in menifest.py [FIX] website product page event not define problem [FIX]fix 403 public user error [FIX]website_apps_store: attribute value change was not changing the href for the repository. OCA#56

* [FIX]update the product for the new version * [FIX]max version problem and also rewrite logic so the from fronend if the version is not selected manually then the default(with less sequence) will be downloaded * [IMP]added technical name search functionality * change version number * [IMP]Merged create and update product cron job * [FIX]fix variable names

* Download file name Fix (OCA#18) * update products attributes and create attribute values (OCA#40) * [FIX]update the product for the new version * [FIX]max version problem and also rewrite logic so the from fronend if the version is not selected manually then the default(with less sequence) will be downloaded * [IMP]added technical name search functionality * [IMP]Merged create and update product cron job * [FIX]fix variable names * 11.0 issue OCA#50 add the module technical name in front page (OCA#52) * [FIX][49] solve pager with search parameter * [IMP]website_apps_store : add technical name in front page * [IMP]website_apps_store : add website tour to search technical name * [FIX]website_apps_store : add demo/product_template_demo.xml in menifest.py

update products attributes and create attribute values (OCA#40) * [FIX]update the product for the new version * [FIX]max version problem and also rewrite logic so the from fronend if the version is not selected manually then the default(with less sequence) will be downloaded * [IMP]added technical name search functionality * change version number * [IMP]Merged create and update product cron job * [FIX]fix variable names Fix Bad rendering of links inside README (OCA#42) * [FIX][OCA#37]fix rendering from README * [ADD]added CONTRIBUTORS * [FIX] Sorting problem. sorted(for getting default version) as similar as it is sorted from website view [FIX]visibility for the selected options and filters improvements (OCA#43) * [FIX]visibility for the selection options and do not loss the selection option when we change filter from maturity to version etc. * [VER]Added Version number [FIX]CSS module description [FIX]website_apps_store: fix the shop pager [FIX][49] solve pager with search parameter (OCA#51) Sort by Download and rating (OCA#46) * [WIP] added initial support for Google recaptcha * [WIP]added dependencies * [IMP]Added google captcha with download functionality with reset and validation * [IMP]added download count fields and increament it when donwloaded * [ADD]added missing files * [IMP]website_apps_store: add sort by download count on website * remove console and not extra space * [VER]changed version number * [FIX]website_apps_store: fix test case error * [FIX]reset only if google recaptcha is initiated 11.0 issue OCA#50 add the module technical name in front page (OCA#52) * [FIX][49] solve pager with search parameter * [IMP]website_apps_store : add technical name in front page * [IMP]website_apps_store : add website tour to search technical name * [FIX]website_apps_store : add demo/product_template_demo.xml in menifest.py [FIX] website product page event not define problem [FIX]fix 403 public user error [FIX]website_apps_store: attribute value change was not changing the href for the repository. OCA#56

bizzappdev added 4 commits November 3, 2018 18:27

[FIX]update the product for the new version

b6820b8

[FIX]max version problem and also rewrite logic so the from fronend i…

321242a

…f the version is not selected manually then the default(with less sequence) will be downloaded

[IMP]added technical name search functionality

56a29d4

change version number

5364e8f

pedrobaeza added this to the 11.0 milestone Nov 3, 2018

elicoidal approved these changes Nov 4, 2018

View reviewed changes

StephanRozendaal approved these changes Nov 6, 2018

View reviewed changes

[IMP]Merged create and update product cron job

b9f4812

elicoidal approved these changes Nov 9, 2018

View reviewed changes

[FIX]fix variable names

c483202

elicoidal added needs review approved labels Nov 11, 2018

elicoidal merged commit 336af8d into OCA:11.0 Nov 11, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update products attributes and create attribute values #40

update products attributes and create attribute values #40

bizzappdev commented Nov 3, 2018

bizzappdev commented Nov 3, 2018

elicoidal left a comment

elicoidal Nov 4, 2018

sbidoul commented Nov 4, 2018

StephanRozendaal left a comment

StephanRozendaal Nov 6, 2018

bizzappdev Nov 9, 2018

bizzappdev commented Nov 9, 2018

elicoidal left a comment

elicoidal Nov 9, 2018

elicoidal Nov 9, 2018

bizzappdev Nov 9, 2018

elicoidal commented Nov 9, 2018

sbidoul commented Nov 10, 2018

update products attributes and create attribute values #40

update products attributes and create attribute values #40

Conversation

bizzappdev commented Nov 3, 2018

bizzappdev commented Nov 3, 2018

elicoidal left a comment

Choose a reason for hiding this comment

elicoidal Nov 4, 2018

Choose a reason for hiding this comment

sbidoul commented Nov 4, 2018

StephanRozendaal left a comment

Choose a reason for hiding this comment

StephanRozendaal Nov 6, 2018

Choose a reason for hiding this comment

bizzappdev Nov 9, 2018

Choose a reason for hiding this comment

bizzappdev commented Nov 9, 2018

elicoidal left a comment

Choose a reason for hiding this comment

elicoidal Nov 9, 2018

Choose a reason for hiding this comment

elicoidal Nov 9, 2018

Choose a reason for hiding this comment

bizzappdev Nov 9, 2018

Choose a reason for hiding this comment

elicoidal commented Nov 9, 2018

sbidoul commented Nov 10, 2018