[14.0][MIG] apps_download: Migration to 14.0 #85

ernestotejeda · 2021-08-11T17:20:22Z

Main changes:

Remove demo data like was removed in the github-connector migration to v14.0. See [14.0][MIG+REF+IMP] github_connector: Migration to 14.0, refactor and improvements interface-github#73 (comment)

* Download file name Fix (OCA#18) * update products attributes and create attribute values (OCA#40) * [FIX]update the product for the new version * [FIX]max version problem and also rewrite logic so the from fronend if the version is not selected manually then the default(with less sequence) will be downloaded * [IMP]added technical name search functionality * [IMP]Merged create and update product cron job * [FIX]fix variable names * 11.0 issue OCA#50 add the module technical name in front page (OCA#52) * [FIX][49] solve pager with search parameter * [IMP]website_apps_store : add technical name in front page * [IMP]website_apps_store : add website tour to search technical name * [FIX]website_apps_store : add demo/product_template_demo.xml in menifest.py

Currently translated at 100.0% (15 of 15 strings) Translation: apps-store-12.0/apps-store-12.0-apps_download Translate-URL: https://translation.odoo-community.org/projects/apps-store-12-0/apps-store-12-0-apps_download/pt_BR/

Currently translated at 72.7% (8 of 11 strings) Translation: apps-store-12.0/apps-store-12.0-apps_download Translate-URL: https://translation.odoo-community.org/projects/apps-store-12-0/apps-store-12-0-apps_download/es/

Currently translated at 72.7% (8 of 11 strings) Translation: apps-store-12.0/apps-store-12.0-apps_download Translate-URL: https://translation.odoo-community.org/projects/apps-store-12-0/apps-store-12-0-apps_download/it/

product.product has no attribute_value_ids, causing errors like [13.0] apps_download: Error while trying to download an app (base_import_async) OCA#80 This checks the correct product_template_attribute_value_ids associated

Give a proper warning when the module's code does not exist in disk yet instead of an exception

This field is needed in this module but was only being declared in the apps_download module. apps_download depends on this, so we can move the field declaration here. TT30343

Field datas_fname is no longer used TT30343

OCA-git-bot · 2021-08-11T17:20:26Z

Hi @ernestotejeda! Thank you very much for this contribution. As the addon you are improving does not have a declared maintainer, I take the opportunity to mention that you can consider adopting it. To do so, please read the maintainer role description, and, if interested, create a pull request to add your GitHub login to the maintainers key of the addon manifest.

CarlosRoca13 · 2021-08-12T05:24:19Z

apps_download/i18n/es.po

+#~ msgid "Dependent Products"
+#~ msgstr "Productos dependientes"
+
+#~ msgid "Description"
+#~ msgstr "Descripción"
+
+#~ msgid "Hello world"
+#~ msgstr "Hola mundo"
+
+#~ msgid "Title"
+#~ msgstr "Título"
+
+#~ msgid "Module path"
+#~ msgstr "Ruta del módulo"


Suggested change

#~ msgid "Dependent Products"

#~ msgstr "Productos dependientes"

#~ msgid "Description"

#~ msgstr "Descripción"

#~ msgid "Hello world"

#~ msgstr "Hola mundo"

#~ msgid "Title"

#~ msgstr "Título"

#~ msgid "Module path"

#~ msgstr "Ruta del módulo"

CarlosRoca13 · 2021-08-12T05:24:40Z

apps_download/i18n/fr.po

+#~ msgid "Dependent Products"
+#~ msgstr "Produits dépendants"
+
+#~ msgid "Description"
+#~ msgstr "Description"
+
+#~ msgid "Hello world"
+#~ msgstr "Hello world"
+
+#~ msgid "Title"
+#~ msgstr "Titre"
+
+#~ msgid "Module path"
+#~ msgstr "Chemin du module"


Suggested change

#~ msgid "Dependent Products"

#~ msgstr "Produits dépendants"

#~ msgid "Description"

#~ msgstr "Description"

#~ msgid "Hello world"

#~ msgstr "Hello world"

#~ msgid "Title"

#~ msgstr "Titre"

#~ msgid "Module path"

#~ msgstr "Chemin du module"

CarlosRoca13 · 2021-08-12T05:24:55Z

apps_download/i18n/it.po

+#~ msgid "Description"
+#~ msgstr "Descrizione"
+
+#~ msgid "Title"
+#~ msgstr "Titolo"


Suggested change

#~ msgid "Description"

#~ msgstr "Descrizione"

#~ msgid "Title"

#~ msgstr "Titolo"

CarlosRoca13 · 2021-08-12T05:25:15Z

apps_download/i18n/pt_BR.po

+#~ msgid "Dependent Products"
+#~ msgstr "Produtos dependentes"
+
+#~ msgid "Description"
+#~ msgstr "Descrição"
+
+#~ msgid "Hello world"
+#~ msgstr "Olá mundo"
+
+#~ msgid "Title"
+#~ msgstr "Título"
+
+#~ msgid "kg"
+#~ msgstr "kg"


Suggested change

#~ msgid "Dependent Products"

#~ msgstr "Produtos dependentes"

#~ msgid "Description"

#~ msgstr "Descrição"

#~ msgid "Hello world"

#~ msgstr "Olá mundo"

#~ msgid "Title"

#~ msgstr "Título"

#~ msgid "kg"

#~ msgstr "kg"

CarlosRoca13 · 2021-08-12T05:25:54Z

apps_download/tests/test_app_download.py

+    """Test for the Add download"""
+
+    def setUp(self):
+        super(TestAppDownload, self).setUp()


Suggested change

super(TestAppDownload, self).setUp()

super().setUp()

victoralmau

Same comments as Carlos.

ernestotejeda · 2021-08-12T12:46:10Z

@victoralmau @CarlosRoca13 changes done

pedrobaeza · 2021-08-16T13:28:22Z

/ocabot merge nobump

OCA-git-bot · 2021-08-16T13:28:31Z

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-85-by-pedrobaeza-bump-nobump, awaiting test results.

Signed-off-by pedrobaeza

pedrobaeza · 2021-08-24T12:55:38Z

/ocabot merge nobump

OCA-git-bot · 2021-08-24T12:55:54Z

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-85-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2021-08-24T13:11:28Z

Congratulations, your PR was merged at 6751a50. Thanks a lot for contributing to OCA. ❤️

Divya Modi and others added 14 commits August 11, 2021 08:48

[ADD] apps_download

217f5d0

[MIG] apps_download: Migration to 12.0

4b3f9c4

Translated using Weblate (Portuguese (Brazil))

49c8113

Currently translated at 100.0% (15 of 15 strings) Translation: apps-store-12.0/apps-store-12.0-apps_download Translate-URL: https://translation.odoo-community.org/projects/apps-store-12-0/apps-store-12-0-apps_download/pt_BR/

Translated using Weblate (Spanish)

2ad7d56

Currently translated at 72.7% (8 of 11 strings) Translation: apps-store-12.0/apps-store-12.0-apps_download Translate-URL: https://translation.odoo-community.org/projects/apps-store-12-0/apps-store-12-0-apps_download/es/

Added translation using Weblate (Italian)

9f1c7c2

Translated using Weblate (Italian)

0bc1e17

Currently translated at 72.7% (8 of 11 strings) Translation: apps-store-12.0/apps-store-12.0-apps_download Translate-URL: https://translation.odoo-community.org/projects/apps-store-12-0/apps-store-12-0-apps_download/it/

[IMP] apps_download: black, isort, prettier

53d70a6

[MIG] apps_download: Migration to 13.0

37f0a5c

[FIX] apps_download: Check correct attribute

ea7b723

product.product has no attribute_value_ids, causing errors like [13.0] apps_download: Error while trying to download an app (base_import_async) OCA#80 This checks the correct product_template_attribute_value_ids associated

[IMP] apps_download: better error message

a8469e2

Give a proper warning when the module's code does not exist in disk yet instead of an exception

[FIX] apps_product_creator: Add dependent_product_ids

93a3096

This field is needed in this module but was only being declared in the apps_download module. apps_download depends on this, so we can move the field declaration here. TT30343

[FIX] apps_download: Create ir.attachment correctly

ec12363

Field datas_fname is no longer used TT30343

[IMP] apps_download: black, isort, prettier

f7db315

ernestotejeda force-pushed the 14.0-mig-apps_download branch from 3170d39 to 2ee515a Compare August 11, 2021 17:30

CarlosRoca13 reviewed Aug 12, 2021

View reviewed changes

victoralmau approved these changes Aug 12, 2021

View reviewed changes

ernestotejeda force-pushed the 14.0-mig-apps_download branch from 2ee515a to a762a5c Compare August 12, 2021 12:45

victoralmau approved these changes Aug 12, 2021

View reviewed changes

CarlosRoca13 approved these changes Aug 12, 2021

View reviewed changes

OCA-git-bot added the approved label Aug 12, 2021

ernestotejeda mentioned this pull request Aug 16, 2021

[14.0][MIG] website_apps_store: Migration to 14.0 #86

Merged

1 task

chienandalu approved these changes Aug 16, 2021

View reviewed changes

OCA-git-bot added a commit that referenced this pull request Aug 16, 2021

Merge PR #85 into 14.0

5ee27a5

Signed-off-by pedrobaeza

OCA-git-bot added the bot is merging ⏳ label Aug 16, 2021

pedrobaeza mentioned this pull request Aug 16, 2021

Migration to version 14.0 #77

Closed

3 tasks

[MIG] apps_download: Migration to 14.0

e6cbb53

ernestotejeda force-pushed the 14.0-mig-apps_download branch from a762a5c to e6cbb53 Compare August 20, 2021 02:20

OCA-git-bot merged commit 22fd474 into OCA:14.0 Aug 24, 2021

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Aug 24, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0][MIG] apps_download: Migration to 14.0 #85

[14.0][MIG] apps_download: Migration to 14.0 #85

ernestotejeda commented Aug 11, 2021

OCA-git-bot commented Aug 11, 2021

CarlosRoca13 Aug 12, 2021

CarlosRoca13 Aug 12, 2021

CarlosRoca13 Aug 12, 2021

CarlosRoca13 Aug 12, 2021

CarlosRoca13 Aug 12, 2021

victoralmau left a comment

ernestotejeda commented Aug 12, 2021

pedrobaeza commented Aug 16, 2021

OCA-git-bot commented Aug 16, 2021

pedrobaeza commented Aug 24, 2021

OCA-git-bot commented Aug 24, 2021

OCA-git-bot commented Aug 24, 2021

[14.0][MIG] apps_download: Migration to 14.0 #85

[14.0][MIG] apps_download: Migration to 14.0 #85

Conversation

ernestotejeda commented Aug 11, 2021

OCA-git-bot commented Aug 11, 2021

CarlosRoca13 Aug 12, 2021

Choose a reason for hiding this comment

CarlosRoca13 Aug 12, 2021

Choose a reason for hiding this comment

CarlosRoca13 Aug 12, 2021

Choose a reason for hiding this comment

CarlosRoca13 Aug 12, 2021

Choose a reason for hiding this comment

CarlosRoca13 Aug 12, 2021

Choose a reason for hiding this comment

victoralmau left a comment

Choose a reason for hiding this comment

ernestotejeda commented Aug 12, 2021

pedrobaeza commented Aug 16, 2021

OCA-git-bot commented Aug 16, 2021

pedrobaeza commented Aug 24, 2021

OCA-git-bot commented Aug 24, 2021

OCA-git-bot commented Aug 24, 2021