[15.0][FW] [14.0][REF] account_payment_*: Use native payment object #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unication type and communication
…ere is a credit note If there is a credit note that partially cancel an invoice, the payment communication should be the combination of the invoice reference and the credit note one.
Since odoo/odoo@81aac30 AccountTestInvoicingCommon should be tagged post-install
… communication If some movements have been reconciled with the original invoice, their references should be added in communication too. e.g.: Manual credit notes
The previous approach creates manually the journal entries and does all the hard work, plus not being 100% compatible with the bank statement reconciliation widget (requiring a patch on OCB to see blue lines). That decision made sense on the moment it was done (v9), where the native payment model (account.payment) was very limited, and wasn't able to store all the needed information for the bank transaction. Now that the limitations are gone, we can get rid off this extra model, and generate instead `account.payment` records, using both the native model + methods to perform the same operations. This serves also to workaround the problem found in OCA#966. All the code, views and tests of main module have been adapted to this new approach in this commit. Later commits will adapt the rest of the modules of the suite, and add migration scripts to transit from the previous approach to this new one. TT39832
…yment refactoring Notables changes: - InstrId and EndToEndId tags are now filled with the journal entry ID, as there's no bank payment line identifier.
…nt refactoring Notable changes: - InstrId and EndToEndId tags are now filled with the journal entry ID, as there's no bank payment line identifier.
This adapts the old bank.payment.line records to account.payment records according the new approach.
hhgabelgaard
force-pushed
the
oca-port-pr-979-from-14.0-to-15.0
branch
from
3e951c2
to
ffafe33
Compare
The test introduced in 7bdb286 is not valid, as its indentation made it to not be executed. Anyways, the content and the tested things are also not correct.
hhgabelgaard
force-pushed
the
oca-port-pr-979-from-14.0-to-15.0
branch
3 times, most recently
from
52e6c73
to
a53c05a
Compare
hhgabelgaard
force-pushed
the
oca-port-pr-979-from-14.0-to-15.0
branch
from
a53c05a
to
c8559b0
Compare
|
Hi @hhgabelgaard, thanks for the work. I know it's very difficult to equal branches, because contributors are not forward-porting things at the same time they incorporate it on a lower branch (which I consider a bit disrespectful, but also counterproductive at long term), joined to the changes over versions. Anyway, for not charging you more, I'm doing such work in this some kind of spare time, starting with #1053 for things before the refactoring, and then I will port the refactoring. Closing this thus. Thanks again. |
|
Continuation at #1054 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #979 from 14.0 to 15.0.
Also includes: