[14.0][REF] account_payment_*: Use native payment object

[pedrobaeza]

The previous approach creates manually the journal entries and does all the hard work, plus not being 100% compatible with the bank statement reconciliation widget (requiring a patch on OCB to see blue lines).

That decision made sense on the moment it was done (v9), where the native payment model (account.payment) was very limited, and wasn't able to store all the needed information for the bank transaction.

Now that the limitations are gone, we can get rid off this extra model, and generate instead account.payment records, using both the native model + methods to perform the same operations.

This serves also to workaround the problem found in #966.

All the code, views and tests of main module have been adapted to this new approach

@Tecnativa TT39832

[pedrobaeza]

@alexis-via @sbidoul @HaraldPanten @ValentinVinagre @carlosdauden here it's the long awaited refactoring to make use of the native account.payment object for handling the bank lines and the move generation. The stats are good: +205 lines added against −810 lines removed.

See individual commits in order to have better comprehension of the process.

Working on the migration scripts now.

[carlosdauden]

At some point we should extend the account.move method def _get_invoice_in_payment_state(self): to return 'in_payment' to activate the payment status "In process" at the invoices.
https://github.com/odoo/odoo/blob/e337a7b4b0da970041ea26d6fdc6e2d39eb3e5be/addons/account/models/account_move.py#L1389

[pedrobaeza]

Indeed, but that's the next step not included in this PR.

[carlosdauden]

I have reviewed and tested and everything is correct, I am waiting for the migration scripts to approve

[HaraldPanten]

First tests seem to be working fine. But I'll need more time to check it properly.

Have you tested it in "semi-real" use cases?

[carlosdauden]

We should synchronize PR merge with changes in these modules so as not to cause malfunctions:

https://github.com/OCA/account-payment/blob/9f5e77607690da8f275ccec6270a2e8aad652145/account_payment_return_import_iso20022/models/payment_return.py#L16

https://github.com/OCA/account-reconcile/blob/2b77e6078785a08890205fa94dd7682eec102466/account_reconcile_payment_order/models/account_reconciliation_widget.py#L25-L33

[pedrobaeza]

Migration scripts are completed and tested on a real environment with all the possible cases, as well as the features of the module. We have an slower payment order confirmation due to the full creation of the account.payment + account.move, but faster times later on "File successfully uploaded" phase.

[pedrobaeza]

We should synchronize PR merge with changes in these modules so as not to cause malfunctions:

Done on:

OCA/account-payment#555
OCA/account-reconcile#505

[pedrobaeza]

I'm removing that leftovers in #1015, but there can't be equivalent options, as now each account.payment generates one move, and you can't group several payments from different partners in one record.

[hhgabelgaard]

Great work, thank you !
Has this change been forward ported to 15.0?
Or is there any plans for this?
The upgrade path is kind of broken now it seems ?

[pedrobaeza]

Yes, indeed. I want to do it for 15.0, but no time for now. Do you want to do it? I will review it. It should be pretty straight-forward.

[acsonefho]

@pedrobaeza This field payment_ids doesn't exist on account.payment.order model.
Or maybe there is a missing dependency?

[pedrobaeza]

This PR adds such field: https://github.com/OCA/bank-payment/pull/979/files#diff-e1bae20141deca080d6db095e9874359ec1ed9d92f0b4d46aedc9f3ecea71cf0R80