[MIG][14.0] account_banking_mandate #770
Conversation
* Bug OCA#96 bad use of new API * [Usability] mandates: search by reference, add group_by, add seq type in tree view * Add scheme in mandate tree+search view * Replace tabs by spaces in mandate views * account_banking_mandate/views/account_banking_mandate_view.xml: convert from dos to unix format * Add multi-company rule on account.banking.mandate
Fix an important regression in account_banking_sepa_direct_debit: "Date of Last Debit" was not set any more Proper write of date_done with account_banking_payment_export is installed without account_banking_payment_transfer Add post-install script for date_sent on payment.order
The restriction rule Banking Mandate multi-company, gives an error when editing a partner bank account from a company A when that account has created a mandate from another company B. So it is impossible to create a mandate for each company without disabling the rule. Solution: Uncheck the rule writte in Banking Mandate multi-company. But i'm not sure this is correct.
* Short headers * Bump version numbers * es translations
* Add creditor identifier field to report mandate. * Translate. * Split basic and sepa mandate * Use api.multi instead * Make format field required
Port almost all modules to v10 * Update to EPC Rulebook v9.2 that start to apply on 2016-11-20 (bug OCA#300)
…ovided Using same method as in upstream, mandate is filled on invoice creation if no one is provided. This way, we don't need to install account_banking_mandate_sale if we don't want to handle several mandates at sales level.
…ically on the payment line'
…date + Add valid_mandate field and fix onchange (cherry picked from commit 25d2e4d)
add tests and constrains
* Fix tests due to upstream change Odoo has added a constraint for avoiding a company currency change if there are move lines, making these tests to fail, as the currency is changed to EUR. With this commit, we create a new company with EUR currency for avoiding the problem. This commit also changes account_banking_mandate for not duplicating mandate number, as it was detected during the test creation. Similar to 1f8e345 * Avoid errors in tests when run with other modules * More adaptations to make tests to work properly All these problems comes from using demo data.
Currently translated at 100,0% (82 of 82 strings) Translation: bank-payment-11.0/bank-payment-11.0-account_banking_mandate Translate-URL: https://translation.odoo-community.org/projects/bank-payment-11-0/bank-payment-11-0-account_banking_mandate/es/
Currently translated at 68,3% (56 of 82 strings) Translation: bank-payment-11.0/bank-payment-11.0-account_banking_mandate Translate-URL: https://translation.odoo-community.org/projects/bank-payment-11-0/bank-payment-11-0-account_banking_mandate/ca/
StefanRijnhart
force-pushed
the
14-mig-account_banking_mandate_akretion
branch
2 times, most recently
from
b99164f
to
e242654
Compare
There was a problem hiding this comment.
Thank you @StefanRijnhart Looks good 👍
About the commit history, could you squash the 2 migration commits in one with the appropriate format? ([MIG] $MODULE: Migration to 14.0 - See https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-14.0) And possibly put the [MIG] commit after the [IMP] one?
|
@StefanRijnhart do you still plan on making more changes? If not, can you mark the PR as ready? |
|
This PR has the |
|
I can follow up, but I don't agree with squashing the 2 commits because one is from Alexis and the other is mine. |
StefanRijnhart
force-pushed
the
14-mig-account_banking_mandate_akretion
branch
from
b1accdc
to
53c7c36
Compare
Ok, but you can make a co-authored commit between both: https://github.blog/2018-01-29-commit-together-with-co-authors/ Also, could you add the This is nitpicking, however, not that important. 😉 |
Replace constrains on company by check_company=True on fields
StefanRijnhart
force-pushed
the
14-mig-account_banking_mandate_akretion
branch
from
53c7c36
to
516eaf2
Compare
StefanRijnhart
force-pushed
the
14-mig-account_banking_mandate_akretion
branch
from
516eaf2
to
1fd22aa
Compare
|
When commits come from several authors, it's not needed to squash them. The squashing activity is for useless administrative commits or commits from same author originated by iterative migration. Merging: /ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Ok, thank you for the explanation 👍
…On Wed, Jan 13, 2021 at 06:09, Pedro M. Baeza ***@***.***> wrote:
When commits come from several authors, it's not needed to squash
them. The squashing activity is for useless administrative commits or
commits from same author originated by iterative migration.
Merging:
/ocabot merge nobump
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#770 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJJMDDUR725AW7DPJEDZ77DSZWSQVANCNFSM4V2EC5IA>.
|
|
Congratulations, your PR was merged at a4e0364. Thanks a lot for contributing to OCA. ❤️ |
|
Oh, I just pushed the coauthored commit but now this one is merged already. Code was identical so it's not a problem. Thanks for the pointer though, @joao-p-marques |
No description provided.