-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] account_statement_import_camt: look for currency under Ntry #460
[IMP] account_statement_import_camt: look for currency under Ntry #460
Conversation
Encountered in a Camt.054 statement: currency listed under /BkToCstmrDbtCdtNtfctn/Ntfctn/Ntry/Amt/@ccy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sebalix those two are independent, this should come on top of that @TeoGoddet from #426 |
I'll have a look at #426 tomorrow to see if it obsoletes this change. |
When I run #426 with the test from this PR, the test fails on
When I apply the single line fix from this PR, all tests succeed again. So the PRs are unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:LGTM
This PR has the |
/ocabot merge patch |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 6c6e545. Thanks a lot for contributing to OCA. ❤️ |
Port to 15: #466 |
Encountered in a Camt.054 statement: currency listed under
/BkToCstmrDbtCdtNtfctn/Ntfctn/Ntry/Amt/@ccy