Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX][business_requirement] Name formating improvement #116

Merged
merged 3 commits into from
Apr 20, 2017
Merged

[FIX][business_requirement] Name formating improvement #116

merged 3 commits into from
Apr 20, 2017

Conversation

victormmtorres
Copy link
Collaborator

To fix #114

@victormmtorres
Copy link
Collaborator Author

@elicoidal @seb-elico

cc @sudhir-serpentcs

@elicoidal elicoidal changed the title [FIX] business_requirement [FIX][business_requirement] Name formating improvement Apr 14, 2017
@elicoidal elicoidal added this to the 8.0 milestone Apr 14, 2017
@elicoidal
Copy link
Contributor

@pedrobaeza @dreispt @seb-elico Let's move forward?

pedrobaeza
pedrobaeza requested changes Apr 17, 2017
View reviewed changes
business_requirement/models/business.py
@@ -251,9 +251,11 @@ def name_get(self):
result = []
for br in self:
if br.ref:
formatted_name = '[{}] {}'.format(br.ref, br.description)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution is to put:

formatted_name = u'[{}] {}'.format(br.ref, br.description)

not to make the other change

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, thanks for review!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Victor Martin added 2 commits April 19, 2017 19:30
Merge branch '8.0' of github.com:OCA/business-requirement into 8.0-Fi…
fb0a54e 
…x-OCA-issues-114-name-get
[FIX] business_requirement
b4fc015 
Fix name_get method as peer code review comments
Need to force string to unicode before replace
@elicoidal
Copy link
Contributor

elicoidal commented Apr 20, 2017 •
edited
Loading

@pedrobaeza your comment is attended so I move forward :). Thanks for the review!

@elicoidal elicoidal merged commit c12bf62 into OCA:8.0 Apr 20, 2017
ruter-lyu pushed a commit to ruter-lyu/business-requirement that referenced this pull request Mar 15, 2019
[FIX][business_requirement] Name formating improvement (OCA#116)
078fbad 
* [FIX] business_requirement
To fix OCA#114

* [FIX] business_requirement
Fix name_get method as peer code review comments
Need to force string to unicode before replace
victormmtorres pushed a commit to Tecnativa/business-requirement that referenced this pull request Jun 4, 2019
[FIX][business_requirement] Name formating improvement (OCA#116)
f707f5b 
* [FIX] business_requirement
To fix OCA#114

* [FIX] business_requirement
Fix name_get method as peer code review comments
Need to force string to unicode before replace
pedrobaeza pushed a commit to Tecnativa/business-requirement that referenced this pull request Jun 21, 2019
@pedrobaeza
[IMP][MIG] business_requirement (OCA#112)
23a8056 
Need to add reponsible and reviewers.
Responsible should be required and populate on upgrade version
Reviewers are users who are involved on the BR process

[FIX][business_requirement] Name formating improvement (OCA#116)

* [FIX] business_requirement
To fix OCA#114

* [FIX] business_requirement
Fix name_get method as peer code review comments
Need to force string to unicode before replace
victormmtorres pushed a commit to Tecnativa/business-requirement that referenced this pull request Jun 26, 2019
[IMP][MIG] business_requirement (OCA#112)
deeda49 
Need to add reponsible and reviewers.
Responsible should be required and populate on upgrade version
Reviewers are users who are involved on the BR process

[FIX][business_requirement] Name formating improvement (OCA#116)

* [FIX] business_requirement
To fix OCA#114

* [FIX] business_requirement
Fix name_get method as peer code review comments
Need to force string to unicode before replace
Tardo pushed a commit to Tecnativa/business-requirement that referenced this pull request Jan 24, 2020
@Tardo
[IMP][MIG] business_requirement (OCA#112)
b5ba877 
Need to add reponsible and reviewers.
Responsible should be required and populate on upgrade version
Reviewers are users who are involved on the BR process

[FIX][business_requirement] Name formating improvement (OCA#116)

* [FIX] business_requirement
To fix OCA#114

* [FIX] business_requirement
Fix name_get method as peer code review comments
Need to force string to unicode before replace
victoralmau pushed a commit to Tecnativa/business-requirement that referenced this pull request Oct 14, 2021
@victoralmau
[IMP][MIG] business_requirement (OCA#112)
76798cb 
Need to add reponsible and reviewers.
Responsible should be required and populate on upgrade version
Reviewers are users who are involved on the BR process

[FIX][business_requirement] Name formating improvement (OCA#116)

* [FIX] business_requirement
To fix OCA#114

* [FIX] business_requirement
Fix name_get method as peer code review comments
Need to force string to unicode before replace
victoralmau pushed a commit to Tecnativa/business-requirement that referenced this pull request Oct 14, 2021
@victoralmau
[IMP][MIG] business_requirement (OCA#112)
dc05be7 
Need to add reponsible and reviewers.
Responsible should be required and populate on upgrade version
Reviewers are users who are involved on the BR process

[FIX][business_requirement] Name formating improvement (OCA#116)

* [FIX] business_requirement
To fix OCA#114

* [FIX] business_requirement
Fix name_get method as peer code review comments
Need to force string to unicode before replace
MosabWadea pushed a commit to MosabWadea/business-requirement that referenced this pull request Mar 5, 2022
@MosabWadea
[IMP][MIG] business_requirement (OCA#112)
077b0ab 
Need to add reponsible and reviewers.
Responsible should be required and populate on upgrade version
Reviewers are users who are involved on the BR process

[FIX][business_requirement] Name formating improvement (OCA#116)

* [FIX] business_requirement
To fix OCA#114

* [FIX] business_requirement
Fix name_get method as peer code review comments
Need to force string to unicode before replace
AntoniRomera pushed a commit to AntoniRomera/business-requirement that referenced this pull request Jul 4, 2023
[IMP][MIG] business_requirement (OCA#112)
1591711 
Need to add reponsible and reviewers.
Responsible should be required and populate on upgrade version
Reviewers are users who are involved on the BR process

[FIX][business_requirement] Name formating improvement (OCA#116)

* [FIX] business_requirement
To fix OCA#114

* [FIX] business_requirement
Fix name_get method as peer code review comments
Need to force string to unicode before replace
NachoAlesLopez pushed a commit to NachoAlesLopez/business-requirement that referenced this pull request Apr 28, 2024
@NachoAlesLopez
[IMP][MIG] business_requirement (OCA#112)
59b05aa 
Need to add reponsible and reviewers.
Responsible should be required and populate on upgrade version
Reviewers are users who are involved on the BR process

[FIX][business_requirement] Name formating improvement (OCA#116)

* [FIX] business_requirement
To fix OCA#114

* [FIX] business_requirement
Fix name_get method as peer code review comments
Need to force string to unicode before replace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza requested changes

@elicoidal elicoidal elicoidal approved these changes

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@victormmtorres @elicoidal @pedrobaeza