[ADD][br_deliverable] move the estimation pricelist from the project to the customer #117

victormmtorres · 2017-04-14T04:29:54Z

Improve customer model to add additional pricelist for estimations

oca-clabot · 2017-04-14T04:29:57Z

Hey @victormartinelicocorp, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

Victor Martin (no github login found)

Appreciation of efforts,
OCA CLAbot

victormmtorres · 2017-04-14T04:39:35Z

@elicoidal @seb-elico this is for the pricelist estimation

Others is weird that ask me to sign again my CLA. What should I do?

elicoidal · 2017-04-14T05:59:35Z

@jbeficent Any idea about the CLA?

elicoidal · 2017-04-14T06:00:30Z

business_requirement_deliverable/models/res_partner.py

+class ResPartner(models.Model):
+    _inherit = 'res.partner'
+
+    pricelist_id = fields.Many2one(


should not this be a property (like customer pricelists)?

s/pricelist_id/estimation_pricelist_id

@victormartinelicocorp I remember you told me the Sales Pricelist was a computed field. Reason is: when the partner is a contact of a company, his Sales Pricelist is the one from his company. As discussed, we should replicate this behavior.

EDIT: after checking with @elicoidal, we are looking for a slightly different behavior for the estimation pricelist. For the contacts, the sales pricelist is "inherited": it comes from their parent res_partner (e.g. their company). For the estimation pricelist, we don't need to implement this "heritage". But, in multi-company context, we need to be able to define different estimation pricelists for a customer when we work on different companies, this is what @elicoidal means by property (it's a "dynamic" field that can have different value based on the current company).

@victormartinelicocorp To be discussed

elicoidal · 2017-04-14T06:00:53Z

business_requirement_deliverable/models/res_partner.py

+        comodel_name='product.pricelist',
+        domain=[('type', '=', 'sale')],
+        help='''Pricelist used for the estimation of the Business Requirements
+        Deliverables linked to this project.


remove "Linked to this project"

elicoidal

What about the pricelist calculation methods in the deliverable lines?

elicoidal · 2017-04-16T00:56:34Z

business_requirement_deliverable/models/res_partner.py

+class ResPartner(models.Model):
+    _inherit = 'res.partner'
+
+    pricelist_id = fields.Many2one(


s/pricelist_id/estimation_pricelist_id

elicoidal · 2017-04-16T01:05:51Z

I am thinking that we should maybe think about migration script but it is complex (cross module).
Nevertheless what I would least do is add a remark in both modules README (Known Issues/Roadmap) that
"As of version 8.0.5.0.0, the estimation pricelist has been moved from Project to Partner object. There is no migration script for the change and the data will have to be migrated manually"

elicoidal · 2017-04-16T01:06:43Z

business_requirement_deliverable/__openerp__.py

@@ -6,7 +6,7 @@
    'category': 'Business Requirements Management',
    'summary': 'Manage the Business Requirement Deliverables and \
                Resources for your customers',
-    'version': '8.0.4.0.0',
+    'version': '8.0.4.0.1',


I think we should bump to 8.0.5.0.0 because this modules implies a manual migration of the data

seb-elico · 2017-04-17T11:59:37Z

business_requirement_deliverable/models/res_partner.py

+class ResPartner(models.Model):
+    _inherit = 'res.partner'
+
+    pricelist_id = fields.Many2one(


@victormartinelicocorp I remember you told me the Sales Pricelist was a computed field. Reason is: when the partner is a contact of a company, his Sales Pricelist is the one from his company. As discussed, we should replicate this behavior.

EDIT: after checking with @elicoidal, we are looking for a slightly different behavior for the estimation pricelist. For the contacts, the sales pricelist is "inherited": it comes from their parent res_partner (e.g. their company). For the estimation pricelist, we don't need to implement this "heritage". But, in multi-company context, we need to be able to define different estimation pricelists for a customer when we work on different companies, this is what @elicoidal means by property (it's a "dynamic" field that can have different value based on the current company).

elicoidal · 2017-04-18T01:06:29Z

I am thinking that we should maybe think about migration script but it is complex (cross module).
Nevertheless what I would least do is add a remark in both modules README (Known Issues/Roadmap) that
"As of version 8.0.5.0.0, the estimation pricelist has been moved from Project to Partner object. There is no migration script for the change and the data will have to be migrated manually"

@victormartinelicocorp
done

elicoidal · 2017-04-18T01:09:25Z

@victormartinelicocorp if you can fix this one we can merge it

victormmtorres · 2017-04-19T04:50:56Z

@victormartinelicocorp if you can fix this one we can merge it

@elicoidal I'll try to use 2 hours at end of day if I couldn't dedicate this time I let you know

seb-elico · 2017-04-21T11:08:12Z

Here is a list of the users:
Victor Martin (no github login found)

Others is weird that ask me to sign again my CLA. What should I do?

@victormartinelicocorp It's very strange indeed, it looks like the OCA CLA bot didn't detect your GitHub login. This is probably the root cause of this error...

@jbeficent What to you think?

Propery on new API is mean company dependent

Add company dependent (property) pricelist for estimation

victormmtorres · 2017-04-26T07:09:28Z

The remark on known issues is added and also now is company dependent.

@elicoidal @seb-elico Could you review?

elicoidal · 2017-04-26T07:17:59Z

@seb-elico @dreispt @pedrobaeza I think we can move forward

dreispt

Other than a couple of nitpicks, LGTM

dreispt · 2017-04-26T08:09:32Z

business_requirement_deliverable/README.rst

@@ -16,6 +16,9 @@ Two new concepts complement the main business requirements model:
 * Deliverable lines
 * Resource lines

+A new field for pricelist estimation has been added to the partner to be used in the Deliverable
+lines and Resources lines.


Since we are describing the module features, instead of "has been added" I would rather say "is available".

dreispt · 2017-04-26T08:10:57Z

business_requirement_deliverable/models/res_partner.py

+        company_dependent=True,
+        help='''Pricelist used for the estimation of the Business Requirements
+        Deliverables linked to this project.
+        Currency of the Deliverables will be the one from this pricelist.''')


Prefer using triple double quotes instead of triple single quotes.

elicoidal · 2017-04-27T01:56:02Z

@dreispt I corrected the README and quotes. I move forward :)

…to the customer (OCA#117) * [IMP] business_requirement_deliverable Improve customer model to add additional pricelist for estimations * Update README.rst * Bumped version number * [ADD] business_requirement_deliverable Propery on new API is mean company dependent * [ADD] business_requirement_deliverable Add company dependent (property) pricelist for estimation * Refreshed the README * Removed the single quotes

[IMP] business_requirement_deliverable

712d1a8

Improve customer model to add additional pricelist for estimations

victormmtorres mentioned this pull request Apr 14, 2017

[RM][br_deliverable_cost] remove the estimation pricelist from the project (=>customer) #118

Merged

elicoidal reviewed Apr 14, 2017

View reviewed changes

elicoidal added the needs fixing label Apr 14, 2017

elicoidal changed the title ~~[IMP] business_requirement_deliverable~~ [IMP][br_deliverable] move the estimation pricelist from the project to the customer Apr 16, 2017

elicoidal suggested changes Apr 16, 2017

View reviewed changes

elicoidal reviewed Apr 16, 2017

View reviewed changes

seb-elico suggested changes Apr 17, 2017

View reviewed changes

elicoidal added 2 commits April 18, 2017 09:05

Update README.rst

841373b

Bumped version number

9d96063

[ADD] business_requirement_deliverable

2f0b236

Propery on new API is mean company dependent

victormmtorres changed the title ~~[IMP][br_deliverable] move the estimation pricelist from the project to the customer~~ [WIP][br_deliverable] move the estimation pricelist from the project to the customer Apr 25, 2017

elicoidal added this to the 8.0 milestone Apr 26, 2017

[ADD] business_requirement_deliverable

53be9cd

Add company dependent (property) pricelist for estimation

victormmtorres changed the title ~~[WIP][br_deliverable] move the estimation pricelist from the project to the customer~~ [ADD][br_deliverable] move the estimation pricelist from the project to the customer Apr 26, 2017

elicoidal approved these changes Apr 26, 2017

View reviewed changes

elicoidal added needs review and removed needs fixing labels Apr 26, 2017

dreispt reviewed Apr 26, 2017

View reviewed changes

Refreshed the README

5e9e71b

Removed the single quotes

2231dc1

elicoidal merged commit 104e840 into OCA:8.0 Apr 27, 2017

dreispt mentioned this pull request Apr 27, 2024

[15.0][MIG] business_requirement_deliverable: Migration to 15.0 #380

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD][br_deliverable] move the estimation pricelist from the project to the customer #117

[ADD][br_deliverable] move the estimation pricelist from the project to the customer #117

victormmtorres commented Apr 14, 2017

oca-clabot commented Apr 14, 2017

victormmtorres commented Apr 14, 2017

elicoidal commented Apr 14, 2017

elicoidal Apr 14, 2017

elicoidal Apr 16, 2017

seb-elico Apr 17, 2017 •

edited

elicoidal Apr 20, 2017

elicoidal Apr 14, 2017

elicoidal left a comment

elicoidal Apr 16, 2017

elicoidal commented Apr 16, 2017 •

edited

elicoidal Apr 16, 2017

seb-elico Apr 17, 2017 •

edited

elicoidal commented Apr 18, 2017

elicoidal commented Apr 18, 2017

victormmtorres commented Apr 19, 2017

seb-elico commented Apr 21, 2017

victormmtorres commented Apr 26, 2017

elicoidal commented Apr 26, 2017

dreispt left a comment

dreispt Apr 26, 2017

dreispt Apr 26, 2017

elicoidal commented Apr 27, 2017

[ADD][br_deliverable] move the estimation pricelist from the project to the customer #117

[ADD][br_deliverable] move the estimation pricelist from the project to the customer #117

Conversation

victormmtorres commented Apr 14, 2017

oca-clabot commented Apr 14, 2017

victormmtorres commented Apr 14, 2017

elicoidal commented Apr 14, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

seb-elico Apr 17, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elicoidal left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elicoidal commented Apr 16, 2017 • edited

Choose a reason for hiding this comment

seb-elico Apr 17, 2017 • edited

Choose a reason for hiding this comment

elicoidal commented Apr 18, 2017

elicoidal commented Apr 18, 2017

victormmtorres commented Apr 19, 2017

seb-elico commented Apr 21, 2017

victormmtorres commented Apr 26, 2017

elicoidal commented Apr 26, 2017

dreispt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elicoidal commented Apr 27, 2017

seb-elico Apr 17, 2017 •

edited

elicoidal commented Apr 16, 2017 •

edited

seb-elico Apr 17, 2017 •

edited