Business requirement deliverable report #15
Conversation
|
Hey @RawEvan, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
|
@RawEvan Can you please make sure Travis is Green? |
|
I have fixed the CLA (you are currently covered by the company CLA) |
RawEvan
changed the title
|
@elicoidal The Travis is green now. |
…x some syntax errors of missing newline
RawEvan
force-pushed
the
business_requirement_deliverable_report
branch
from
6caeac3
to
daf6c19
Compare
…hich the page number is fixed
|
@elicoidal It has been rebased, and the bug of the page number is fixed. |
|
please increase coverage. |
|
@RawEvan not bad!
Other than that LGTM: good job |
|
@RawEvan One other thing: can we reduce the space at the top of the document? (between header and the BR number) |
|
@elicoidal Yes, the space can be reduced, and the details above are also working in progress. |
|
@RawEvan Don't forgot about increase or maintain coverall. |
…uce the space under the header, change the precision, right justfied some columns, delete unnecessary py files
|
@elicoidal The report is updated including the 5 details that you proposed except the decimal accuracy for quantity (but the decimal accuracy of price is OK now). |
|
only modification and then we can merge. Add "Business Requirement Document" in the first line before the sequence. |
…in...' which is unnecessary and leads to a bug when creating report for multi BRs
|
@dreispt @pedrobaeza can we merge this one? |
| Introduction | ||
| ^^^^^^^^^^^^ | ||
|
|
||
| This module is part of a set ("Business Requirement"). |
There was a problem hiding this comment.
I think this generic description should be in the main module, but not copied on each submodule. You can put something like: Refer to the documentation on the main module to know what is a business requirement.
There was a problem hiding this comment.
No problem: I will adapt the README accordingly.
I miss some place in our website to gather the documentation...
|
If this is ready for review please remove the WIP from the title. |
| 'static/img/bus_req_report1.png', | ||
| 'static/img/bus_req_report2.png', | ||
| 'static/img/bus_req_report3.png', | ||
| ], |
There was a problem hiding this comment.
As per Pedro's comment, keep only what is specifically relevant for this module features. You should remove images that don't illustrate features implemented here.
|
Looks good, once comments are fixed. |
|
@pedrobaeza @dreispt thanks for the review. We will amend accordingly |
Updated the name/summary+removed unnecessary images
Remove the repeated introduction in README
…es and paper format
RawEvan
changed the title
|
@elicoidal @pedrobaeza @dreispt It's fixed. |
|
👍 |
|
👍 |
|
Please squash your commits by author and I'll merge. |
|
@RawEvan Please proceed with squash |
|
@elicoidal "Squash and Merge" gives authorship to the last commiter, so it should be fine. I'm merging. |
Remove useless introduction from README.rst
The report module for business requirement using Qweb.
Depends on:
It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:
Appreciation of efforts,
OCA CLAbot
Coverage decreased (-5.07%) to 85.356% when pulling dd3c649 on RawEvan:business_requirement_deliverable_report into 40cb2a0 on OCA:8.0.
Coverage decreased (-4.0%) to 86.441% when pulling 6caeac3 on RawEvan:business_requirement_deliverable_report into 40cb2a0 on OCA:8.0.
Coverage decreased (-3.9%) to 86.722% when pulling daf6c19 on RawEvan:business_requirement_deliverable_report into 8442e3f on OCA:8.0.
Coverage decreased (-3.9%) to 86.722% when pulling 5b47584 on RawEvan:business_requirement_deliverable_report into 8442e3f on OCA:8.0.
I wil test in runbot
Coverage decreased (-3.9%) to 86.722% when pulling 5c5a0e1 on RawEvan:business_requirement_deliverable_report into 8442e3f on OCA:8.0.
Some details:
Other than that LGTM: good job
Coverage remained the same at 90.654% when pulling 1c3a8f2 on RawEvan:business_requirement_deliverable_report into 8442e3f on OCA:8.0.
@victormartinelicocorp The coverall is maintained now, thanks for your reminding.
other than that, LGTM
Coverage remained the same at 90.654% when pulling 1716e2d on RawEvan:business_requirement_deliverable_report into 8442e3f on OCA:8.0.
Coverage remained the same at 90.654% when pulling a52fdd8 on RawEvan:business_requirement_deliverable_report into 8442e3f on OCA:8.0.
Coverage remained the same at 90.654% when pulling 1d22434 on RawEvan:business_requirement_deliverable_report into 8442e3f on OCA:8.0.
Coverage remained the same at 90.654% when pulling aa6505c on RawEvan:business_requirement_deliverable_report into 8442e3f on OCA:8.0.
Coverage increased (+0.3%) to 90.991% when pulling b22ba7a on RawEvan:business_requirement_deliverable_report into 8442e3f on OCA:8.0.
Coverage increased (+0.3%) to 90.991% when pulling b22ba7a on RawEvan:business_requirement_deliverable_report into 8442e3f on OCA:8.0.
Coverage increased (+0.3%) to 90.991% when pulling e6aaccd on RawEvan:business_requirement_deliverable_report into 8442e3f on OCA:8.0.
@pedrobaeza @dreispt can we merge this one?
Refer to the documentation on the main module to know what is a business requirement.I miss some place in our website to gather the documentation...