Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0] Issue-161 Kanban state editable #169

Merged
merged 1 commit into from
Jun 8, 2017
Merged

[8.0] Issue-161 Kanban state editable #169

merged 1 commit into from
Jun 8, 2017

Conversation

serpentcs-dev1
Copy link
Member

@serpentcs-dev1 serpentcs-dev1 commented Jun 6, 2017 •
edited

This PR resolves the Kanban State issue #161 to make it editable from the form view of BR.

This is the simple workaround which moves the kanban_state field from the inherited br_project form view to the BR module main view (as for some reason it was not able to edit the field in inherited form view)

P.S: Need to find a more logical way

elicoidal
elicoidal reviewed Jun 6, 2017
View reviewed changes
Copy link
Contributor

@elicoidal elicoidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ideal but I understand the workaround
@pedrobaeza @dreispt this is to answer #161

Anything we are missing?

dreispt
dreispt approved these changes Jun 7, 2017
View reviewed changes
Copy link
Sponsor Member

@dreispt dreispt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dreispt
Copy link
Sponsor Member

dreispt commented Jun 7, 2017

AFAICS it makes sense for all Stage/Sate/Kanvban State fields to be defined in business_requirement instead of business_requirement_deliverable_project.

@elicoidal
Copy link
Contributor

@dreispt Thanks for the follow up.
Merging

@elicoidal elicoidal merged commit 3e258d8 into OCA:8.0 Jun 8, 2017
ruter-lyu pushed a commit to ruter-lyu/business-requirement that referenced this pull request Mar 15, 2019
@serpentcs-dev1
[FIX] kanban state editable in BR (OCA#169)
03debbd
ruter-lyu pushed a commit to ruter-lyu/business-requirement that referenced this pull request Mar 22, 2019
@serpentcs-dev1
[FIX] kanban state editable in BR (OCA#169)
3e900ad
victormmtorres pushed a commit to Tecnativa/business-requirement that referenced this pull request Jun 4, 2019
@serpentcs-dev1
[FIX] kanban state editable in BR (OCA#169)
e36bfa8
pedrobaeza pushed a commit to Tecnativa/business-requirement that referenced this pull request Jun 21, 2019
@serpentcs-dev1 @pedrobaeza
[FIX]144 In stages missing the stage drop (OCA#165)
9c0284c 
[IMP]Improved BR-fields position (OCA#166)

* [IMP]Improved BR-fields position

* exchanged requested and responsible

[IMP]default sort on BR list (OCA#167)

[FIX] kanban state editable in BR (OCA#169)

[IMP][BR1030][22333]-Modify layout of BR Form view (OCA#210)
victormmtorres pushed a commit to Tecnativa/business-requirement that referenced this pull request Jun 26, 2019
@serpentcs-dev1
[FIX]144 In stages missing the stage drop (OCA#165)
751c801 
[IMP]Improved BR-fields position (OCA#166)

* [IMP]Improved BR-fields position

* exchanged requested and responsible

[IMP]default sort on BR list (OCA#167)

[FIX] kanban state editable in BR (OCA#169)

[IMP][BR1030][22333]-Modify layout of BR Form view (OCA#210)
Tardo pushed a commit to Tecnativa/business-requirement that referenced this pull request Jan 24, 2020
@serpentcs-dev1 @Tardo
[FIX]144 In stages missing the stage drop (OCA#165)
4ee4d9b 
[IMP]Improved BR-fields position (OCA#166)

* [IMP]Improved BR-fields position

* exchanged requested and responsible

[IMP]default sort on BR list (OCA#167)

[FIX] kanban state editable in BR (OCA#169)

[IMP][BR1030][22333]-Modify layout of BR Form view (OCA#210)
victoralmau pushed a commit to Tecnativa/business-requirement that referenced this pull request Oct 14, 2021
@serpentcs-dev1 @victoralmau
[FIX]144 In stages missing the stage drop (OCA#165)
8b47577 
[IMP]Improved BR-fields position (OCA#166)

* [IMP]Improved BR-fields position

* exchanged requested and responsible

[IMP]default sort on BR list (OCA#167)

[FIX] kanban state editable in BR (OCA#169)

[IMP][BR1030][22333]-Modify layout of BR Form view (OCA#210)
victoralmau pushed a commit to Tecnativa/business-requirement that referenced this pull request Oct 14, 2021
@serpentcs-dev1 @victoralmau
[FIX]144 In stages missing the stage drop (OCA#165)
4e8fceb 
[IMP]Improved BR-fields position (OCA#166)

* [IMP]Improved BR-fields position

* exchanged requested and responsible

[IMP]default sort on BR list (OCA#167)

[FIX] kanban state editable in BR (OCA#169)

[IMP][BR1030][22333]-Modify layout of BR Form view (OCA#210)
MosabWadea pushed a commit to MosabWadea/business-requirement that referenced this pull request Mar 5, 2022
@serpentcs-dev1 @MosabWadea
[FIX]144 In stages missing the stage drop (OCA#165)
d72841a 
[IMP]Improved BR-fields position (OCA#166)

* [IMP]Improved BR-fields position

* exchanged requested and responsible

[IMP]default sort on BR list (OCA#167)

[FIX] kanban state editable in BR (OCA#169)

[IMP][BR1030][22333]-Modify layout of BR Form view (OCA#210)
AntoniRomera pushed a commit to AntoniRomera/business-requirement that referenced this pull request Jul 4, 2023
@serpentcs-dev1
[FIX]144 In stages missing the stage drop (OCA#165)
1e71e32 
[IMP]Improved BR-fields position (OCA#166)

* [IMP]Improved BR-fields position

* exchanged requested and responsible

[IMP]default sort on BR list (OCA#167)

[FIX] kanban state editable in BR (OCA#169)

[IMP][BR1030][22333]-Modify layout of BR Form view (OCA#210)
NachoAlesLopez pushed a commit to NachoAlesLopez/business-requirement that referenced this pull request Apr 28, 2024
@serpentcs-dev1 @NachoAlesLopez
[FIX]144 In stages missing the stage drop (OCA#165)
ccdd684 
[IMP]Improved BR-fields position (OCA#166)

* [IMP]Improved BR-fields position

* exchanged requested and responsible

[IMP]default sort on BR list (OCA#167)

[FIX] kanban state editable in BR (OCA#169)

[IMP][BR1030][22333]-Modify layout of BR Form view (OCA#210)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elicoidal elicoidal elicoidal left review comments

@dreispt dreispt dreispt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@serpentcs-dev1 @dreispt @elicoidal