[IMP] business_requirement: Improvement on master project related to BR. #17

victormmtorres · 2016-08-31T08:13:46Z

modified: business_requirement/openerp.py
modified: business_requirement/models/init.py
new file: business_requirement/models/project.py
new file: business_requirement/views/project.xml

General Comment
<img border=0 src='https://avatars.githubusercontent.com/u/2354108?v=3' height=16 width=16'>
Coverage decreased (-0.1%) to 90.541% when pulling 3e3d786 on victormartinelicocorp:8.0-business-requirement-improvement-on-master-project-related into 8442e3f on OCA:8.0.
<img border=0 src='https://avatars.githubusercontent.com/u/2354108?v=3' height=16 width=16'>
Coverage increased (+0.3%) to 90.991% when pulling 3244b3c on victormartinelicocorp:8.0-business-requirement-improvement-on-master-project-related into 8442e3f on OCA:8.0.
<img border=0 src='https://avatars.githubusercontent.com/u/16461806?v=3' height=16 width=16'> @elicoidal
<img border=0 src='https://avatars.githubusercontent.com/u/7600613?v=3' height=16 width=16'> 👍
<img border=0 src='https://avatars.githubusercontent.com/u/16461806?v=3' height=16 width=16'> @dreispt Could review?
<img border=0 src='https://avatars.githubusercontent.com/u/2354108?v=3' height=16 width=16'>
Coverage increased (+0.3%) to 90.991% when pulling 72f8d99 on victormartinelicocorp:8.0-business-requirement-improvement-on-master-project-related into 8442e3f on OCA:8.0.
<img border=0 src='https://avatars.githubusercontent.com/u/16461806?v=3' height=16 width=16'> @elicoidal @seb-elico
<img border=0 src='https://avatars.githubusercontent.com/u/7600613?v=3' height=16 width=16'> 👍
<img border=0 src='https://avatars.githubusercontent.com/u/16461806?v=3' height=16 width=16'> > Since you added new fields, the model needs to be upgraded, right? In that case, version should be 8.0.5.1.0 if I'm correct
@seb-elico right.
Please review.
<img border=0 src='https://avatars.githubusercontent.com/u/2354108?v=3' height=16 width=16'>
Coverage increased (+0.3%) to 90.991% when pulling a886d76 on victormartinelicocorp:8.0-business-requirement-improvement-on-master-project-related into 8442e3f on OCA:8.0.
<img border=0 src='https://avatars.githubusercontent.com/u/2354108?v=3' height=16 width=16'>
Coverage increased (+0.3%) to 90.991% when pulling 4325d1f on victormartinelicocorp:8.0-business-requirement-improvement-on-master-project-related into 8442e3f on OCA:8.0.
<img border=0 src='https://avatars.githubusercontent.com/u/16461806?v=3' height=16 width=16'> @seb-elico
<img border=0 src='https://avatars.githubusercontent.com/u/10879075?v=3' height=16 width=16'> 👍
<img border=0 src='https://avatars.githubusercontent.com/u/7600613?v=3' height=16 width=16'> @dreispt @pedrobaeza can we merge this one?
<img border=0 src='https://avatars.githubusercontent.com/u/6644187?v=3' height=16 width=16'> 👍
<img border=0 src='https://avatars.githubusercontent.com/u/7600613?v=3' height=16 width=16'> @moylop260 thanks for the review :)
File: business_requirement/views/project.xml:L1-44
<img border=0 src='https://avatars.githubusercontent.com/u/10879075?v=3' height=16 width=16'> s/Business Requirement/Business Requirement(s)
File: business_requirement/models/project.py:L1-26
<img border=0 src='https://avatars.githubusercontent.com/u/10879075?v=3' height=16 width=16'> s/Business Requirement/Business Requirements/
File: business_requirement/models/project.py:L1-26
<img border=0 src='https://avatars.githubusercontent.com/u/10879075?v=3' height=16 width=16'> s/Business Requirement Number/Number of Business Requirements or Business Requirements count/
<img border=0 src='https://avatars.githubusercontent.com/u/7600613?v=3' height=16 width=16'> Number of Business Requirements
File: business_requirement/views/project.xml:L1-44
<img border=0 src='https://avatars.githubusercontent.com/u/10879075?v=3' height=16 width=16'> Line too long, please fix it!
File: business_requirement/views/project.xml:L1-44
<img border=0 src='https://avatars.githubusercontent.com/u/10879075?v=3' height=16 width=16'> Line too long, please fix it!
File: business_requirement/views/project.xml:L1-44
<img border=0 src='https://avatars.githubusercontent.com/u/10879075?v=3' height=16 width=16'> Add a space after ,
File: business_requirement/openerp.py:L5-12
<img border=0 src='https://avatars.githubusercontent.com/u/10879075?v=3' height=16 width=16'> Since you added new fields, the model needs to be upgraded, right? In that case, version should be 8.0.5.1.0 if I'm correct
File: business_requirement/views/project.xml:L1-52
<img border=0 src='https://avatars.githubusercontent.com/u/10879075?v=3' height=16 width=16'> Please use " for attributes. And put position on the next line
File: business_requirement/views/project.xml:L1-52
<img border=0 src='https://avatars.githubusercontent.com/u/10879075?v=3' height=16 width=16'> Use " for attributes

modified: business_requirement/__openerp__.py modified: business_requirement/models/__init__.py new file: business_requirement/models/project.py new file: business_requirement/views/project.xml

coveralls · 2016-08-31T08:19:21Z

Coverage decreased (-0.1%) to 90.541% when pulling 3e3d786 on victormartinelicocorp:8.0-business-requirement-improvement-on-master-project-related into 8442e3f on OCA:8.0.

…nherited. modified: business_requirement/tests/__init__.py new file: business_requirement/tests/test_project.py

coveralls · 2016-08-31T10:25:10Z

Coverage increased (+0.3%) to 90.991% when pulling 3244b3c on victormartinelicocorp:8.0-business-requirement-improvement-on-master-project-related into 8442e3f on OCA:8.0.

coveralls · 2016-08-31T10:25:10Z

Coverage increased (+0.3%) to 90.991% when pulling 3244b3c on victormartinelicocorp:8.0-business-requirement-improvement-on-master-project-related into 8442e3f on OCA:8.0.

victormmtorres · 2016-08-31T10:46:30Z

@elicoidal

elicoidal · 2016-08-31T11:19:43Z

👍

victormmtorres · 2016-09-01T01:49:11Z

@dreispt Could review?

seb-elico · 2016-09-05T05:10:36Z

business_requirement/views/project.xml

+                <xpath expr='//div[@class="oe_kanban_content"]/div[@class="oe_kanban_project_list"]' position="inside">
+                    <div class="oe_kanban_project_list">
+                        <a t-if="record.br_count.raw_value" name="%(act_view_project_br_all)d" type="action" style="margin-right: 10px">
+                            <field name="br_count"/> Business Requirement


s/Business Requirement/Business Requirement(s)

…l files. modified: business_requirement/models/project.py modified: business_requirement/views/project.xml

coveralls · 2016-09-05T08:35:48Z

Coverage increased (+0.3%) to 90.991% when pulling 72f8d99 on victormartinelicocorp:8.0-business-requirement-improvement-on-master-project-related into 8442e3f on OCA:8.0.

coveralls · 2016-09-05T08:35:48Z

Coverage increased (+0.3%) to 90.991% when pulling 72f8d99 on victormartinelicocorp:8.0-business-requirement-improvement-on-master-project-related into 8442e3f on OCA:8.0.

victormmtorres · 2016-09-05T08:42:26Z

@elicoidal @seb-elico

elicoidal · 2016-09-05T08:56:35Z

👍

seb-elico · 2016-09-05T08:57:45Z

business_requirement/__openerp__.py

@@ -5,7 +5,7 @@
    'name': 'Business Requirement',
    'category': 'Business Requirements Management',
    'summary': 'Business Requirement',
-    'version': '8.0.5.0.0',
+    'version': '8.0.5.0.1',


Since you added new fields, the model needs to be upgraded, right? In that case, version should be 8.0.5.1.0 if I'm correct

modified: business_requirement/__openerp__.py

victormmtorres · 2016-09-05T09:49:47Z

Since you added new fields, the model needs to be upgraded, right? In that case, version should be 8.0.5.1.0 if I'm correct

@seb-elico right.
Please review.

coveralls · 2016-09-05T09:55:57Z

Coverage increased (+0.3%) to 90.991% when pulling a886d76 on victormartinelicocorp:8.0-business-requirement-improvement-on-master-project-related into 8442e3f on OCA:8.0.

seb-elico · 2016-09-05T10:39:40Z

business_requirement/views/project.xml

+            <field name="model">project.project</field>
+            <field name="inherit_id" ref="project.view_project_kanban"/>
+            <field name="arch" type="xml">
+                <xpath expr='//div[@class="oe_kanban_content"]/div[@class="oe_kanban_project_list"]' position="inside">


Please use " for attributes. And put position on the next line

modified: business_requirement/views/project.xml

coveralls · 2016-09-05T10:58:08Z

Coverage increased (+0.3%) to 90.991% when pulling 4325d1f on victormartinelicocorp:8.0-business-requirement-improvement-on-master-project-related into 8442e3f on OCA:8.0.

victormmtorres · 2016-09-05T11:02:23Z

@seb-elico

seb-elico · 2016-09-06T07:43:50Z

👍

elicoidal · 2016-09-09T01:48:08Z

@dreispt @pedrobaeza can we merge this one?

moylop260 · 2016-09-09T01:58:59Z

👍

elicoidal · 2016-09-09T02:05:07Z

@moylop260 thanks for the review :)

…BR. (OCA#17) * [IMP] business_requirement: Improvement on master project related to BR. modified: business_requirement/__openerp__.py modified: business_requirement/models/__init__.py new file: business_requirement/models/project.py new file: business_requirement/views/project.xml * [FIX] business_requirement: Increase Coverall regards the new model inherited. modified: business_requirement/tests/__init__.py new file: business_requirement/tests/test_project.py * [FIX] business_requirement: Modify style and format for python and xml files. modified: business_requirement/models/project.py modified: business_requirement/views/project.xml * [FIX] business_requirement: Fix version number. modified: business_requirement/__openerp__.py * [FIX] business_requirement: Fix format on XML attributes for views. modified: business_requirement/views/project.xml

[IMP] business_requirement: Improvement on master project related to BR.

3e3d786

modified: business_requirement/__openerp__.py modified: business_requirement/models/__init__.py new file: business_requirement/models/project.py new file: business_requirement/views/project.xml

[FIX] business_requirement: Increase Coverall regards the new model i…

3244b3c

…nherited. modified: business_requirement/tests/__init__.py new file: business_requirement/tests/test_project.py

elicoidal added the Needs Review label Aug 31, 2016

seb-elico reviewed Sep 5, 2016
View reviewed changes

[FIX] business_requirement: Modify style and format for python and xm…

72f8d99

…l files. modified: business_requirement/models/project.py modified: business_requirement/views/project.xml

seb-elico reviewed Sep 5, 2016
View reviewed changes

[FIX] business_requirement: Fix version number.

a886d76

modified: business_requirement/__openerp__.py

seb-elico reviewed Sep 5, 2016
View reviewed changes

[FIX] business_requirement: Fix format on XML attributes for views.

4325d1f

modified: business_requirement/views/project.xml

moylop260 merged commit a3c927c into OCA:8.0 Sep 9, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IMP] business_requirement: Improvement on master project related to BR. #17

[IMP] business_requirement: Improvement on master project related to BR. #17

victormmtorres commented Aug 31, 2016 •

edited by dreispt

coveralls commented Aug 31, 2016 •

edited

coveralls commented Aug 31, 2016

coveralls commented Aug 31, 2016

victormmtorres commented Aug 31, 2016

elicoidal commented Aug 31, 2016

victormmtorres commented Sep 1, 2016

seb-elico Sep 5, 2016

coveralls commented Sep 5, 2016

coveralls commented Sep 5, 2016

victormmtorres commented Sep 5, 2016

elicoidal commented Sep 5, 2016

seb-elico Sep 5, 2016

victormmtorres commented Sep 5, 2016

coveralls commented Sep 5, 2016 •

edited

seb-elico Sep 5, 2016

coveralls commented Sep 5, 2016 •

edited

victormmtorres commented Sep 5, 2016

seb-elico commented Sep 6, 2016

elicoidal commented Sep 9, 2016

moylop260 commented Sep 9, 2016

elicoidal commented Sep 9, 2016

[IMP] business_requirement: Improvement on master project related to BR. #17

[IMP] business_requirement: Improvement on master project related to BR. #17

Conversation

victormmtorres commented Aug 31, 2016 • edited by dreispt

coveralls commented Aug 31, 2016 • edited

coveralls commented Aug 31, 2016

coveralls commented Aug 31, 2016

victormmtorres commented Aug 31, 2016

elicoidal commented Aug 31, 2016

victormmtorres commented Sep 1, 2016

seb-elico Sep 5, 2016

Choose a reason for hiding this comment

coveralls commented Sep 5, 2016

coveralls commented Sep 5, 2016

victormmtorres commented Sep 5, 2016

elicoidal commented Sep 5, 2016

seb-elico Sep 5, 2016

Choose a reason for hiding this comment

victormmtorres commented Sep 5, 2016

coveralls commented Sep 5, 2016 • edited

seb-elico Sep 5, 2016

Choose a reason for hiding this comment

coveralls commented Sep 5, 2016 • edited

victormmtorres commented Sep 5, 2016

seb-elico commented Sep 6, 2016

elicoidal commented Sep 9, 2016

moylop260 commented Sep 9, 2016

elicoidal commented Sep 9, 2016

victormmtorres commented Aug 31, 2016 •

edited by dreispt

coveralls commented Aug 31, 2016 •

edited

coveralls commented Sep 5, 2016 •

edited

coveralls commented Sep 5, 2016 •

edited