[IMP][8.0][22070][ISSUE#115]-Modify projects and BR id relationship #192

serpentcs-dev1 · 2017-06-29T12:10:51Z

Issue #115

Added Smart button Linked Project.
Added two fields business_requirement_id and business_requirement_deliverable_id in project.project.
Make invisible linked_project field form BR.
Made read-only field for_br while generated projects wizard is open.

@seb-elico @elicoidal @victormartinelicocorp

elicoidal · 2017-06-30T01:50:54Z

@darshan-serpent thanks for the contribution.
I made a test with one BR, 2 deliverables and created the projects from both BR + deliverables:

In created project: cannot use the BR smart button to display the linked BR (nothing listed)
in original BR, Linked Project smart button only shows the project directly linked to the BR, not the ones linked to deliverables (expected shows all projects linked to the BR and its deliverable)

Rest looks good but I still need a test on BR with sub-BR
cc @seb-elico @victormartinelicocorp

elicoidal · 2017-06-30T02:42:07Z

Test with Children project are similar to the one with Deliverables

Problem while copying:

when copying a BR, the copied BR is still linked to the project of the initial BR (??)

serpentcs-dev1 · 2017-06-30T07:37:46Z

@elicoidal Regarding creating projects from Deliverables.

I am not really sure how to create a project from deliverables, can you please describe it in brief?!

elicoidal · 2017-07-07T01:11:38Z

@darshan-serpent What is the situation on this BR?

elicoidal · 2017-07-10T03:28:32Z

@darshan-serpent @sudhir-serpentcs What is the situation here?

serpentcs-dev1 · 2017-07-10T03:45:56Z

@elicoidal There's still some confusion here, I'll let you know the details soon of current situation.

…o 8.0-22070-Issue-115-link_with_generated_projects

YogeshMahera-SerpentCS · 2017-07-10T12:29:42Z

@elicoidal @victormartinelicocorp
Could you please review it.

elicoidal · 2017-07-11T10:03:08Z

Small details:

in smart button BR in project: the number of BR should not be displayed (a project can only be linked to one BR at a time)
in BR "Linked Project" should display the number of linked project.

Rest looks OK!

elicoidal · 2017-07-11T10:03:15Z

@victormartinelicocorp

…veriable from project

victormmtorres

Others LGTM

victormmtorres · 2017-07-11T10:52:49Z

business_requirement_deliverable_project/models/business.py

@@ -43,6 +44,22 @@ def generate_projects_wizard(self):
        compute='_compute_planned_hour'
    )

+    @api.multi
+    def open_linked_projects(self):


@darshan-serpent This returns type action so the name need to be according:
s/open_linked_projects
r/action_open_linked_projects

victormmtorres · 2017-07-11T10:53:11Z

business_requirement_deliverable_project/models/project.py

+    )
+
+    @api.multi
+    def open_linked_br_dl(self):


@darshan-serpent This returns type action so the name need to be according:
s/open_linked_br_dl
r/action_open_linked_br_dl

YogeshMahera-SerpentCS · 2017-07-12T04:47:01Z

@victormartinelicocorp could you please review.

elicoidal · 2017-07-13T07:55:51Z

@YogeshMahera-SerpentCS Can you recheck Travis?

YogeshMahera-SerpentCS · 2017-07-17T05:46:42Z

@elicoidal Travis Green

elicoidal · 2017-07-17T06:37:56Z

@darshan-serpent I still see many issues with smart buttons in Project and the more I think about the more I think this is anyway a mistake create a smart button for this kind of field: it should be a simple m2o field right (for one given project, there could only be one BR, right?) ? If so I would put it below customer in the project form
cc @victormartinelicocorp @sudhir-serpentcs

elicoidal · 2017-07-19T01:46:47Z

@sudhir-serpentcs any feedback on this?

YogeshMahera-SerpentCS · 2017-07-21T08:31:18Z

@elicoidal Could you please review

elicoidal

@YogeshMahera-SerpentCS LGTM!

elicoidal · 2017-07-21T09:07:12Z

@victormartinelicocorp @dreispt @pedrobaeza Thanks for your review

victormmtorres · 2017-07-21T09:55:52Z

business_requirement_deliverable_project/models/business.py

+    @api.depends('linked_project', 'deliverable_lines')
+    def _compute_linked_project_count(self):
+        for rec in self:
+            domain = ['|',


@darshan-serpent @YogeshMahera-SerpentCS Need to understand the exactly purpose of this domain?
This two fields:
business_requirement_id
business_requirement_deliverable_id

As parameters domains means should be fields on the business.requirement model, right?

victormmtorres

thanks @darshan-serpent @sudhir-serpentcs

victormmtorres · 2017-08-23T06:52:01Z

@elicoidal @seb-elico As you know we could see just the code that changes when it's created a PR.

@YogeshMahera-SerpentCS Please it's very important to be sure and understand the scope. So if the topic is Modify projects and BR id relationship how comes that still exists linked_project fields on BR and BRD?

Furthermore on wizard for generate projects still exist check and assignations that depends on linked_project.

Others smalls details, that could be quick correct.

Now we have and issue #241 and now I have to review the whole code and check whether is new or old modification.

…CA#192) * [IMP][8.0][22070][ISSUE#115]-Improved code as per changes * [IMP]Improved domain and added copy=False in linked_project * [ADD/IMP]Linked Project with BR and DL with Smartbutton * [IMP]Improved code * [IMP]Count number of linked project in BR,removed count function and veriable from project * [IMP]Improved method name * [FIX]Fix Travis * [IMP]Improved code * [IMP]Improved code * [IMP] Improved method name to field

[IMP][8.0][22070][ISSUE#115]-Improved code as per changes

0af6a59

elicoidal changed the title ~~[IMP][8.0][22070][ISSUE#115]-Improved code as per changes~~ [IMP][8.0][22070][ISSUE#115]-Modify projects and BR id relationship Jun 30, 2017

[IMP]Improved domain and added copy=False in linked_project

4186258

elicoidal mentioned this pull request Jul 3, 2017

[FIX] [8.0-i177-BR001030-T22331] Improve Earn Value Management Report #206

Merged

elicoidal mentioned this pull request Jul 7, 2017

[WIP][8.0][BR001024] - Added demo data for BR modules #212

Merged

elicoidal added the work in progress label Jul 10, 2017

elicoidal added this to the 8.0 milestone Jul 10, 2017

serpentcs-dev1 added 3 commits July 10, 2017 15:15

Merge branch '8.0' of https://github.com/OCA/business-requirement int…

3aeb51e

…o 8.0-22070-Issue-115-link_with_generated_projects

[ADD/IMP]Linked Project with BR and DL with Smartbutton

489c265

[IMP]Improved code

b538893

serpentcs-dev1 force-pushed the 8.0-22070-Issue-115-link_with_generated_projects branch from d84a510 to b538893 Compare July 10, 2017 11:35

[IMP]Count number of linked project in BR,removed count function and …

3f8be9c

…veriable from project

victormmtorres suggested changes Jul 11, 2017

View reviewed changes

[IMP]Improved method name

75c2eec

serpentcs-dev1 force-pushed the 8.0-22070-Issue-115-link_with_generated_projects branch from d58eaaf to 75c2eec Compare July 11, 2017 10:58

[FIX]Fix Travis

a605c51

serpentcs-dev1 force-pushed the 8.0-22070-Issue-115-link_with_generated_projects branch from 7e6e85d to a605c51 Compare July 14, 2017 05:17

rubencabrera mentioned this pull request Jul 17, 2017

[ADD] Create BR from issues #174

Merged

[IMP]Improved code

e7883eb

serpentcs-dev1 force-pushed the 8.0-22070-Issue-115-link_with_generated_projects branch from 5082649 to e7883eb Compare July 21, 2017 07:53

elicoidal approved these changes Jul 21, 2017

View reviewed changes

elicoidal added needs review and removed work in progress labels Jul 21, 2017

victormmtorres reviewed Jul 21, 2017

View reviewed changes

[IMP]Improved code

a893fb5

victormmtorres approved these changes Jul 21, 2017

View reviewed changes

[IMP] Improved method name to field

bfa65cf

serpentcs-dev1 force-pushed the 8.0-22070-Issue-115-link_with_generated_projects branch from 3db392c to bfa65cf Compare July 21, 2017 10:27

elicoidal added the approved label Jul 21, 2017

elicoidal mentioned this pull request Jul 21, 2017

Design flaw for the link with the generated project #115

Closed

elicoidal merged commit 2ffd353 into OCA:8.0 Jul 24, 2017

victormmtorres mentioned this pull request Aug 23, 2017

[brd_project] Tasks are generated in the parent project #241

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IMP][8.0][22070][ISSUE#115]-Modify projects and BR id relationship #192

[IMP][8.0][22070][ISSUE#115]-Modify projects and BR id relationship #192

serpentcs-dev1 commented Jun 29, 2017

elicoidal commented Jun 30, 2017 •

edited

Loading

elicoidal commented Jun 30, 2017 •

edited

Loading

serpentcs-dev1 commented Jun 30, 2017

elicoidal commented Jul 7, 2017

elicoidal commented Jul 10, 2017

serpentcs-dev1 commented Jul 10, 2017

YogeshMahera-SerpentCS commented Jul 10, 2017 •

edited

Loading

elicoidal commented Jul 11, 2017 •

edited

Loading

elicoidal commented Jul 11, 2017

victormmtorres left a comment

victormmtorres Jul 11, 2017

victormmtorres Jul 11, 2017

YogeshMahera-SerpentCS commented Jul 12, 2017 •

edited

Loading

elicoidal commented Jul 13, 2017

YogeshMahera-SerpentCS commented Jul 17, 2017

elicoidal commented Jul 17, 2017

elicoidal commented Jul 19, 2017

YogeshMahera-SerpentCS commented Jul 21, 2017

elicoidal left a comment

elicoidal commented Jul 21, 2017

victormmtorres Jul 21, 2017

victormmtorres left a comment

victormmtorres commented Aug 23, 2017

[IMP][8.0][22070][ISSUE#115]-Modify projects and BR id relationship #192

[IMP][8.0][22070][ISSUE#115]-Modify projects and BR id relationship #192

Conversation

serpentcs-dev1 commented Jun 29, 2017

elicoidal commented Jun 30, 2017 • edited Loading

elicoidal commented Jun 30, 2017 • edited Loading

serpentcs-dev1 commented Jun 30, 2017

elicoidal commented Jul 7, 2017

elicoidal commented Jul 10, 2017

serpentcs-dev1 commented Jul 10, 2017

YogeshMahera-SerpentCS commented Jul 10, 2017 • edited Loading

elicoidal commented Jul 11, 2017 • edited Loading

elicoidal commented Jul 11, 2017

victormmtorres left a comment

Choose a reason for hiding this comment

victormmtorres Jul 11, 2017

Choose a reason for hiding this comment

victormmtorres Jul 11, 2017

Choose a reason for hiding this comment

YogeshMahera-SerpentCS commented Jul 12, 2017 • edited Loading

elicoidal commented Jul 13, 2017

YogeshMahera-SerpentCS commented Jul 17, 2017

elicoidal commented Jul 17, 2017

elicoidal commented Jul 19, 2017

YogeshMahera-SerpentCS commented Jul 21, 2017

elicoidal left a comment

Choose a reason for hiding this comment

elicoidal commented Jul 21, 2017

victormmtorres Jul 21, 2017

Choose a reason for hiding this comment

victormmtorres left a comment

Choose a reason for hiding this comment

victormmtorres commented Aug 23, 2017

elicoidal commented Jun 30, 2017 •

edited

Loading

elicoidal commented Jun 30, 2017 •

edited

Loading

YogeshMahera-SerpentCS commented Jul 10, 2017 •

edited

Loading

elicoidal commented Jul 11, 2017 •

edited

Loading

YogeshMahera-SerpentCS commented Jul 12, 2017 •

edited

Loading