Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0][I-215][BR1030]-Set Default Values #219

Merged
merged 2 commits into from
Jul 24, 2017
Merged

[8.0][I-215][BR1030]-Set Default Values #219

merged 2 commits into from
Jul 24, 2017

Conversation

YogeshMahera-SerpentCS
Copy link
Member

Issue #215

  • Set default Values for BR,DL,RL

elicoidal
elicoidal reviewed Jul 20, 2017
View reviewed changes
business_requirement_deliverable/tests/test_br.py Outdated
@@ -200,6 +200,7 @@ def test_resource_type_change(self):
for line in self.br.deliverable_lines:
for resource in line.resource_ids:
if resource and resource.resource_type == 'task':
resource.resource_type_change()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why triggering it twice?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First method triggering for else condition then it write resource_type=procurement so second triggering for if condition.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YogeshMahera-SerpentCS Then please split into two test as is easier to understand.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohky sure @victormartinelicocorp

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohky sure @victormartinelicocorp

elicoidal
elicoidal approved these changes Jul 21, 2017
View reviewed changes
Copy link
Contributor

@elicoidal elicoidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional tests are OK
LGTM

@elicoidal
Copy link
Contributor

@victormartinelicocorp

@elicoidal elicoidal merged commit 0b7954b into OCA:8.0 Jul 24, 2017
@YogeshMahera-SerpentCS YogeshMahera-SerpentCS deleted the 8.0-I-215-BR1030-set_default_values_BR branch July 25, 2017 05:12
ruter-lyu pushed a commit to ruter-lyu/business-requirement that referenced this pull request Mar 15, 2019
@YogeshMahera-SerpentCS
[8.0][I-215][BR1030]-Set Default Values (OCA#219)
a628153 
* [IMP][I215][BR1030]Set Default Values

* [IMP]Improved test-cases
ruter-lyu pushed a commit to ruter-lyu/business-requirement that referenced this pull request Mar 15, 2019
@YogeshMahera-SerpentCS
[8.0][I-215][BR1030]-Set Default Values (OCA#219)
5f77a18 
* [IMP][I215][BR1030]Set Default Values

* [IMP]Improved test-cases
ruter-lyu pushed a commit to ruter-lyu/business-requirement that referenced this pull request Mar 15, 2019
@YogeshMahera-SerpentCS
[8.0][I-215][BR1030]-Set Default Values (OCA#219)
36bb4db 
* [IMP][I215][BR1030]Set Default Values

* [IMP]Improved test-cases
victormmtorres pushed a commit to Tecnativa/business-requirement that referenced this pull request Jun 4, 2019
@YogeshMahera-SerpentCS
[8.0][I-215][BR1030]-Set Default Values (OCA#219)
8908ee0 
* [IMP][I215][BR1030]Set Default Values

* [IMP]Improved test-cases
victormmtorres pushed a commit to Tecnativa/business-requirement that referenced this pull request Jun 6, 2019
@YogeshMahera-SerpentCS
[8.0][I-215][BR1030]-Set Default Values (OCA#219)
b336a0b 
* [IMP][I215][BR1030]Set Default Values

* [IMP]Improved test-cases
victormmtorres pushed a commit to Tecnativa/business-requirement that referenced this pull request Jun 6, 2019
@YogeshMahera-SerpentCS
[8.0][I-215][BR1030]-Set Default Values (OCA#219)
37dcfe1 
* [IMP][I215][BR1030]Set Default Values

* [IMP]Improved test-cases
pedrobaeza pushed a commit to Tecnativa/business-requirement that referenced this pull request Jun 21, 2019
@YogeshMahera-SerpentCS @pedrobaeza
[8.0][I-215][BR1030]-Set Default Values (OCA#219)
e102be2 
* [IMP][I215][BR1030]Set Default Values

* [IMP]Improved test-cases
victormmtorres pushed a commit to Tecnativa/business-requirement that referenced this pull request Jun 21, 2019
@YogeshMahera-SerpentCS
[8.0][I-215][BR1030]-Set Default Values (OCA#219)
0a8fd96 
* [IMP][I215][BR1030]Set Default Values

* [IMP]Improved test-cases
victormmtorres pushed a commit to Tecnativa/business-requirement that referenced this pull request Jun 21, 2019
@YogeshMahera-SerpentCS
[8.0][I-215][BR1030]-Set Default Values (OCA#219)
7e6cca2 
* [IMP][I215][BR1030]Set Default Values

* [IMP]Improved test-cases
victormmtorres pushed a commit to Tecnativa/business-requirement that referenced this pull request Jun 26, 2019
@YogeshMahera-SerpentCS
[8.0][I-215][BR1030]-Set Default Values (OCA#219)
2c0de1b 
* [IMP][I215][BR1030]Set Default Values

* [IMP]Improved test-cases
victormmtorres pushed a commit to Tecnativa/business-requirement that referenced this pull request Jun 26, 2019
@YogeshMahera-SerpentCS
[8.0][I-215][BR1030]-Set Default Values (OCA#219)
e5613ef 
* [IMP][I215][BR1030]Set Default Values

* [IMP]Improved test-cases
victormmtorres pushed a commit to Tecnativa/business-requirement that referenced this pull request Jul 25, 2019
@YogeshMahera-SerpentCS
[8.0][I-215][BR1030]-Set Default Values (OCA#219)
e73e2e8 
* [IMP][I215][BR1030]Set Default Values

* [IMP]Improved test-cases
victormmtorres pushed a commit to Tecnativa/business-requirement that referenced this pull request Aug 9, 2019
@YogeshMahera-SerpentCS
[8.0][I-215][BR1030]-Set Default Values (OCA#219)
f334a34 
* [IMP][I215][BR1030]Set Default Values

* [IMP]Improved test-cases
victormmtorres pushed a commit to Tecnativa/business-requirement that referenced this pull request Aug 19, 2019
@YogeshMahera-SerpentCS
[8.0][I-215][BR1030]-Set Default Values (OCA#219)
aa23304 
* [IMP][I215][BR1030]Set Default Values

* [IMP]Improved test-cases
Tardo pushed a commit to Tecnativa/business-requirement that referenced this pull request Jan 24, 2020
@YogeshMahera-SerpentCS @Tardo
[8.0][I-215][BR1030]-Set Default Values (OCA#219)
1e50dd1 
* [IMP][I215][BR1030]Set Default Values

* [IMP]Improved test-cases
Tardo pushed a commit to Tecnativa/business-requirement that referenced this pull request Jan 27, 2020
@YogeshMahera-SerpentCS @Tardo
[8.0][I-215][BR1030]-Set Default Values (OCA#219)
dfdb10c 
* [IMP][I215][BR1030]Set Default Values

* [IMP]Improved test-cases
Tardo pushed a commit to Tecnativa/business-requirement that referenced this pull request Mar 3, 2020
@YogeshMahera-SerpentCS @Tardo
[8.0][I-215][BR1030]-Set Default Values (OCA#219)
48a72d0 
* [IMP][I215][BR1030]Set Default Values

* [IMP]Improved test-cases
Tardo pushed a commit to Tecnativa/business-requirement that referenced this pull request Mar 5, 2020
@YogeshMahera-SerpentCS @Tardo
[8.0][I-215][BR1030]-Set Default Values (OCA#219)
42244cd 
* [IMP][I215][BR1030]Set Default Values

* [IMP]Improved test-cases
Tardo pushed a commit to Tecnativa/business-requirement that referenced this pull request Mar 30, 2020
@YogeshMahera-SerpentCS @Tardo
[8.0][I-215][BR1030]-Set Default Values (OCA#219)
22eebe2 
* [IMP][I215][BR1030]Set Default Values

* [IMP]Improved test-cases
victoralmau pushed a commit to Tecnativa/business-requirement that referenced this pull request Oct 14, 2021
@YogeshMahera-SerpentCS @victoralmau
[8.0][I-215][BR1030]-Set Default Values (OCA#219)
6ed7433 
* [IMP][I215][BR1030]Set Default Values

* [IMP]Improved test-cases
victoralmau pushed a commit to Tecnativa/business-requirement that referenced this pull request Oct 14, 2021
@YogeshMahera-SerpentCS @victoralmau
[8.0][I-215][BR1030]-Set Default Values (OCA#219)
576d978 
* [IMP][I215][BR1030]Set Default Values

* [IMP]Improved test-cases
victoralmau pushed a commit to Tecnativa/business-requirement that referenced this pull request Nov 11, 2021
@YogeshMahera-SerpentCS @victoralmau
[8.0][I-215][BR1030]-Set Default Values (OCA#219)
0c8df23 
* [IMP][I215][BR1030]Set Default Values

* [IMP]Improved test-cases
victoralmau pushed a commit to Tecnativa/business-requirement that referenced this pull request Nov 15, 2021
@YogeshMahera-SerpentCS @victoralmau
[8.0][I-215][BR1030]-Set Default Values (OCA#219)
780137a 
* [IMP][I215][BR1030]Set Default Values

* [IMP]Improved test-cases
victoralmau pushed a commit to Tecnativa/business-requirement that referenced this pull request Nov 15, 2021
@YogeshMahera-SerpentCS @victoralmau
[8.0][I-215][BR1030]-Set Default Values (OCA#219)
23bc222 
* [IMP][I215][BR1030]Set Default Values

* [IMP]Improved test-cases
MosabWadea pushed a commit to MosabWadea/business-requirement that referenced this pull request Mar 5, 2022
@YogeshMahera-SerpentCS @MosabWadea
[8.0][I-215][BR1030]-Set Default Values (OCA#219)
7a118e6 
* [IMP][I215][BR1030]Set Default Values

* [IMP]Improved test-cases
MosabWadea pushed a commit to MosabWadea/business-requirement that referenced this pull request Mar 5, 2022
@YogeshMahera-SerpentCS @MosabWadea
[8.0][I-215][BR1030]-Set Default Values (OCA#219)
2db55c3 
* [IMP][I215][BR1030]Set Default Values

* [IMP]Improved test-cases
bizzappdev pushed a commit to BizzAppDev-Systems/business-requirement that referenced this pull request Mar 4, 2023
@YogeshMahera-SerpentCS @bizzappdev
[8.0][I-215][BR1030]-Set Default Values (OCA#219)
e81e594 
* [IMP][I215][BR1030]Set Default Values

* [IMP]Improved test-cases
AntoniRomera pushed a commit to AntoniRomera/business-requirement that referenced this pull request Jul 4, 2023
@YogeshMahera-SerpentCS
[8.0][I-215][BR1030]-Set Default Values (OCA#219)
1c758b2 
* [IMP][I215][BR1030]Set Default Values

* [IMP]Improved test-cases
dreispt pushed a commit to dreispt/business-requirement that referenced this pull request Apr 27, 2024
@YogeshMahera-SerpentCS @dreispt
[8.0][I-215][BR1030]-Set Default Values (OCA#219)
9467eab 
* [IMP][I215][BR1030]Set Default Values

* [IMP]Improved test-cases
@dreispt dreispt mentioned this pull request Apr 27, 2024
Open
1 task
dreispt pushed a commit to dreispt/business-requirement that referenced this pull request Apr 27, 2024
@YogeshMahera-SerpentCS @dreispt
[8.0][I-215][BR1030]-Set Default Values (OCA#219)
2c9a107 
* [IMP][I215][BR1030]Set Default Values

* [IMP]Improved test-cases
NachoAlesLopez pushed a commit to NachoAlesLopez/business-requirement that referenced this pull request Apr 28, 2024
@YogeshMahera-SerpentCS @NachoAlesLopez
[8.0][I-215][BR1030]-Set Default Values (OCA#219)
1152dc2 
* [IMP][I215][BR1030]Set Default Values

* [IMP]Improved test-cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elicoidal elicoidal elicoidal approved these changes

@victormmtorres victormmtorres victormmtorres approved these changes

Assignees
No one assigned
Labels
approved needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YogeshMahera-SerpentCS @elicoidal @victormmtorres