[IMP] Improved Printouts Headers - #259 #261

YogeshMahera-SerpentCS · 2017-10-04T08:08:26Z

Business Requirement Report.pdf

elicoidal · 2017-10-04T08:46:23Z

#259

elicoidal · 2017-10-04T08:48:07Z

Almost there @YogeshMahera-SerpentCS :

Source: should be 2 columns wide
Can you reduce the space between Business Requirement Document and Name?

Please make sure to change the 4 reports

YogeshMahera-SerpentCS · 2017-10-04T09:12:18Z

@elicoidal Improved it

YogeshMahera-SerpentCS · 2017-10-04T09:13:27Z

BR Business Requirement Report.pdf
BRD Business Requirement Deliverable Report.pdf
BRDR Business Requirement Deliverable Resource Report.pdf

elicoidal

Tested and LGTM

elicoidal · 2017-10-04T13:37:22Z

business_requirement/models/business.py

@@ -290,6 +290,17 @@ def write(self, vals):
                    raise ValidationError(_(
                        'You can only move to the following stage: '
                        'draft/confirmed /cancel/drop.'))
+            if vals['state'] == 'stakeholder_approval':


Not sure why you have this modification here

In #259

Approval date should be when the SOA state is changed

That's why I have added this code here

elicoidal · 2017-10-04T13:38:49Z

@sudhir-serpentcs can you review?

sudhir-serpentcs · 2017-10-05T08:57:49Z

Small layout changes. Other than LGTM
@YogeshMahera-SerpentCS
CC: @elicoidal

YogeshMahera-SerpentCS · 2017-10-06T05:36:10Z

@elicoidal @sudhir-serpentcs Improved changes

YogeshMahera-SerpentCS · 2017-10-06T06:45:39Z

Fixed issue of #254

BRD Business Requirement Deliverable Report.pdf
BRDR Business Requirement Deliverable Resource Report.pdf

@elicoidal

elicoidal · 2017-10-06T11:58:23Z

@YogeshMahera-SerpentCS I would suggest

to underline as well "Deliverables" titles

elicoidal · 2017-10-06T12:28:26Z

Report Other resources: not correct for the sequence for RL and DL

Rest is good and tested

…to 10-issue-259-reports

YogeshMahera-SerpentCS · 2017-10-07T06:16:59Z

@elicoidal Could you please review it

elicoidal

Functional tests OK

elicoidal · 2017-10-09T07:57:42Z

@victormartinelicocorp can you have a look?

victormmtorres

LGTM

* [IMP]Improved code * [IMP]Improved code * [IMP]Improved code * [IMP]Improved code * [IMP]Improved changes * [IMP]Improved changes * [FIX]Fixed issue of 254 * [IMP]Improved code

…t… (OCA#225) * [MIG]Migrated Business requirement deliverable cost module from 8.0 to 10.0 * [ADD]Added reports from BRD to BRDC: report BRDR and BRORR * [MV]Moved BR Resource report to BRD * [IMP]Improved code for pivot views * [IMP]Improved code * [ADD/IMP]Added Business cost group as selection * [FIX-ISSUE-258]-Fixed issue of 253 * [ADD/IMP]Added Pricelist field in BR form/Improved currency field positons and code * [IMP]Improved code * [IMP]Improved code * [IMP]Improved code * [IMP]Imporved code for deliverable lines * [IMP]Improved code for cost control and made changes as per review * [IMP]Fixed Pylint * [IMP]Fixed Pylint * [IMP]Improved test-cases and removed unneccesory method * [FIX]Fixed Pylint * [IMP]Imporved code * [FIX]Fixed Pylint * [FIX]Fixed Pylint * [FIX]Fixed Pylint * [FIX]Fixed coversall * [IMP]Improved code * [IMP]Improved code * [IMP]Improved code [PR-REF 225-229]-[IMP]-Improved demo data file and added group in dl total revenue (OCA#248) * [IMP]Improved demo data file and added group in dl total revenue * [IMP/ADD]Added groups in field,moved field in BR tree view * [MV]Moved help from PR 229 * [FIX]Fixed issues 249 * [IMP]Improved code for issues of 249 * [IMP]Improved code * [ADD]Bymistake remove field from xml view [10.0]-[MIG]-Migrated Business requirement deliverable project from v8 to 10 (OCA#231) * [MIG]Migrated Business requirement deliverable project from v8 to 10 * [IMP]Improved code * [IMP]Added Application true * [IMP]Improved code as per issue of 240,241,242 * [WIP]Improved code * [FIX]fixed issue of project name which comes from last DL. * [IMP]Fixed pylint * [FIX]Fixed Pylint * [IMP]Improved code for project module * [IMP]Improved demo data and other remain points * [IMP]Improved code * [IMP]Improved code * [ADD]Added account analytic parent as dependancy * [IMP]Improved code * [IMP]Improved code * [IMP]Improved code * [IMP]Improved code * [IMP]Improved code * [IMP]Improved code * [IMP]Improved code * [IMP]Improved issue 251 * [IMP]Improved code * [FIX]Fixed Pylint [IMP] Improved Printouts Headers - OCA#259 (OCA#261) * [IMP]Improved code * [IMP]Improved code * [IMP]Improved code * [IMP]Improved code * [IMP]Improved changes * [IMP]Improved changes * [FIX]Fixed issue of 254 * [IMP]Improved code